Bump OpenImageIO minimum version 1.8 > 2.2.1 for install_deps.sh #82521

New Issue

Garry R. Osgood · 2020-11-09T01:13:47+01:00

Garry R. Osgood commented

2020-11-09 01:13:47 +01:00

System Information
Operating system: Linux-5.9.6-gentoo-bertha-x86_64-Intel-R-_Xeon-R-CPU_E5-2630_v4@_2.20GHz-with-gentoo-2.7 64 Bits
Graphics card: Radeon Pro WX 9100 (VEGA10, DRM 3.39.0, 5.9.6-gentoo-bertha, LLVM 9.0.1) X.Org 4.6 (Core Profile) Mesa 20.1.10

Blender Version
Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-08 15:12, hash: 39012146e1
Worked: 2.92.0 91d320edc3

Short description of error
Building blender 39012146e1 here gave rise to this compilation error:

/home/gosgood/git_repositories/blender/intern/cycles/blender/blender_shader.cpp:122:23: error: ‘concat’ is not a member of ‘OpenImageIO_v1_8::ustring’
  122 |       return ustring::concat(object_attr_prefix, name);
      |                       ^~~~~~
/home/gosgood/git_repositories/blender/intern/cycles/blender/blender_shader.cpp:124:23: error: ‘concat’ is not a member of ‘OpenImageIO_v1_8::ustring’
  124 |       return ustring::concat(instancer_attr_prefix, name);
      |                       ^~~~~~
make[3]: *** [intern/cycles/blender/CMakeFiles/bf_intern_cycles.dir/build.make:255: intern/cycles/blender/CMakeFiles/bf_intern_cycles.dir/blender_shader.cpp.o] Error 1
...

The code giving rise to this error stems from a 03-November-2020 commit: 6fdcca8de6.

It relies on OpenImageIO capabilities introduced with [Add concat function to ustring and Strutil #2478 ]] which are not present in version 1.8.17 installed on this system at the time of the failed build. Per [ https:*github.com/OpenImageIO/oiio/releases/tag/Release-2.2.6.1|OpenImageIO 2.2.6.1 , this pull request was included in OpenImageIO 2.2.1. Upgrading to OpenImageIO-2.2.8.0 gave rise to a clean blender build.

Currently, ##install_deps.sh## reports a minimum acceptable version OpenImageIO version of 1.8.

OIIO_VERSION="2.1.15.0"
OIIO_VERSION_SHORT="2.1"
OIIO_VERSION_MIN="1.8"
OIIO_VERSION_MAX="3.0"
OIIO_FORCE_BUILD=false
OIIO_FORCE_REBUILD=false
OIIO_SKIP=false

gosgood@bertha ~/git_repositories/blender/build_files/build_environment $ ./install_deps.sh --show-deps
...
    * OpenImageIO 1.8 (from https://github.com/OpenImageIO/oiio/archive/Release-2.1.15.0.tar.gz).
...

It seems, in light of this recent commit, the minimum OpenImageIO version should be 2.2.1.

Exact steps for others to reproduce the error

Generally, configure the ##CMake## build environment to use installed system libraries in lieu of blender-provided bundled libraries.
Use ##install_deps.sh --show-deps## to ensure installed system libraries are at or above the minimum versions.
Compile Blender with OpenImageIO-1.8.x, purported to be minimum version.

**System Information** Operating system: Linux-5.9.6-gentoo-bertha-x86_64-Intel-R-_Xeon-R-_CPU_E5-2630_v4_@_2.20GHz-with-gentoo-2.7 64 Bits Graphics card: Radeon Pro WX 9100 (VEGA10, DRM 3.39.0, 5.9.6-gentoo-bertha, LLVM 9.0.1) X.Org 4.6 (Core Profile) Mesa 20.1.10 **Blender Version** Broken: version: 2.92.0 Alpha, branch: master, commit date: 2020-11-08 15:12, hash: `39012146e1` Worked: 2.92.0 91d320edc3 **Short description of error** Building blender 39012146e1 here gave rise to this compilation error: ``` /home/gosgood/git_repositories/blender/intern/cycles/blender/blender_shader.cpp:122:23: error: ‘concat’ is not a member of ‘OpenImageIO_v1_8::ustring’ 122 | return ustring::concat(object_attr_prefix, name); | ^~~~~~ /home/gosgood/git_repositories/blender/intern/cycles/blender/blender_shader.cpp:124:23: error: ‘concat’ is not a member of ‘OpenImageIO_v1_8::ustring’ 124 | return ustring::concat(instancer_attr_prefix, name); | ^~~~~~ make[3]: *** [intern/cycles/blender/CMakeFiles/bf_intern_cycles.dir/build.make:255: intern/cycles/blender/CMakeFiles/bf_intern_cycles.dir/blender_shader.cpp.o] Error 1 ... ``` The code giving rise to this error stems from a 03-November-2020 commit: 6fdcca8de6. It relies on OpenImageIO capabilities introduced with [Add concat function to ustring and Strutil #2478 ]] which are not present in version 1.8.17 installed on this system at the time of the failed build. Per [[ https:*github.com/OpenImageIO/oiio/releases/tag/Release-2.2.6.1|OpenImageIO 2.2.6.1 ](https:*github.com/OpenImageIO/oiio/pull/2478/files), this pull request was included in OpenImageIO 2.2.1. Upgrading to OpenImageIO-2.2.8.0 gave rise to a clean blender build. Currently, ##install_deps.sh## reports a minimum acceptable version OpenImageIO version of 1.8. ``` OIIO_VERSION="2.1.15.0" OIIO_VERSION_SHORT="2.1" OIIO_VERSION_MIN="1.8" OIIO_VERSION_MAX="3.0" OIIO_FORCE_BUILD=false OIIO_FORCE_REBUILD=false OIIO_SKIP=false gosgood@bertha ~/git_repositories/blender/build_files/build_environment $ ./install_deps.sh --show-deps ... * OpenImageIO 1.8 (from https://github.com/OpenImageIO/oiio/archive/Release-2.1.15.0.tar.gz). ... ``` It seems, in light of this recent commit, the minimum OpenImageIO version should be 2.2.1. **Exact steps for others to reproduce the error** - Generally, configure the ##CMake## build environment to use installed system libraries in lieu of blender-provided bundled libraries. - Use ##install_deps.sh --show-deps## to ensure installed system libraries are at or above the minimum versions. - Compile Blender with OpenImageIO-1.8.x, purported to be minimum version.

Garry R. Osgood commented

2020-11-09 01:13:47 +01:00

Added subscriber: @grosgood

Philipp Oeser commented

2020-11-11 14:04:41 +01:00

Added subscribers: @mont29, @lichtwerk

Philipp Oeser commented

2020-11-11 14:04:41 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2020-11-11 14:04:41 +01:00

Looks like a valid claim.

#76184 (Library upgrades for 2.90) mentiones OIIO at version 2.1.15.0 and it looks like the SVN libs are at 2.1.15.0 as well?

I can build with the SVN libs, and it looks like I can build with Fedoras 2.1.18 as well, so not sure what is going on.

Maybe @mont29 knows more?

Looks like a valid claim. #76184 (Library upgrades for 2.90) mentiones OIIO at version 2.1.15.0 and it looks like the SVN libs are at 2.1.15.0 as well? I can build with the SVN libs, and it looks like I can build with Fedoras 2.1.18 as well, so not sure what is going on. Maybe @mont29 knows more?

Bastien Montagne commented

2020-11-11 15:07:04 +01:00

According to 13518cc403/CHANGES.md (release-2112-2-mar-2020----compared-to-2111) ustring::concat was added in 2.1.12, so I guess that's our minimal version now.

According to https://github.com/OpenImageIO/oiio/blob/13518cc403e17063c8dfe415cd369bbadd2202c8/CHANGES.md#release-2112-2-mar-2020----compared-to-2111 `ustring::concat` was added in `2.1.12`, so I guess that's our minimal version now.

blender-admin commented

2020-11-11 15:08:27 +01:00

This issue was referenced by 5b5ec0a2e9

This issue was referenced by 5b5ec0a2e910a42d7c02774a47fd9c70b6f16f06

Bastien Montagne commented

2020-11-11 15:10:24 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Bastien Montagne closed this issue

2020-11-11 15:10:24 +01:00

Bastien Montagne self-assigned this 2020-11-11 15:10:24 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Bump OpenImageIO minimum version 1.8 > 2.2.1 for install_deps.sh #82521