Sockets Colors for int, boolean #82689
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#82689
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This is the first time we expose booleans, ints as sockets. We need to confirm if we really want a single color per type.
Added subscriber: @dfelinto
#84494 was marked as duplicate of this issue
Added subscriber: @Blendify
We should also investigate using different socket shapes as well for the different data types.
This issue was referenced by
8268b9827a
Changed status from 'Needs Triage' to: 'Confirmed'
Changed status from 'Confirmed' to: 'Resolved'
This issue was referenced by
96e131f246
Added subscriber: @brecht
Testing this in the shader nodes, I find these changes as a whole worse than before. I approved changing the shader socket color to red, but it needs to fit together as a whole.
Added subscriber: @JulianEisel
Was color-blindness considered for these tweaks? Whenever we use colors to communicate meaning we should keep that in mind. There are various (online) tools available to simulate color-blindness.
Added subscriber: @JacquesLucke
Added subscriber: @Erindale
I'm not really sure why the decision to change to red - the input and output nodes are already Red? The shader nodes are a specific type of node within shaders and (at least for NPR) entire shaders can be created without them at all.
My biggest concern is the yellow RGB socket and the now also yellow scalar socket.
Considering that RGB and XYZ vectors are converted to Scalar differently with RGB - Scalar being the non-intuitive transfer it seems especially risky putting those sockets so close in colour.
It is very common in a shader to use a MixRGB to affect coordinates so having someone connect a yellow to a slightly different yellow socket is going to break the whole shader.
They look close enough that a beginner could reasonably assume that they can be joined together.
Accessibility point of view: They look identical for anyone with Blue-Blind/Tritanopia.
Is there an intent to address the issues I raised for 2.92? If not I propose we revert this change for the most part, as to me this looks like a regression for shading nodes at least.
This issue was referenced by
09fe0e8aa9
Yes I'm preparing a patch to address some of these issues based on feedback.
I also changed the shader sockets and node headers back to green now in
09fe0e8aa9
, since we're in bcon3 and this was still not in a good state in my opinion.Thanks! Hopefully we can revisit this topic more carefully for 3.0 if we get the new node design without the header background (which limits the color choices because of the node label).