Node editor context implementation #82691

New Issue

Dalai Felinto · 2020-11-13T15:50:31+01:00

Dalai Felinto commented

2020-11-13 15:50:31 +01:00

See #82366.

Dalai Felinto commented

2020-11-13 15:50:31 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Dalai Felinto commented

2020-11-13 15:50:31 +01:00

Added subscriber: @dfelinto

Hans Goudey was assigned by Dalai Felinto

2020-11-19 15:44:38 +01:00

Dalai Felinto commented

2020-11-24 18:23:23 +01:00

The current implementation deviates a bit from the design, see: 72386c64ef. The main reason to change that was to conciliate mouse hover (X, Shift +D, A) and having an active modifier.

However, having a consistent editor with the rest of Blender is a bit more important. So the follow up proposed design is:

There is always an active modifier (unless there are no modifiers)
The mouse hover / shortcut behaviour we have now is fine (A works based on mouse, X, Shift+D works based on active).

The reasoning:
A is a user interface shortcut, so it is fine to be based on the mouse position.
X, Shift +D, are related to object data, so makes sense to work for the active modifier.

The current implementation deviates a bit from the design, see: 72386c64ef. The main reason to change that was to conciliate mouse hover (X, Shift +D, A) and having an active modifier. However, having a consistent editor with the rest of Blender is a bit more important. So the follow up proposed design is: * There is always an active modifier (unless there are no modifiers) * The mouse hover / shortcut behaviour we have now is fine (A works based on mouse, X, Shift+D works based on active). The reasoning: A is a user interface shortcut, so it is fine to be based on the mouse position. X, Shift +D, are related to object data, so makes sense to work for the active modifier.

Hans Goudey commented

2020-11-24 22:59:08 +01:00

8a2b329a21 Addresses these points.

Dalai Felinto commented

2020-11-25 11:48:37 +01:00

Bug report: X, Shift+D work always in modifiers now, even if I'm in the constraint panel.

Jacques Lucke commented

2020-11-25 12:11:52 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2020-11-25 12:11:52 +01:00

Should the "New" button be removed?

Should the "New" button be removed? ![image.png](https://archive.blender.org/developer/F9371894/image.png)

Hans Goudey commented

2020-11-25 21:49:10 +01:00

6c241b2dd7

modifier_active_header_final-2020-11-25_15.00.32.mp4

The only remaining task here as far as I can tell is the modifiers ("slots") popover from Pablo's initial mockup.

This is a bit confusing to me though. First of all, I would expect it to show the "slots" analog, the modifiers, rather than the node groups themselves, considering the main drop-down has the list of node groups already.
Second, showing the full list of modifiers here might be somewhat odd, because there will be situations where most, if not all, modifiers are not node modifiers. If you only display the node modifiers,
the operation buttons here don't make much sense to show.

6c241b2dd7 |[modifier_active_header_final-2020-11-25_15.00.32.mp4](https://archive.blender.org/developer/F9374871/modifier_active_header_final-2020-11-25_15.00.32.mp4)| | -- | The only remaining task here as far as I can tell is the modifiers ("slots") popover from Pablo's initial mockup. ![image.png](https://archive.blender.org/developer/F9245146/image.png) This is a bit confusing to me though. First of all, I would expect it to show the "slots" analog, the modifiers, rather than the node groups themselves, considering the main drop-down has the list of node groups already. Second, showing the full list of modifiers here might be somewhat odd, because there will be situations where most, if not all, modifiers are not node modifiers. If you only display the node modifiers, the operation buttons here don't make much sense to show.

Hans Goudey commented

2020-11-25 21:51:50 +01:00

Of course there is the breadcrumb text too, but I have to admit I've sort of split that into a separate task in my head, because the code area is quite different, it seems more general, and it doesn't relate specifically to this sort of interaction.

Dalai Felinto commented

2020-11-26 10:51:26 +01:00

Ok to have the breadcrumb as a separate task, but then said task needs to be created. And it will probably be left for the "community" since we don't have this breadcrumb for materials either. Though I think it is still good to have.

Dalai Felinto commented

2020-11-26 10:54:52 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey was unassigned by Dalai Felinto

2020-11-26 10:54:52 +01:00

Pablo Vazquez was assigned by Dalai Felinto

2020-11-26 10:54:52 +01:00

Dalai Felinto commented

2020-11-26 10:54:52 +01:00

Besides all that I would say it is working beautifully. Great work Hans. Assigning to Pablo so he can test it.

Pablo Vazquez commented

2020-11-27 13:48:58 +01:00

Works like a charm <3

Dalai Felinto commented

2020-11-30 09:28:12 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Dalai Felinto closed this issue

2020-11-30 09:28:12 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node editor context implementation #82691