Sequencer: Improve motion-picture workflow #82755
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#82755
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The media transform has been improved a lot for "sequencing" type of workflow in D8393. Unfortunately, one of the usecases became way more tedious: put source at its original resolution to the sequencer. This is something what is useful for motion-picture, cinematics, and similar situations. It seems like we can easily support this within the new transform design.
Here is the updated and implemented design proposal:
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscribers: @fsiddi, @Sergey, @iss
Added subscriber: @tintwotin
Related: D2506 - but for Transform strips.
My proposal is:
Add
Scale To Fit
checkbox to transform panel. It would either scale image to fit preview(default) or render at original size. See demo here:0001-1413.mp4
This should resolve following requirements:
And add operator
strip_transform_clear
to menu with 4 options - Clear position, scale, rotation and all (previous 3 options combined). See demo here:0001-3110.mp4
This should resolve reseting to default value
Since we already had
Strip -> Transform
menu, I created menu itemImage Transform
. I think this may be a bit confusing.In 3D viewport we use Alt+R, Alt+S, Alt+G to clear object transformation, we could use these in sequencer, but Alt+R is occupied by reload operator. We can also use only one key in sequencer and then adjust operation "adjust last action" panel. I haven't assigned keyboard shortcut yet, so I am open to suggestions. I would probably use Alt+T as it is free.
If there are no objections I can post patch for review.
@iss I think your
Scale to Fit
is calledScale to Fill
(in the first video), whereas yourClear All
isScale to Fit
.{F9308777, size=full}
If you want to introduce presets for scaling, I think the most common options would be:
Scale to Fit
Scale to Fill
Stretch to Fill
Source
- the full source size, unscaled.Custom
- enables Scale X/YOn the
Clear Transform
menu, these functions could go into the panel too, but the question is if these transform options should be expanded into the Preview Toolbar too? If that is the case, these elements should go into the Preview header menu, like in the Transform Tools add-on(my fork: https://github.com/tin2tin/VSE_Transform_Tools (works in 2.8 > 2.91)):{F9308889, size=full}
No, it's scale to fit, but there is already some scale (see properties). I guess I wanted to demonstrate that this property is unchanged, but in the end it was only confusing. Sorry.
Scale to fill sounds also useful, as well as Stretch to Fill. I can implement this very easily and use enum instead of checkbox. I would like to hear feedback from @fsiddi as well though.
The description of operator seems fine to me, aligned with what we've briefly talked about with Francesco here.
The option in the transform panel I don't think it should exist. It introduces secondary setting which defines resolution of strip. For the ease of code and mental model, I'd say the strip scale is the source of truth. For the convenience purposes we might add a button/easy-to-access-menu next to the scale slider, and make that to run an operator.
So it should be operator that would change scale instead? That would violate "Be fully flexible in terms of replacing source: artist can replace media source to higher/lower resolution and have composition intact!"
What I am doing now doesn't look that terrible actually:
I am not sure how? This isn't something what I expect from scale to behave, and here is a test I did:
This is exactly behavior I would expect :)
Ok I think I misunderstood this, will update patch with new operator and add more
scale to X
features proposed by @tintwotin while I am at it.As for the
Clear Transform
operators, reset buttons in the panels are not common, but in the keymap preferences they look like this:Thank you @Sergey for getting this started. I'm evaluating different possible scenarios/workflows currently (provide an operator to alter scale as it's been suggested here, expose the original image dimensions, etc.) and will come with a proposal soon.
After a conversation with a few artists and developers, there is an agreement to revise the implementation of scale as follows.
Thanks to everyone for the feedback!
@fsiddi, thanks for the updated design. Can you please make sure the final design is moved to the task description, so it's always easy to find?
This issue was referenced by
5713626422
Added subscriber: @Pipeliner
Changed status from 'Confirmed' to: 'Resolved'
Resolved by
5713626422