Crash when using annotation tool on object hidden in sculpt mode #83013

New Issue

Sebastian · 2020-11-25T18:44:59+01:00

Sebastian commented

2020-11-25 18:44:59 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.77

Blender Version
Broken: version:

2.90.0
2.90.1
2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: 0f45cab862
2.92.0
Worked: 2.83.9

Short description of error

Open Blender with the default startup scene
Select the cube and switch to sculpt mode
Hide the cube in the outliner
Select the Annotate tool and try to draw
Blender should crash. However, if the Annotate tool is enabled in sculpt mode and the object is hidden afterwards, it doesn't crash.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 451.77 **Blender Version** Broken: version: - 2.90.0 - 2.90.1 - 2.91.0, branch: master, commit date: 2020-11-25 08:34, hash: `0f45cab862` - 2.92.0 Worked: 2.83.9 **Short description of error** - Open Blender with the default startup scene - Select the cube and switch to sculpt mode - Hide the cube in the outliner - Select the *Annotate* tool and try to draw Blender should crash. However, if the *Annotate* tool is enabled in sculpt mode and the object is hidden afterwards, it doesn't crash.

Sebastian commented

2020-11-25 18:44:59 +01:00

Added subscriber: @sebus_93

Robert Guetzkow commented

2020-11-26 00:40:41 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-11-26 00:40:41 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Robert Guetzkow commented

2020-11-26 00:40:41 +01:00

I can confirm this crash in 2.90.1, 2.91 and 2.92. The versions 2.83.x are not affected.

The object ob is NULL which causes a crash when attempting to use

SculptSession *ss = ob->sculpt;

Stack trace from current master branch e09d0c0d077cff79b55ce32ec5124d5faa73e2e7:

createTransSculpt(bContext * C, TransInfo * t) Lines 53	C
createTransData(bContext * C, TransInfo * t) Lines 1241	C
initTransform(bContext * C, TransInfo * t, wmOperator * op, const wmEvent * event, int mode) Lines 1756	C
transformops_data(bContext * C, wmOperator * op, const wmEvent * event) Lines 394	C
transform_invoke(bContext * C, wmOperator * op, const wmEvent * event) Lines 510	C
wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Lines 1296	C
wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Lines 2141	C
wm_handlers_do_keymap_with_keymap_handler(bContext * C, wmEvent * event, ListBase * handlers, wmEventHandler_Keymap * handler, wmKeyMap * keymap, const bool do_debug_handler) Lines 2451	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Lines 2748	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Lines 2872	C
wm_event_do_handlers(bContext * C) Lines 3368	C
WM_main(bContext * C) Lines 638	C
main(int argc, const unsigned char * * UNUSED_argv_c) Lines 526	C

I can confirm this crash in 2.90.1, 2.91 and 2.92. The versions 2.83.x are not affected. The object `ob` is `NULL` which causes a crash when attempting to use ``` SculptSession *ss = ob->sculpt; ``` Stack trace from current master branch `e09d0c0d077cff79b55ce32ec5124d5faa73e2e7`: ```lines createTransSculpt(bContext * C, TransInfo * t) Lines 53 C createTransData(bContext * C, TransInfo * t) Lines 1241 C initTransform(bContext * C, TransInfo * t, wmOperator * op, const wmEvent * event, int mode) Lines 1756 C transformops_data(bContext * C, wmOperator * op, const wmEvent * event) Lines 394 C transform_invoke(bContext * C, wmOperator * op, const wmEvent * event) Lines 510 C wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Lines 1296 C wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties, const unsigned char * kmi_idname) Lines 2141 C wm_handlers_do_keymap_with_keymap_handler(bContext * C, wmEvent * event, ListBase * handlers, wmEventHandler_Keymap * handler, wmKeyMap * keymap, const bool do_debug_handler) Lines 2451 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Lines 2748 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Lines 2872 C wm_event_do_handlers(bContext * C) Lines 3368 C WM_main(bContext * C) Lines 638 C main(int argc, const unsigned char * * UNUSED_argv_c) Lines 526 C ```

Robert Guetzkow changed title from ~~Crash when i hide an object in sculpt mode and use the Annotation tool~~ to Crash when using annotation tool on object hidden in sculpt mode

2020-11-26 00:44:14 +01:00

Fabrício Luis commented

2020-11-26 21:40:09 +01:00

Added subscriber: @ce3po

Greg Neumiller commented

2020-12-11 01:03:26 +01:00

Added subscriber: @rlneumiller

Greg Neumiller commented

2020-12-11 01:03:26 +01:00

The following fixes the issue to the extent that it behaves as it does in 2.83.10.
With 2.83.10, when attempting to reproduce this issue, rather than crashing, Annotate has no effect until you exit sculpt mode.

I would consider this to be more of a workaround than a proper fix.

diff --git a/source/blender/editors/transform/transform_convert_sculpt.c b/source/blender/editors/transform/transform_convert_sculpt.c
index 0ac6bd9264f..7a60d05d86c 100644
--- a/source/blender/editors/transform/transform_convert_sculpt.c
+++ b/source/blender/editors/transform/transform_convert_sculpt.c
@@ -50,7 +50,10 @@ void createTransSculpt(bContext *C, TransInfo *t)
   }

   Object *ob = CTX_data_active_object(t->context);
+  if (!ob)
+    return;
   SculptSession *ss = ob->sculpt;
+

   {
     BLI_assert(t->data_container_len == 1);

The following fixes the issue to the extent that it behaves as it does in 2.83.10. With 2.83.10, when attempting to reproduce this issue, rather than crashing, Annotate has no effect until you exit sculpt mode. I would consider this to be more of a workaround than a proper fix. ``` diff --git a/source/blender/editors/transform/transform_convert_sculpt.c b/source/blender/editors/transform/transform_convert_sculpt.c index 0ac6bd9264f..7a60d05d86c 100644 --- a/source/blender/editors/transform/transform_convert_sculpt.c +++ b/source/blender/editors/transform/transform_convert_sculpt.c @@ -50,7 +50,10 @@ void createTransSculpt(bContext *C, TransInfo *t) } Object *ob = CTX_data_active_object(t->context); + if (!ob) + return; SculptSession *ss = ob->sculpt; + { BLI_assert(t->data_container_len == 1); ```

Greg Neumiller commented

2020-12-11 01:58:30 +01:00

Also reproduces with the measure tool.

Pablo Dobarro commented

2021-01-28 17:49:42 +01:00

Added subscribers: @ideasman42, @PabloDobarro

Pablo Dobarro commented

2021-01-28 17:49:42 +01:00

@ideasman42 This is crashing because when hiding the object, the UI switches to Object mode and the SculptSession is freed, but the object keeps being in Sculpt Mode. Any operation that checks the active mode of that object will behave in an unexpected way. What is the reason for doing this when changing the visibility?
If this is related to not supporting multi object editing in paint modes, I think it makes more sense to prevent the visibility of the active object from being changed.
Also, this is also no consistent with other visibility changes. If you hide the object directy, it goes from Sculpt Mode to Object Mode, but it you hide the collection that contains that object, it stays in Sculpt Mode.

@ideasman42 This is crashing because when hiding the object, the UI switches to Object mode and the SculptSession is freed, but the object keeps being in Sculpt Mode. Any operation that checks the active mode of that object will behave in an unexpected way. What is the reason for doing this when changing the visibility? If this is related to not supporting multi object editing in paint modes, I think it makes more sense to prevent the visibility of the active object from being changed. Also, this is also no consistent with other visibility changes. If you hide the object directy, it goes from Sculpt Mode to Object Mode, but it you hide the collection that contains that object, it stays in Sculpt Mode.

Campbell Barton commented

2021-02-11 01:42:44 +01:00

@PabloDobarro agree this is not consistent / useful behavior.

As far as I know this was not intentionally designed this way it's just the result of the contexts active_object returning NULL when an object is hidden in the 3D view.

I've created as design task to address this #85532 (Proposal to change behavior when the active object is hidden)

For 2.92 I'll check on a short term fix.

@PabloDobarro agree this is not consistent / useful behavior. As far as I know this was not intentionally designed this way it's just the result of the contexts `active_object` returning NULL when an object is hidden in the 3D view. I've created as design task to address this #85532 (Proposal to change behavior when the active object is hidden) ----- For 2.92 I'll check on a short term fix.

blender-admin commented

2021-02-11 02:34:41 +01:00

This issue was referenced by 52cfc620c8

This issue was referenced by 52cfc620c8cc3125282d8dd66df312ffb576569c

Campbell Barton commented

2021-02-11 02:40:04 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2021-02-11 02:40:04 +01:00

Campbell Barton self-assigned this 2021-02-11 02:40:04 +01:00

Thomas Dinges added this to the 2.92 milestone 2023-02-08 16:15:38 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when using annotation tool on object hidden in sculpt mode #83013