Wrong width returned from bpy.types.Window.width (depending on native pixel size) #84204

New Issue

nutti · 2020-12-28T10:20:40+01:00

nutti commented

2020-12-28 10:20:40 +01:00

System Information

OS: macOS Mojave (10.14.6)
Graphic card: Radeon Pro 450 2GB

Blender Version

Broken version: 2.91.0

Description of error

bpy.types.Window.width does not return correct value in my environment.

I tried to get window size of Blender via bpy.context.window_manager.windows- [x].width.
But the returned value differs from the actual window width (Actual window width: 2880, Returned value: 1680).
Also, I found that bpy.context.window_manager.windows- [x].x also returned invalid value.

Other related values such as region.width, area.width seems fine in my environment.

**System Information** OS: macOS Mojave (10.14.6) Graphic card: Radeon Pro 450 2GB **Blender Version** Broken version: 2.91.0 **Description of error** bpy.types.Window.width does not return correct value in my environment. I tried to get window size of Blender via bpy.context.window_manager.windows- [x].width. But the returned value differs from the actual window width (Actual window width: 2880, Returned value: 1680). Also, I found that bpy.context.window_manager.windows- [x].x also returned invalid value. Other related values such as region.width, area.width seems fine in my environment.

nutti commented

2020-12-28 10:20:40 +01:00

Added subscriber: @nutti

Yevgeny Makarov commented

2020-12-28 13:26:43 +01:00

Added subscriber: @jenkm

Yevgeny Makarov commented

2020-12-28 13:26:43 +01:00

For me, it returns 1680 and the real width is 3360, which can be called a correct value since there are twice as many pixels on the Retina.
But the issue is that you can't know if it's Retina or regular screen, in the Python I mean. In C it's GHOST_GetNativePixelSize() and the value is corrected when it is necessary.

For me, it returns `1680` and the real width is `3360`, which can be called a correct value since there are twice as many pixels on the Retina. But the issue is that you can't know if it's Retina or regular screen, in the Python I mean. In C it's `GHOST_GetNativePixelSize()` and the value is corrected when it is necessary.

nutti commented

2020-12-29 00:31:47 +01:00

Thanks @jenkm !

But the issue is that you can't know if it's Retina or regular screen, in the Python I mean.

Yes, that's right. Is there any way to correct those values from Python?
I think that GHOST_GetNativePixelSize does not expose API to Python.

Thanks @jenkm ! > But the issue is that you can't know if it's Retina or regular screen, in the Python I mean. Yes, that's right. Is there any way to correct those values from Python? I think that `GHOST_GetNativePixelSize` does not expose API to Python.

Philipp Oeser commented

2020-12-29 17:28:52 +01:00

Added subscribers: @JulianEisel, @lichtwerk

Philipp Oeser commented

2020-12-29 17:28:52 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2020-12-29 17:28:52 +01:00

A bit on shaky ground [also cannot test here], but couldnt get native pixel size be considered when getting this through RNA?
With a function defined through RNA_def_property_int_funcs?

CC @JulianEisel

A bit on shaky ground [also cannot test here], but couldnt get native pixel size be considered when getting this through RNA? With a function defined through `RNA_def_property_int_funcs`? CC @JulianEisel

Philipp Oeser changed title from ~~Wrong width returned from bpy.types.Window.width~~ to Wrong width returned from bpy.types.Window.width (depending on native pixel size)

2020-12-29 17:29:09 +01:00

Julian Eisel commented

2020-12-29 19:55:58 +01:00

Changing the property to respect the native pixel size would be an API compatibility breaking change, I don't think we should do this. We could expose the native pixel size, or give functions to convert dimensions and coordinates from and to real pixel values.

Either way, the property description should state if it's not in real pixels and if the pixel size needs to be multiplied.

Changing the property to respect the native pixel size would be an API compatibility breaking change, I don't think we should do this. We could expose the native pixel size, or give functions to convert dimensions and coordinates from and to real pixel values. Either way, the property description should state if it's not in real pixels and if the pixel size needs to be multiplied.

Yevgeny Makarov commented

2021-01-02 11:37:54 +01:00

Not sure we can break what's already broken. We could expose the native_pixel_size but I don't see the point, you need to always multiply/divide by it. The cursor coordinates are already multiplied by it, you can have two monitors with different dpi, and so on.

Moreover this is not an API issue. These native window sizes in virtual pixels are only needed when creating a window in GHOST/Cocoa. There are already many problems/inconveniences with the need for this conversion. Some recent ones I've encountered: D9837 D9976 D9836.

There is also the issue that we have the cursor coordinates in two-pixel increments on the Retina. And when I tried to fix this the first thing I came across was exactly these window sizes not matching the cursor coordinate.

Not sure we can break what's already broken. We could expose the native_pixel_size but I don't see the point, you need to **always** multiply/divide by it. The cursor coordinates are already multiplied by it, you can have two monitors with different dpi, and so on. Moreover this is not an API issue. These native window sizes in virtual pixels are only needed when creating a window in GHOST/Cocoa. There are already many problems/inconveniences with the need for this conversion. Some recent ones I've encountered: [D9837](https://archive.blender.org/developer/D9837) [D9976](https://archive.blender.org/developer/D9976) [D9836](https://archive.blender.org/developer/D9836). There is also the issue that we have the cursor coordinates in two-pixel increments on the Retina. And when I tried to fix this the first thing I came across was exactly these window sizes not matching the cursor coordinate.

Yevgeny Makarov commented

2021-04-05 09:13:47 +02:00

Another example. In WM_window_open(), we use native_pixel_size to correct the window size. But we pass different values to this function. In case of area_dupli it's the "area" size, and it's works correctly. But for window_new it's "win" size which does not need to be adjusted, so we have a new window half as small as it should be.

Another example. In `WM_window_open()`, we use `native_pixel_size` to correct the window size. But we pass different values to this function. In case of `area_dupli` it's the "area" size, and it's works correctly. But for `window_new` it's "win" size which does not need to be adjusted, so we have a new window half as small as it should be.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Wrong width returned from bpy.types.Window.width (depending on native pixel size) #84204