Crash when having a scene strip in VSE that references a scene that has been deleted #84529

New Issue

Sebastian Koenig · 2021-01-08T18:06:18+01:00

Sebastian Koenig commented

2021-01-08 18:06:18 +01:00

System Information
Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.38

Blender Version
Broken: version:

2.92.0 Alpha, branch: master, commit date: 2021-01-08 06:24, hash: f448ff2afe
2.92.0 Alpha, branch: master, commit date: 2020-12-15 23:20, hash: 977bd7937a
Issue was introduced in commit fad80a95fd
Worked:
2.92.0 Alpha, branch: master, commit date: 2020-12-14 15:44, hash: 010f44b855
2.91.0

Short description of error
The VSE crashes if it contains a strip that references a scene that already has been deleted.

Exact steps for others to reproduce the error
Open this file and try to switch to the video editing workspace.

vse_crash.blend

Alternatively:

Create a new scene and switch to it.
Open the Video Editing workspace.
Add the original scene Add > Scene > Scene.
Switch back to the original scene and delete it.

vsnprintf(unsigned char * const _Buffer, const unsigned __int64 _BufferCount, const unsigned char * const _Format, unsigned char * _ArgList) Line 1440	C
BLI_vsnprintf(unsigned char * buffer, unsigned __int64 maxncpy, const unsigned char * format, unsigned char * arg) Line 221	C
BLI_snprintf(unsigned char * dst, unsigned __int64 maxncpy, const unsigned char * format, ...) Line 273	C
draw_seq_text_get_source(Sequence * seq, unsigned char * r_source, unsigned __int64 source_len) Line 653	C
draw_seq_text_get_overlay_string(SpaceSeq * sseq, Sequence * seq, unsigned char * r_overlay_string, unsigned __int64 overlay_string_len) Line 675	C
draw_seq_text_overlay(View2D * v2d, Sequence * seq, SpaceSeq * sseq, float x1, float x2, float y1, float y2, bool seq_active) Line 710	C
draw_seq_strip(const bContext * C, SpaceSeq * sseq, Scene * scene, ARegion * region, Sequence * seq, float pixelx, bool seq_active) Line 1191	C
draw_seq_strips(const bContext * C, Editing * ed, ARegion * region) Line 1969	C
draw_timeline_seq(const bContext * C, ARegion * region) Line 2340	C
sequencer_main_region_draw(const bContext * C, ARegion * region) Line 529	C
ED_region_do_draw(bContext * C, ARegion * region) Line 551	C
wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 732	C
wm_draw_window(bContext * C, wmWindow * win) Line 875	C
wm_draw_update(bContext * C) Line 1074	C
WM_main(bContext * C) Line 642	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 526	C

**System Information** Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 455.38 **Blender Version** Broken: version: - 2.92.0 Alpha, branch: master, commit date: 2021-01-08 06:24, hash: `f448ff2afe` - 2.92.0 Alpha, branch: master, commit date: 2020-12-15 23:20, hash: `977bd7937a` - Issue was introduced in commit fad80a95fd Worked: - 2.92.0 Alpha, branch: master, commit date: 2020-12-14 15:44, hash: `010f44b855` - 2.91.0 **Short description of error** The VSE crashes if it contains a strip that references a scene that already has been deleted. **Exact steps for others to reproduce the error** Open this file and try to switch to the video editing workspace. [vse_crash.blend](https://archive.blender.org/developer/F9555976/vse_crash.blend) Alternatively: - Create a new scene and switch to it. - Open the *Video Editing* workspace. - Add the original scene *Add > Scene > Scene*. - Switch back to the original scene and delete it. ```lines vsnprintf(unsigned char * const _Buffer, const unsigned __int64 _BufferCount, const unsigned char * const _Format, unsigned char * _ArgList) Line 1440 C BLI_vsnprintf(unsigned char * buffer, unsigned __int64 maxncpy, const unsigned char * format, unsigned char * arg) Line 221 C BLI_snprintf(unsigned char * dst, unsigned __int64 maxncpy, const unsigned char * format, ...) Line 273 C draw_seq_text_get_source(Sequence * seq, unsigned char * r_source, unsigned __int64 source_len) Line 653 C draw_seq_text_get_overlay_string(SpaceSeq * sseq, Sequence * seq, unsigned char * r_overlay_string, unsigned __int64 overlay_string_len) Line 675 C draw_seq_text_overlay(View2D * v2d, Sequence * seq, SpaceSeq * sseq, float x1, float x2, float y1, float y2, bool seq_active) Line 710 C draw_seq_strip(const bContext * C, SpaceSeq * sseq, Scene * scene, ARegion * region, Sequence * seq, float pixelx, bool seq_active) Line 1191 C draw_seq_strips(const bContext * C, Editing * ed, ARegion * region) Line 1969 C draw_timeline_seq(const bContext * C, ARegion * region) Line 2340 C sequencer_main_region_draw(const bContext * C, ARegion * region) Line 529 C ED_region_do_draw(bContext * C, ARegion * region) Line 551 C wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 732 C wm_draw_window(bContext * C, wmWindow * win) Line 875 C wm_draw_update(bContext * C) Line 1074 C WM_main(bContext * C) Line 642 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 526 C ```

Sebastian Koenig commented

2021-01-08 18:06:18 +01:00

Added subscriber: @sebastian_k