Resolve inconsistency of sequencer import setting in header #84535

New Issue

Hans Goudey · 2021-01-08T19:02:59+01:00

Hans Goudey commented

2021-01-08 19:02:59 +01:00

After D9582, there is an import setting exposed in the header of the sequence editor.
This is inconsistent with the way we normally expose import settings elsewhere in the UI,
and feels broken on the user level because the setting doesn't do anything visible when it's changed.
Its placement makes it look like it would change the settings for the selected strips.

This would have been the feedback from the UI module if it was involved in the process at the time.

In general, operator properties should not be exposed in situations like this, otherwise
the interface would be full of buttons that don't do anything immediately, making it much
more difficult to figure out relationships between different areas of the UI.

The setting is already exposed in the "Adjust Last Operation" panel. This is where similar properties
are exposed elsewhere in Blender. The file browser has no sidebar in the sequencer workspace,
which is probably why the option was exposed here in the first place.

With a more purposeful design (P1873), the importance of this property can be expressed more clearly:

Another option is moving this to the sidebar, though this might require some refactoring
to make it a real "setting" property rather than an operator property.

After [D9582](https://archive.blender.org/developer/D9582), there is an import setting exposed in the header of the sequence editor. This is inconsistent with the way we normally expose import settings elsewhere in the UI, and feels broken on the user level because the setting doesn't do anything visible when it's changed. Its placement makes it look like it would change the settings for the selected strips. This would have been the feedback from the UI module if it was involved in the process at the time. ![image.png](https://archive.blender.org/developer/F9555993/image.png) In general, operator properties should **not** be exposed in situations like this, otherwise the interface would be full of buttons that don't do anything immediately, making it much more difficult to figure out relationships between different areas of the UI. The setting is already exposed in the "Adjust Last Operation" panel. This is where similar properties are exposed elsewhere in Blender. The file browser has no sidebar in the sequencer workspace, which is probably why the option was exposed here in the first place. ![image.png](https://archive.blender.org/developer/F9556029/image.png) With a more purposeful design ([P1873](https://archive.blender.org/developer/P1873.txt)), the importance of this property can be expressed more clearly: ![image.png](https://archive.blender.org/developer/F9556027/image.png) Another option is moving this to the sidebar, though this might require some refactoring to make it a real "setting" property rather than an operator property. ![image.png](https://archive.blender.org/developer/F9556043/image.png)

Hans Goudey commented

2021-01-08 19:02:59 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2021-01-08 19:02:59 +01:00

Added subscribers: @HooglyBoogly, @tintwotin, @pablovazquez, @fsiddi, @iss, @JulianEisel

Francesco Siddi commented

2021-01-09 01:04:20 +01:00

I agree with your remarks. While the proposed (and implemented) design featured such settings I already raised a concern in https://developer.blender.org/D9582#245994.
The original proposal comes from me, so I take the responsibility for it. I suggest to simply hide the dropdown from the header, and leave it as an operator setting.

Your last suggestion (to make it a "setting" property in the sidebar) would also lead to a mixed experience, since it would cause an operator to run when changing the value of an enum.
We can discuss this further live, but I'm fine with simply removing the dropdown. CCing @iss as he authored the code.

I agree with your remarks. While the proposed (and implemented) design featured such settings I already raised a concern in https://developer.blender.org/D9582#245994. The original proposal comes from me, so I take the responsibility for it. I suggest to simply hide the dropdown from the header, and leave it as an operator setting. Your last suggestion (to make it a "setting" property in the sidebar) would also lead to a mixed experience, since it would cause an operator to run when changing the value of an enum. We can discuss this further live, but I'm fine with simply removing the dropdown. CCing @iss as he authored the code.

blender-admin commented

2021-01-10 16:37:18 +01:00

This issue was referenced by 9441413cb2

This issue was referenced by 9441413cb242f549ba1f86621ff72e90418313df

Julian Eisel commented

2021-01-14 15:29:41 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2021-01-14 15:29:41 +01:00

Julian Eisel self-assigned this 2021-01-14 15:29:41 +01:00

Thomas Dinges added this to the 2.92 milestone 2023-02-08 16:15:35 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Resolve inconsistency of sequencer import setting in header #84535