Wrong icon for Movie Clip Editor #84707

New Issue

Sergey Sharybin · 2021-01-14T12:31:36+01:00

Sergey Sharybin commented

2021-01-14 12:31:36 +01:00

System Information
Operating system: Linux-5.10.0-1-amd64-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.27.04

Blender Version
Broken: version: 2.92.0 Beta, branch: master, commit date: 2021-01-13 23:55, hash: 5804bf25bd
Worked: 2.79, all local builds (all the way up to the latest master)

Short description of error

Movie clip editor is using wrong icon in the space menu.

Exact steps for others to reproduce the error

Download Blender from buildbot
Open space menu
Observe icon of the clip editor (it is supposed to be shot clicky thing, not a crosshair)

It is caused by multiple .dat files in the icons folder defining image for the clip editor's icon. The files are traversed in an undefined order (since readdir does not perform any sorting), this is why buildbot behaves different from local builds.

The check against icons conflicts was implemented in D9715, but the check can not go in since it will break builds, because icons are already in an inconsistent state.

Rebuilding icons also turns out to be not so trivial, as there seems to be inconsistency between icons defined in the UI_icons.h header and editors/datafiles/CMakeLists.txt files.

**System Information** Operating system: Linux-5.10.0-1-amd64-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.27.04 **Blender Version** Broken: version: 2.92.0 Beta, branch: master, commit date: 2021-01-13 23:55, hash: `5804bf25bd` Worked: 2.79, all local builds (all the way up to the latest master) **Short description of error** Movie clip editor is using wrong icon in the space menu. **Exact steps for others to reproduce the error** - Download Blender from buildbot - Open space menu - Observe icon of the clip editor (it is supposed to be shot clicky thing, not a crosshair) It is caused by multiple .dat files in the icons folder defining image for the clip editor's icon. The files are traversed in an undefined order (since `readdir` does not perform any sorting), this is why buildbot behaves different from local builds. The check against icons conflicts was implemented in [D9715](https://archive.blender.org/developer/D9715), but the check can not go in since it will break builds, because icons are already in an inconsistent state. Rebuilding icons also turns out to be not so trivial, as there seems to be inconsistency between icons defined in the `UI_icons.h` header and `editors/datafiles/CMakeLists.txt` files.

Sergey Sharybin commented

2021-01-14 12:31:36 +01:00

Added subscriber: @Sergey

Philipp Oeser commented

2021-01-19 17:42:11 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Julian Eisel commented

2021-01-25 11:27:18 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2021-01-25 11:27:18 +01:00

Could be considered a todo since it's an issue in the resource files more than a code issue. But since there are differences in platforms, I'll mark this as actual bug.

Sergey Sharybin commented

2021-02-15 12:50:01 +01:00

Is there any progress here? Not sure why such a simple-sounding task takes months to be addressed (it was verbally communicated before D9715).

Is there any progress here? Not sure why such a simple-sounding task takes months to be addressed (it was verbally communicated before [D9715](https://archive.blender.org/developer/D9715)).

Julian Eisel commented

2021-02-15 19:27:20 +01:00

It's not entirely clear to me what needs to be done. So there are two overlapping icons in a cell in the SVG? Plus, the icon enum is out of sync with the SVG?

I also couldn't run the icon update script for a while until c549d736cf, not sure if that's related to what Dalai reported.

It's not entirely clear to me what needs to be done. So there are two overlapping icons in a cell in the SVG? Plus, the icon enum is out of sync with the SVG? I also couldn't run the icon update script for a while until c549d736cff0, not sure if that's related to what Dalai reported.

Sergey Sharybin commented

2021-02-16 09:47:39 +01:00

If something is not clear is the best to ask for clarification, than to wait for, not sure what ;)

In practical terms what I see needs to be done is to remove all existing .dat files from blender_icons{16,32}, regenerate the new ones using make icons. This will ensure that the generated .dat files are in perfect sync with what Blender expects, solving the conflicting .dat files.

The steps above will work, however, when you'll attempt to do a fresh build you'll see something like this:

make[2]: *** No rule to make target '/home/sergey/Developer/blender/blender/release/datafiles/blender_icons16/icon16_clip.dat', needed by 'release/datafiles/blender_icons16.png'.  Stop.

So while it all sounds simple, the issue goes deeper into some fragility of the way how things are set up.

If something is not clear is the best to ask for clarification, than to wait for, not sure what ;) In practical terms what I see needs to be done is to remove all existing `.dat` files from `blender_icons{16,32}`, regenerate the new ones using `make icons`. This will ensure that the generated `.dat` files are in perfect sync with what Blender expects, solving the conflicting `.dat` files. The steps above will work, however, when you'll attempt to do a fresh build you'll see something like this: ``` make[2]: *** No rule to make target '/home/sergey/Developer/blender/blender/release/datafiles/blender_icons16/icon16_clip.dat', needed by 'release/datafiles/blender_icons16.png'. Stop. ``` So while it all sounds simple, the issue goes deeper into some fragility of the way how things are set up.

blender-admin commented

2021-02-23 11:37:12 +01:00

This issue was referenced by 420f538fad

This issue was referenced by 420f538fadfdd7f9713db9aea44cd7829cbc2ef4

Julian Eisel commented

2021-02-23 12:13:51 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2021-02-23 12:13:51 +01:00

Julian Eisel self-assigned this 2021-02-23 12:13:51 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Wrong icon for Movie Clip Editor #84707