Create a string input node #84971

New Issue

Love the idea. With a string input node, later on it could be complimented by a node that takes a string input and font selection then generates a mesh. Then later on after that, string nodes that take a string input, and perform manipulations, and output the result as a string output.

Simon Thommes commented

2021-01-25 10:34:26 +01:00

For now this node is simply a necessity for the attribute workflow, as the attribute input socket accepts a string as the name of the attribute.

In #84971#1099079, @Blendify wrote:
Alternatively, this can be added to the input value node? Were we can input multiple value types such as boolean int string float.

Having a combined Input node regardless of the type is not a bad idea. For now this is simply following the design we generally have in Blender with e.g. shading nodes. But I can see this possibly changing once we have a broader range of different input types.

For now this node is simply a necessity for the attribute workflow, as the attribute input socket accepts a string as the name of the attribute. > In #84971#1099079, @Blendify wrote: > Alternatively, this can be added to the input value node? Were we can input multiple value types such as boolean int string float. Having a combined `Input` node regardless of the type is not a bad idea. For now this is simply following the design we generally have in Blender with e.g. shading nodes. But I can see this possibly changing once we have a broader range of different input types.

Jishan Singh commented

2021-01-25 16:14:07 +01:00

Added subscriber: @ringmaker

Jishan Singh commented

2021-01-25 16:14:07 +01:00

This comment was removed by @ringmaker

*This comment was removed by @ringmaker*

Edgar Roman Cervantes commented

2021-02-03 05:12:08 +01:00

Added subscriber: @redvant

Edgar Roman Cervantes commented

2021-02-03 05:12:08 +01:00

Hi! Can I work on this?

Hans Goudey commented

2021-02-03 05:24:27 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-02-03 05:24:27 +01:00

Of course, that's why it's a "Good First Issue".

Edgar Roman Cervantes commented

2021-02-03 06:20:38 +01:00

Great!! I already did some digging and I was wondering if the string node should be a Geometry node or instead a Function node (like the vector node) or a Shading node (like the value node).

Hans Goudey commented

2021-02-03 06:25:18 +01:00

Since it's general (could theoretically be used in any node tree), implementing it as a function node would be preferred, just like the vector input node.

Edgar Roman Cervantes commented

2021-02-03 06:34:38 +01:00

I'm on it. Thanks!

Edgar Roman Cervantes commented

2021-02-04 00:41:04 +01:00

Hi guys!! I have it working now.

I wanted to ask you if is OK this new DNA struct to store the string property:

typedef struct NodeInputString {
  char string[1024];
} NodeInputString;

I saw the bNodeSocketValueString use char value[1024] but I think is Deprecated.

Hi guys!! I have it working now. ![stringNode_screenshot_01.png](https://archive.blender.org/developer/F9611528/stringNode_screenshot_01.png) I wanted to ask you if is OK this new DNA struct to store the string property: ``` typedef struct NodeInputString { char string[1024]; } NodeInputString; ``` I saw the `bNodeSocketValueString` use `char value[1024]` but I think is Deprecated.

Hans Goudey commented

2021-02-04 00:54:28 +01:00

Nice!

Right, just like the NodeInputVector node. bNodeSocketValueString isn't deprecated, it's just used for sockets, and since this string isn't a socket but a node property, it can't be used here.

Nice! Right, just like the `NodeInputVector` node. `bNodeSocketValueString` isn't deprecated, it's just used for sockets, and since this string isn't a socket but a node property, it can't be used here.

Edgar Roman Cervantes commented

2021-02-04 01:06:38 +01:00

Ok then.
I'll double check everything and I'll consult the developer intro on Best Practices and all that.
Thanks!

Ok then. I'll double check everything and I'll consult the developer intro on Best Practices and all that. Thanks!

Edgar Roman Cervantes self-assigned this 2021-02-04 03:59:24 +01:00

Some User commented

2021-02-04 12:42:24 +01:00

Added subscriber: @someuser

Some User commented

2021-02-04 12:42:24 +01:00

char string[1024];

but in this case, unicode characters are not supported. and we can't use this node as input for creating text mesh object 😢

P.S. also in houdini for example, text input filed also used in some nodes to create points/edges/faces/etc, from they text representation of array coordinates/id/etc, i mean lenght of 1024 maybe to short?

> char string[1024]; but in this case, unicode characters are not supported. and we can't use this node as input for creating text mesh object 😢 P.S. also in houdini for example, text input filed also used in some nodes to create points/edges/faces/etc, from they text representation of array coordinates/id/etc, i mean lenght of 1024 maybe to short?

Kenzie commented

2021-02-04 13:42:20 +01:00

Added subscriber: @KenzieMac130

Kenzie commented

2021-02-04 13:42:20 +01:00

In #84971#1106938, @someuser wrote:

char string[1024];

but in this case, unicode characters are not supported. and we can't use this node as input for creating text mesh object 😢

P.S. also in other software, text input filed also used in some nodes to create points/edges/faces/etc, from they text representation of array coordinates/id/etc, i mean lenght of 1024 maybe to short?

Utf8 should be supported by char arrays. 1024 does seem limiting if users would want to populate from coordinates, but it feels like if that's what you want to do then you should be using a text data block or some other solution that allows users to import data from heavy sources (CSVs, custom import formats, etc). Maybe a string size limit might be a problem in real production eventually though when generating text meshes like you said. But I think as an initial implementation 1024 should be fine for attribute name inputs.

> In #84971#1106938, @someuser wrote: >> char string[1024]; > > but in this case, unicode characters are not supported. and we can't use this node as input for creating text mesh object 😢 > > P.S. also in other software, text input filed also used in some nodes to create points/edges/faces/etc, from they text representation of array coordinates/id/etc, i mean lenght of 1024 maybe to short? Utf8 should be supported by char arrays. 1024 does seem limiting if users would want to populate from coordinates, but it feels like if that's what you want to do then you should be using a text data block or some other solution that allows users to import data from heavy sources (CSVs, custom import formats, etc). Maybe a string size limit might be a problem in real production eventually though when generating text meshes like you said. But I think as an initial implementation 1024 should be fine for attribute name inputs.

Edgar Roman Cervantes commented

2021-02-05 04:06:13 +01:00

Here it is!
Let me know of anything that needs a fix or improvement.

Here it is! Let me know of anything that needs a fix or improvement.

blender-admin commented

2021-02-19 23:03:14 +01:00

This issue was referenced by a961a2189c

This issue was referenced by a961a2189cb38ffb368d6781aa57177bfefe0e36

Dalai Felinto commented

2021-02-22 15:02:03 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Dalai Felinto closed this issue

2021-02-22 15:02:03 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Create a string input node #84971