Baking animation on 2s ( Frame Step = 2) and with 'Overwrite Current Action' enabled, still keeps old keyframes inbetween steps. #85050

New Issue

Rik Schutte · 2021-01-25T17:42:50+01:00

Rik Schutte commented

2021-01-25 17:42:50 +01:00

System Information
Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: AMD Radeon RX 5700 XT (NAVI10, DRM 3.38.0, 5.8.0-7630-generic, LLVM 11.0.0) X.Org 4.6 (Core Profile) Mesa 20.2.1

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-01-18 14:02, hash: 023ebb890b
Worked: (newest version of Blender that worked as expected)

Short description of error
Baking animation on 2s ( Frame Step = 2) and with 'Overwrite Current Action' enabled, still keeps old keyframes inbetween steps. I would expect these 'inbetween' keys to be overridden as well as it should be part of the baking process.

EDIT:
It would be great to have an option in the 'bake action' that will delete keys that are not on the stepped keyframes. This way the 'baking on 2s' will be absolutely on 2s, and not have some leftover keys that will still move the character inbetween 2 baked keys.

It would be great if 'baking actions' are respecting the preferences on which interpolation mode it is set. Let's say I set it to 'constant'. then baking action should output 'constant' keys instead of bezier keys.

As discussed in the meeting with Sybren, Hjalti, Rik and Sebastian. being able to determine the keys to be baked on frames based on keys of an arbitrary object gives us the freedom to be selective on which frames should be baked and which frames should be held. Let's say want my frames to be baked on frame 2, 4, 6, 7, 8, where frame 7 is an extra key (based on the 2s retoric). By having an object (cube, bone, etc) that has already keys on the designated frames 2, 4, 6, 7, 8. This object could dictate the frames that needs key baking.

Exact steps for others to reproduce the error

#85050-cube_anim_test_baking_on_2s_v1.blend

Open the above blend file
Go to Pose -> Animation -> Bake Action
Set Frame Step to '2'
Check 'Overwrite Current Action'
Bake Data: Pose
Click 'OK'

After baking, I still see existing keys on frames inbetween the 2 steo even though 'Overwrite Current Action' is turned on.

**System Information** Operating system: Linux-5.8.0-7630-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: AMD Radeon RX 5700 XT (NAVI10, DRM 3.38.0, 5.8.0-7630-generic, LLVM 11.0.0) X.Org 4.6 (Core Profile) Mesa 20.2.1 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-01-18 14:02, hash: `023ebb890b` Worked: (newest version of Blender that worked as expected) **Short description of error** Baking animation on 2s ( Frame Step = 2) and with 'Overwrite Current Action' enabled, still keeps old keyframes inbetween steps. I would expect these 'inbetween' keys to be overridden as well as it should be part of the baking process. EDIT: It would be great to have an option in the 'bake action' that will delete keys that are not on the stepped keyframes. This way the 'baking on 2s' will be absolutely on 2s, and not have some leftover keys that will still move the character inbetween 2 baked keys. It would be great if 'baking actions' are respecting the preferences on which interpolation mode it is set. Let's say I set it to 'constant'. then baking action should output 'constant' keys instead of bezier keys. As discussed in the meeting with Sybren, Hjalti, Rik and Sebastian. being able to determine the keys to be baked on frames based on keys of an arbitrary object gives us the freedom to be selective on which frames should be baked and which frames should be held. Let's say want my frames to be baked on frame 2, 4, 6, 7, 8, where frame 7 is an extra key (based on the 2s retoric). By having an object (cube, bone, etc) that has already keys on the designated frames 2, 4, 6, 7, 8. This object could dictate the frames that needs key baking. **Exact steps for others to reproduce the error** [#85050-cube_anim_test_baking_on_2s_v1.blend](https://archive.blender.org/developer/F9598653/T85050-cube_anim_test_baking_on_2s_v1.blend) - Open the above blend file - Go to Pose -> Animation -> Bake Action - Set Frame Step to '2' - Check 'Overwrite Current Action' - Bake Data: Pose - Click 'OK' After baking, I still see existing keys on frames inbetween the 2 steo even though 'Overwrite Current Action' is turned on.

Rik Schutte commented

2021-01-25 17:42:50 +01:00

Added subscriber: @Rikstopher

Rik Schutte commented

2021-01-26 11:24:40 +01:00

cube_anim_test_baking_on_2s_v1.blend

Here, I uploaded an example file with a simple cube and bone animation.
The armature contains 2 actions:

animation on 1s
animation baked on 2s ( baked with frame step set on 2, and 'Override current action' enabled)

The result of the baked animation, it still contains it's previous keys inbetween the 2-step keyframes.

[cube_anim_test_baking_on_2s_v1.blend](https://archive.blender.org/developer/F9598468/cube_anim_test_baking_on_2s_v1.blend) Here, I uploaded an example file with a simple cube and bone animation. The armature contains 2 actions: - animation on 1s - animation baked on 2s ( baked with frame step set on 2, and 'Override current action' enabled) The result of the baked animation, it still contains it's previous keys inbetween the 2-step keyframes. ```

Sybren A. Stüvel commented

2021-01-26 14:18:39 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2021-01-26 14:18:39 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2021-01-26 14:18:39 +01:00

This is working as designed. It's overwriting the existing keys with new keys, but otherwise leaving the existing Action alone.

The "Overwrite Current Action" option could be made to erase the keys in the affected FCurves in the bake frame range first. That's a new feature, though. I think it would be nice as a sub-task task of #82168 (Improvements to "Bake Action..." Operator).

This is working as designed. It's overwriting the existing keys with new keys, but otherwise leaving the existing Action alone. The "Overwrite Current Action" option could be made to erase the keys in the affected FCurves in the bake frame range first. That's a new feature, though. I think it would be nice as a sub-task task of #82168 (Improvements to "Bake Action..." Operator).

Brad Clark commented

2021-01-26 16:16:10 +01:00

Added subscriber: @BClark

Brad Clark commented

2021-01-26 16:16:10 +01:00

Hi,
Overwrite implies replace though doesn't it? It isn't call merge to current action. Is that documented that that is what it does currently somewhere? That wasn't clear to me that it was doing this.

Hi, Overwrite implies replace though doesn't it? It isn't call merge to current action. Is that documented that that is what it does currently somewhere? That wasn't clear to me that it was doing this.

Wayde Moss self-assigned this 2021-02-11 01:38:46 +01:00

Sybren A. Stüvel commented

2021-02-11 18:24:15 +01:00

In #85050#1101167, @BClark wrote:
Overwrite implies replace though doesn't it?

Yes, and currently it replaces existing keys on the current action. This is of course different from replacing an entire time interval, which is what Wayde made D10392 for.

> In #85050#1101167, @BClark wrote: > Overwrite implies replace though doesn't it? Yes, and currently it replaces existing keys on the current action. This is of course different from replacing an entire time interval, which is what Wayde made [D10392](https://archive.blender.org/developer/D10392) for.

Brad Clark commented

2021-02-11 19:49:18 +01:00

Right but it says replace the action, not replace keys, action implying replacing all keys with new baked keys based on the settings given (interval 2 or 3 etc)

Why would I want to keep anything if I am "replacing" it.

If I open a blender file and save over another file with my open one, I don't expect it to keep what was in the file I am overwriting... overwrite should overwrite, not merge.

Right but it says replace the action, not replace keys, action implying replacing all keys with new baked keys based on the settings given (interval 2 or 3 etc) Why would I want to keep anything if I am "replacing" it. If I open a blender file and save over another file with my open one, I don't expect it to keep what was in the file I am overwriting... overwrite should overwrite, not merge.

Luciano Muñoz Sessarego commented

2021-02-11 19:57:33 +01:00

Added subscriber: @LucianoMunoz

Luciano Muñoz Sessarego commented

2021-02-11 19:57:33 +01:00

Agree with Brad here.
We should maybe make a list and clarify the options / terms used so we're all on the same page

Agree with Brad here. We should maybe make a list and clarify the options / terms used so we're all on the same page

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Baking animation on 2s ( Frame Step = 2) and with 'Overwrite Current Action' enabled, still keeps old keyframes inbetween steps. #85050