Rotation pivot uses mesh object instead of pose bone while in weight paint mode #85471

Closed
opened 2021-02-08 15:31:25 +01:00 by Demeter Dzadik · 10 comments
Member

System Information
Operating system: Linux-5.4.0-7634-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100

Blender Version
Broken: e12eb89f22 (bisected)

Short description of error
The Local, Normal and Gimbal transform orientations seem to be taking their data from the active mesh object instead of the active pose bone, resulting in these transform orientations being unusable now. This is only in weight paint mode. I believe this was introduced fairly recently, and this makes weight painting properly virtually impossible, since every time I want to do something as basic as rotating a bone on its local axis, I have to leave weight paint mode.

Exact steps for others to reproduce the error

  • weight_paint_orientation.blend
  • The above file is already in weight paint mode. The object and bone are oriented differently to illustrate, and the current orientation mode is Local.
  • Press R, X to rotate. The bone rotates around the cube's local axis, which is wrong.
  • Leave weight paint mode, enter pose mode, and try rotating the bone with R, X to see the expected behaviour.
**System Information** Operating system: Linux-5.4.0-7634-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.100 **Blender Version** Broken: e12eb89f22c6ee17971195e0221a8e8b8ee3db8a (bisected) **Short description of error** The Local, Normal and Gimbal transform orientations seem to be taking their data from the active mesh object instead of the active pose bone, resulting in these transform orientations being unusable now. This is only in weight paint mode. I believe this was introduced fairly recently, and this makes weight painting properly virtually impossible, since every time I want to do something as basic as rotating a bone on its local axis, I have to leave weight paint mode. **Exact steps for others to reproduce the error** - [weight_paint_orientation.blend](https://archive.blender.org/developer/F9727099/weight_paint_orientation.blend) - The above file is already in weight paint mode. The object and bone are oriented differently to illustrate, and the current orientation mode is Local. - Press R, X to rotate. The bone rotates around the cube's local axis, which is wrong. - Leave weight paint mode, enter pose mode, and try rotating the bone with R, X to see the expected behaviour.
Author
Member

Added subscriber: @Mets

Added subscriber: @Mets
Author
Member

The same issue is present with cursor snapping. "Snap cursor to selected" snaps to the mesh object rather than bones. I'm guessing it's the same issue, but if not I can open a separate report. I'm also less confident that this didn't always work this way, but I don't think it did. It's definitely wrong either way though.

The same issue is present with cursor snapping. "Snap cursor to selected" snaps to the mesh object rather than bones. I'm guessing it's the same issue, but if not I can open a separate report. I'm also less confident that this didn't always work this way, but I don't think it did. It's definitely wrong either way though.

Added subscriber: @ZedDB

Added subscriber: @ZedDB

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Can confirm that this doesn't happen with the 2.92 branch. Must be a recent change, bisecting.

Can confirm that this doesn't happen with the 2.92 branch. Must be a recent change, bisecting.

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Bisected it to: e12eb89f22

@mano-wii It seems like this fix broke local rotation in weight paint mode. From the task it fixed, it seems like this was unintentional.
From the code it is not obvious that it will break this use case. So perhaps we should add a automated test for this to test this quirk?

We can take the example file and do a local transform rotation and check if the bone rotated along the bone local axis as intented.

Bisected it to: e12eb89f22c6ee17971195e0221a8e8b8ee3db8a @mano-wii It seems like this fix broke local rotation in weight paint mode. From the task it fixed, it seems like this was unintentional. From the code it is not obvious that it will break this use case. So perhaps we should add a automated test for this to test this quirk? We can take the example file and do a local transform rotation and check if the bone rotated along the bone local axis as intented.

This issue was referenced by bdb83cc32c

This issue was referenced by bdb83cc32cbd0997752420ef95c791f66dca54c8

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Germano Cavalcante self-assigned this 2021-02-10 16:33:08 +01:00
Author
Member

Just updated my Blender to test, thanks so much for the fix!

Just updated my Blender to test, thanks so much for the fix!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#85471
No description provided.