Refactor High level UI code into its own module #85484

New Issue

Aaron Carlisle · 2021-02-09T06:08:14+01:00

Aaron Carlisle commented

2021-02-09 06:08:14 +01:00

As part of #75724, many UI layouts are now coded inside large modules (nodes, modifiers, etc).
This has the disadvantage of these modules depending on /editors for simple high-level button code.

An example of this can be seen in cfa48c84d0

A possible solution to this is moving some high-level UI code from editors in its own UI module.

Candidates for such a change are:

UI_icons.h
UI_interface_icons.h
UI_interface.h
UI_resources.h
UI_view2d.h
... possible others

Some files editor code should be moved to UI_:

ED_screen.h --> UI_screen.h
ED_gizmo_library.h --> UI_gizmo_library.h
ED_gizmo_utils.h --> UI_gizmo_utils.h

This task is first meant to gauge if this is something we should do. After then we can move more into the how.

As part of #75724, many UI layouts are now coded inside large modules (nodes, modifiers, etc). This has the disadvantage of these modules depending on `/editors` for simple high-level button code. An example of this can be seen in cfa48c84d0 A possible solution to this is moving some high-level UI code from editors in its own UI module. Candidates for such a change are: ``` UI_icons.h UI_interface_icons.h UI_interface.h UI_resources.h UI_view2d.h ... possible others ``` Some files editor code should be moved to `UI_`: ``` ED_screen.h --> UI_screen.h ED_gizmo_library.h --> UI_gizmo_library.h ED_gizmo_utils.h --> UI_gizmo_utils.h ``` This task is first meant to gauge if this is something we should do. After then we can move more into the how.

Aaron Carlisle commented

2021-02-09 06:08:14 +01:00

Added subscriber: @Blendify

Aaron Carlisle commented

2021-02-09 06:08:26 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2021-02-10 20:21:34 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-02-10 20:21:34 +01:00

I like this idea. Something to note is that only a small amount of the definitions in UI_resources.h and UI_interface.h is needed for the more distributed button code. For example, I think the modifiers panel drawing and node drawing should only need the uiLayout set of functions, and the icon types from UI_resources.h.

I like this idea. Something to note is that only a small amount of the definitions in `UI_resources.h` and `UI_interface.h` is needed for the more distributed button code. For example, I think the modifiers panel drawing and node drawing should only need the `uiLayout` set of functions, and the icon types from `UI_resources.h`.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Refactor High level UI code into its own module #85484