Lookup for attribute search #85658

New Issue

Dalai Felinto · 2021-02-15T14:39:58+01:00

Dalai Felinto commented

2021-02-15 14:39:58 +01:00

Depends on #85656 and #85657.

Full design reference: #85280

The eye-candy can (should) be done as a separate pass.

Depends on #85656 and #85657. Full design reference: #85280 The eye-candy can (should) be done as a separate pass.

Dalai Felinto commented

2021-02-15 14:39:58 +01:00

Added subscriber: @dfelinto

Hans Goudey self-assigned this 2021-02-22 14:04:37 +01:00

Hans Goudey commented

2021-02-22 21:51:19 +01:00

Okay, I've been fighting with the UI code for a while, time to write some things down.

There are two general approaches I've been trying:

The first is to build an RNA collection with the available attributes and store it in the socket or the node. This approach might simplify the UI code a bit.
However, generating the list of attributes requires the context (to fetch the proper NodeUIStorage from the context map), and as far as I can tell, RNA collection callbacks do not have a way to use the context.
So in order to use this method, we need to add a runtime pointer to the proper NodeUIStorage to every node socket. Then those data structures would be exposed to RNA.

The other approach, what I'm working on now, is more direct, and lower level, simply creating the search button directly in the C/C++ code. This avoids exposing anything to RNA, which probably lowers the total amount of changes considerably.
I've ran into some problems with this approach so far, but I'm working through them, so we'll see how it works.

Okay, I've been fighting with the UI code for a while, time to write some things down. There are two general approaches I've been trying: The first is to build an RNA collection with the available attributes and store it in the socket or the node. This approach might simplify the UI code a bit. However, generating the list of attributes requires the context (to fetch the proper `NodeUIStorage` from the context map), and as far as I can tell, RNA collection callbacks do not have a way to use the context. So in order to use this method, we need to add a runtime pointer to the proper `NodeUIStorage` to every node socket. Then those data structures would be exposed to RNA. The other approach, what I'm working on now, is more direct, and lower level, simply creating the search button directly in the C/C++ code. This avoids exposing anything to RNA, which probably lowers the total amount of changes considerably. I've ran into some problems with this approach so far, but I'm working through them, so we'll see how it works.

Hans Goudey commented

2021-02-22 22:52:30 +01:00

I have some work in progress code in temp-geometry-nodes-attribute-search. 45f6c9bd05 explains some of the current issues.

I have some work in progress code in `temp-geometry-nodes-attribute-search`. 45f6c9bd05 explains some of the current issues.

blender-admin commented

2021-03-02 18:42:05 +01:00

This issue was referenced by 1a8aee0a7c

This issue was referenced by 1a8aee0a7cec0c2718932fdeece9dc071689f928

blender-admin commented

2021-03-02 19:43:27 +01:00

This issue was referenced by a344f20346

This issue was referenced by a344f203467940cbb8fe6dde001fba5c4517619d