Camera background movieclips are not visible if "Viewport Shading" is set to "Rendered" #85750

New Issue

Sebastian · 2021-02-17T19:34:53+01:00

Sebastian commented

2021-02-17 19:34:53 +01:00

System Information
Operating system: Linux-5.4.0-65-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.102.04

Blender Version
Broken: version: 2.92.0 Beta, branch: master, commit date: 2021-02-15 19:10, hash: 3e55d7d605
Worked: 2.90.1
Caused by 3ffa0452af

Short description of error
While static background images of cameras are correctly visualized when "Viewport Shading" is set to "Rendered", background image sequences defined with the clip editor are only visible when "Viewport Shading" is set to "Material Preview", "Solid" or "Wireframe"

Exact steps for others to reproduce the error
In the following python script adjust the path such that it points to some valid input image.

background_image_test.py

Excecuting the script creates two cameras.

The first camera contains a static background image (see the code snippet below)

static_background_image = static_camera_data.background_images.new()
static_background_image.image = bpy.data.images.load(image_fp)

and is visible for all "Viewport Shading" types.

The second camera contains a background image defined by a video clip (see the code snippet below),

dynamic_background_image = dynamic_camera_data.background_images.new()
dynamic_background_image.source = "MOVIE_CLIP"
dynamic_background_image.clip = bpy.data.movieclips[first_fn]

which is not visible when "Viewport Shading" is set to rendered.

**System Information** Operating system: Linux-5.4.0-65-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: Quadro RTX 6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 450.102.04 **Blender Version** Broken: version: 2.92.0 Beta, branch: master, commit date: 2021-02-15 19:10, hash: `3e55d7d605` Worked: 2.90.1 Caused by 3ffa0452af **Short description of error** While static background images of cameras are correctly visualized when "Viewport Shading" is set to "Rendered", background image sequences defined with the clip editor are only visible when "Viewport Shading" is set to "Material Preview", "Solid" or "Wireframe" **Exact steps for others to reproduce the error** In the following python script adjust the path such that it points to some valid input image. [background_image_test.py](https://archive.blender.org/developer/F9812908/background_image_test.py) Excecuting the script creates two cameras. The first camera contains a static background image (see the code snippet below) ``` static_background_image = static_camera_data.background_images.new() static_background_image.image = bpy.data.images.load(image_fp) ``` and is visible for all "Viewport Shading" types. ![static_background_shading_rendered.png](https://archive.blender.org/developer/F9812938/static_background_shading_rendered.png) The second camera contains a background image defined by a video clip (see the code snippet below), ``` dynamic_background_image = dynamic_camera_data.background_images.new() dynamic_background_image.source = "MOVIE_CLIP" dynamic_background_image.clip = bpy.data.movieclips[first_fn] ``` which is not visible when "Viewport Shading" is set to rendered.

Sebastian commented

2021-02-17 19:34:53 +01:00

Added subscriber: @sbcv

Philipp Oeser commented

2021-02-18 10:39:50 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-02-18 10:39:50 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2021-02-18 10:39:50 +01:00

Philipp Oeser commented

2021-02-18 10:39:50 +01:00

Can confirm, will check.

Sebastian commented

2021-02-18 10:43:26 +01:00

Nice, thank you!

Philipp Oeser commented

2021-02-18 10:49:26 +01:00

note: actually works if Depth is set to Front

note: actually works if `Depth` is set to `Front`

Sebastian commented

2021-02-18 10:54:23 +01:00

Can you elaborate this a little bit? (Where do I find this setting?)

Philipp Oeser commented

2021-02-18 11:20:04 +01:00

In #85750#1114654, @sbcv wrote:
Can you elaborate this a little bit? (Where do I find this setting?)

Of course, Front is not always what you want (was more or less just a not to myself as I am looking at this soonish)

> In #85750#1114654, @sbcv wrote: > Can you elaborate this a little bit? (Where do I find this setting?) ![image.png](https://archive.blender.org/developer/F9814739/image.png) Of course, `Front` is not always what you want (was more or less just a not to myself as I am looking at this soonish)

Sebastian commented

2021-02-18 11:27:54 +01:00

Thank you! This allows me to create a workaround (for previous Blender versions) when importing reconstructions with the photogrammetry addon.

Philipp Oeser commented

2021-02-18 14:12:31 +01:00

Added subscribers: @fclem, @Jeroen-Bakker

Philipp Oeser commented

2021-02-18 14:12:31 +01:00

Caused by 3ffa0452af.

Been looking into it a bit, but not sure what is wrong with blending, shotgun debugging gives me this working solution (but I assume this is against the intentions of DRW_STATE_BLEND_ALPHA_UNDER_PREMUL):

P1969: T85750_snippet



diff --git a/source/blender/draw/engines/overlay/overlay_image.c b/source/blender/draw/engines/overlay/overlay_image.c
index 844a0eb8351..666355b859b 100644
--- a/source/blender/draw/engines/overlay/overlay_image.c
+++ b/source/blender/draw/engines/overlay/overlay_image.c
@@ -57,7 +57,8 @@ void OVERLAY_image_cache_init(OVERLAY_Data *vedata)
 
   state = DRW_STATE_WRITE_COLOR | DRW_STATE_DEPTH_GREATER | DRW_STATE_BLEND_ALPHA_PREMUL;
   DRW_PASS_CREATE(psl->image_background_ps, state);
-  state = DRW_STATE_WRITE_COLOR | DRW_STATE_BLEND_ALPHA_UNDER_PREMUL;
+  state = DRW_STATE_WRITE_COLOR | DRW_STATE_WRITE_DEPTH | DRW_STATE_DEPTH_LESS_EQUAL |
+          DRW_STATE_BLEND_ALPHA_UNDER_PREMUL;
   DRW_PASS_CREATE(psl->image_background_scene_ps, state);
 
   state = DRW_STATE_WRITE_COLOR | DRW_STATE_WRITE_DEPTH | DRW_STATE_DEPTH_LESS;
diff --git a/source/blender/gpu/opengl/gl_state.cc b/source/blender/gpu/opengl/gl_state.cc
index b837eae4871..7ffb037f55e 100644
--- a/source/blender/gpu/opengl/gl_state.cc
+++ b/source/blender/gpu/opengl/gl_state.cc
@@ -422,10 +422,10 @@ void GLStateManager::set_blend(const eGPUBlend value)
       break;
     }
     case GPU_BLEND_ALPHA_UNDER_PREMUL: {
-      src_rgb = GL_ONE_MINUS_DST_ALPHA;
-      dst_rgb = GL_ONE;
-      src_alpha = GL_ONE_MINUS_DST_ALPHA;
-      dst_alpha = GL_ONE;
+      src_rgb = GL_ONE;
+      dst_rgb = GL_ONE_MINUS_DST_ALPHA;
+      src_alpha = GL_ONE;
+      dst_alpha = GL_ONE_MINUS_DST_ALPHA;
       break;
     }
     case GPU_BLEND_CUSTOM: {

Will set this to High prio since it is a regression

CC @Jeroen-Bakker
CC @fclem

Caused by 3ffa0452af. Been looking into it a bit, but not sure what is wrong with blending, shotgun debugging gives me this working solution (but I assume this is against the intentions of `DRW_STATE_BLEND_ALPHA_UNDER_PREMUL`): [P1969: T85750_snippet](https://archive.blender.org/developer/P1969.txt) ``` diff --git a/source/blender/draw/engines/overlay/overlay_image.c b/source/blender/draw/engines/overlay/overlay_image.c index 844a0eb8351..666355b859b 100644 --- a/source/blender/draw/engines/overlay/overlay_image.c +++ b/source/blender/draw/engines/overlay/overlay_image.c @@ -57,7 +57,8 @@ void OVERLAY_image_cache_init(OVERLAY_Data *vedata) state = DRW_STATE_WRITE_COLOR | DRW_STATE_DEPTH_GREATER | DRW_STATE_BLEND_ALPHA_PREMUL; DRW_PASS_CREATE(psl->image_background_ps, state); - state = DRW_STATE_WRITE_COLOR | DRW_STATE_BLEND_ALPHA_UNDER_PREMUL; + state = DRW_STATE_WRITE_COLOR | DRW_STATE_WRITE_DEPTH | DRW_STATE_DEPTH_LESS_EQUAL | + DRW_STATE_BLEND_ALPHA_UNDER_PREMUL; DRW_PASS_CREATE(psl->image_background_scene_ps, state); state = DRW_STATE_WRITE_COLOR | DRW_STATE_WRITE_DEPTH | DRW_STATE_DEPTH_LESS; diff --git a/source/blender/gpu/opengl/gl_state.cc b/source/blender/gpu/opengl/gl_state.cc index b837eae4871..7ffb037f55e 100644 --- a/source/blender/gpu/opengl/gl_state.cc +++ b/source/blender/gpu/opengl/gl_state.cc @@ -422,10 +422,10 @@ void GLStateManager::set_blend(const eGPUBlend value) break; } case GPU_BLEND_ALPHA_UNDER_PREMUL: { - src_rgb = GL_ONE_MINUS_DST_ALPHA; - dst_rgb = GL_ONE; - src_alpha = GL_ONE_MINUS_DST_ALPHA; - dst_alpha = GL_ONE; + src_rgb = GL_ONE; + dst_rgb = GL_ONE_MINUS_DST_ALPHA; + src_alpha = GL_ONE; + dst_alpha = GL_ONE_MINUS_DST_ALPHA; break; } case GPU_BLEND_CUSTOM: { ``` Will set this to High prio since it is a regression CC @Jeroen-Bakker CC @fclem

Philipp Oeser removed their assignment 2021-02-18 14:13:15 +01:00

Philipp Oeser changed title from ~~Camera background images defined with bpy.data.movieclips() are not visible if "Viewport Shading" is set to "Rendered"~~ to Camera background movieclips are not visible if "Viewport Shading" is set to "Rendered"

2021-02-19 09:15:19 +01:00

Jeroen Bakker commented

2021-03-09 09:05:13 +01:00

This used to be a known issue. To show it the film transparency has to be turned on. The change above does seem to work for me and would introduce blending with other images.

hujin commented

2021-03-14 05:32:47 +01:00

Added subscriber: @2046411367

Jeroen Bakker commented

2021-06-01 17:03:37 +02:00

Lowering prio, as this one flew below the radar.

Jeroen Bakker self-assigned this 2021-06-01 17:05:23 +02:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Camera background movieclips are not visible if "Viewport Shading" is set to "Rendered" #85750