self is self.id_data is inconsistent. #86170

New Issue

Will · 2021-03-01T22:15:00+01:00

Will commented

2021-03-01 22:15:00 +01:00

System Information
Operating system: Linux
Graphics card: Intel

Blender Version
Broken: 2.91.0
Worked: never

Short description of error

When the driver code self is self.id_data is evaluated on an Object property (E.G. Transform) in a file that contains in multiple drivers, it will sometimes return True and sometimes return False, for different updates on the same driver channel.

#Test.py
import bpy

bpy.app.driver_namespace["Test"] = lambda self: self is self.id_data

I'm not sure whether this is a bug, as the behaviour seems somewhat reasonable given the strictness of identity comparison and the complexity of Blender's API— The object might get moved around in memory or destroyed and re-made or something.

But on the other hand, I also think it seems reasonable to expect a single code line, executed sequentially, to behave consistently in that regard.

I think I was also confused because the behaviour seems much more consistent when the number of drivers is fewer and their relationship is simpler, and because this behaviour doesn't seem to occur in the interactive console (E.G. all(C.active_object is C.active_object.id_data for i in range(10000)) == True). So when testing the expression to figure out whether it's safe to use, I easily concluded that it seems fine, only to have problems once the scene was complex enough for it to be harder to track down the cause.

Also, if you assign self and self.id_data to variables before comparing them, and you print out the variables, then it will actually show that do in fact they have the same memory address (E.G. a, b = self, self.id_data; c = a is b; print(a, b, c) can produce <bpy_struct, Object("ObjectName") at 0x7f4b07a76208, evaluated> <bpy_struct, Object("ObjectName") at 0x7f4b07a76208, evaluated> False, where both Python objects are apparently at 0x7f4b07a76208.)

Exact steps for others to reproduce the error
Open the attached .blend file, then rapidly click "Update Dependencies" on a transform channel's driver until the Cube's location starts jumping around.

SelfIsntNotSelfIDData.blend

**System Information** Operating system: Linux Graphics card: Intel **Blender Version** Broken: 2.91.0 Worked: never **Short description of error** When the driver code `self is self.id_data` is evaluated on an Object property (E.G. Transform) in a file that contains in multiple drivers, it will sometimes return `True` and sometimes return `False`, for different updates on the same driver channel. ![image.png](https://archive.blender.org/developer/F9857835/image.png) ![image.png](https://archive.blender.org/developer/F9857837/image.png) ``` #Test.py import bpy bpy.app.driver_namespace["Test"] = lambda self: self is self.id_data ``` ![image.png](https://archive.blender.org/developer/F9857839/image.png) ![image.png](https://archive.blender.org/developer/F9857841/image.png) I'm not sure whether this is a bug, as the behaviour seems somewhat reasonable given the strictness of identity comparison and the complexity of Blender's API— The object might get moved around in memory or destroyed and re-made or something. But on the other hand, I also think it seems reasonable to expect a single code line, executed sequentially, to behave consistently in that regard. I think I was also confused because the behaviour seems much more consistent when the number of drivers is fewer and their relationship is simpler, and because this behaviour doesn't seem to occur in the interactive console (E.G. `all(C.active_object is C.active_object.id_data for i in range(10000)) == True`). So when testing the expression to figure out whether it's safe to use, I easily concluded that it seems fine, only to have problems once the scene was complex enough for it to be harder to track down the cause. Also, if you assign `self` and `self.id_data` to variables before comparing them, and you print out the variables, then it will actually show that do in fact they have the same memory address (E.G. `a, b = self, self.id_data; c = a is b; print(a, b, c)` can produce `<bpy_struct, Object("ObjectName") at 0x7f4b07a76208, evaluated> <bpy_struct, Object("ObjectName") at 0x7f4b07a76208, evaluated> False`, where both Python objects are apparently at `0x7f4b07a76208`.) **Exact steps for others to reproduce the error** Open the attached `.blend` file, then rapidly click "Update Dependencies" on a transform channel's driver until the `Cube`'s location starts jumping around. [SelfIsntNotSelfIDData.blend](https://archive.blender.org/developer/F9857867/SelfIsntNotSelfIDData.blend)

Will commented

2021-03-01 22:15:00 +01:00

Added subscriber: @WCN

Demeter Dzadik commented

2021-03-02 11:23:22 +01:00

Added subscriber: @Mets

Demeter Dzadik commented

2021-03-02 11:23:22 +01:00

From the PyAPI:
id_data: The bpy.types.ID object this datablock is from or None, (not available for all data types)

So, on a driver placed on a Constraint property, where self refers to the constraint, self.id_data will refer to the bpy.types.Object that holds the constraint. self != self.id_data.
On a driver placed on an Object property, where self refers to the object, self==self.id_data.

That said, I find the nomenclature around what's an "ID" and what's a "datablock" very confusing, so I would be interested to hear some developer input on that, but I don't think there is a bug here.

From the PyAPI: `id_data: The bpy.types.ID object this datablock is from or None, (not available for all data types)` So, on a driver placed on a Constraint property, where `self` refers to the constraint, `self.id_data` will refer to the bpy.types.Object that holds the constraint. self != self.id_data. On a driver placed on an Object property, where `self` refers to the object, self==self.id_data. That said, I find the nomenclature around what's an "ID" and what's a "datablock" very confusing, so I would be interested to hear some developer input on that, but I don't think there is a bug here.

Will commented

2021-03-02 14:19:28 +01:00

In #86170#1122225, @Mets wrote:
From the PyAPI:
id_data: The bpy.types.ID object this datablock is from or None, (not available for all data types)

So, on a driver placed on a Constraint property, where self refers to the constraint, self.id_data will refer to the bpy.types.Object that holds the constraint. self != self.id_data.
On a driver placed on an Object property, where self refers to the object, self==self.id_data.

Oh yeah, I'm aware of that. Sorry, I should have been clearer in my original post.

The inconsistency occurs when the driver is placed on the Object datablock. As you can see from my screenshots, self is self.id_data will sometimes be True and sometimes be False on drivers for the .location- [ ] property of the object— It's the same driver on the same Object property that evaluates differently every couple updates, even though both sides always refer to the same Blender Object() with apparently the same memory address.

It's a non-issue on Constraints, Modifiers, etc. because, as you note, there it will always return False anyway. Also, I should note that only is is inconsistent (and presumably is not is as well); == seems to work fine as I can tell. (But == is a magic method while is is a language feature, so especially since the memory addresses and str() of self and self.id_data seem to be the same even where is returns False and since is appears to work perfectly in all situations where a user could reasonably test it, there may be an argument for reasonably using is instead of ==.)

> In #86170#1122225, @Mets wrote: > From the PyAPI: > `id_data: The bpy.types.ID object this datablock is from or None, (not available for all data types)` > > So, on a driver placed on a Constraint property, where `self` refers to the constraint, `self.id_data` will refer to the bpy.types.Object that holds the constraint. self != self.id_data. > On a driver placed on an Object property, where `self` refers to the object, self==self.id_data. Oh yeah, I'm aware of that. Sorry, I should have been clearer in my original post. The inconsistency occurs when the driver is placed on the `Object` datablock. As you can see from my screenshots, `self is self.id_data` will sometimes be `True` and sometimes be `False` on drivers for the `.location- [ ]` property of the object— It's the same driver on the same `Object` property that evaluates differently every couple updates, even though both sides always refer to the same Blender `Object()` with apparently the same memory address. It's a non-issue on Constraints, Modifiers, etc. because, as you note, there it will always return `False` anyway. Also, I should note that only `is` is inconsistent (and presumably `is not` is as well); `==` seems to work fine as I can tell. (But `==` is a magic method while `is` is a language feature, so especially since the memory addresses and `str()` of `self` and `self.id_data` seem to be the same even where `is` returns `False` and since `is` appears to work perfectly in all situations where a user could reasonably test it, there may be an argument for reasonably using `is` instead of `==`.)

Demeter Dzadik commented

2021-03-02 17:08:10 +01:00

Oh I see, thanks for the clarification! That does sound like a bug indeed :)

Philipp Oeser commented

2021-03-17 15:15:28 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-03-17 15:15:28 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-03-17 15:15:28 +01:00

Thx for the detailed report.

Also, I should note that only is is inconsistent (and presumably is not is as well); == seems to work fine as I can tell.

For me == can also fail (although apparently less often.

Thx for the detailed report. > Also, I should note that only is is inconsistent (and presumably is not is as well); == seems to work fine as I can tell. For me `==` can also fail (although apparently less often.

Campbell Barton self-assigned this 2021-04-22 10:45:00 +02:00

blender-admin commented

2021-04-23 01:02:49 +02:00

This issue was referenced by 47cc05471d

This issue was referenced by 47cc05471d1c046ad89b7e60f52157ca7dcda075

blender-admin commented

2021-04-23 01:02:49 +02:00

This issue was referenced by a23e49c696

This issue was referenced by a23e49c696cf9ac66ecb9c1ad009d38b0a5e9f9f

Campbell Barton commented

2021-04-23 01:04:25 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2021-04-23 01:04:25 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

self is self.id_data is inconsistent. #86170

`self is self.id_data` is inconsistent. #86170