Missing updates after geometry nodes drag and drop #86722

New Issue

Zijun Zhou · 2021-03-19T02:31:08+01:00

Zijun Zhou commented

2021-03-19 02:31:08 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce MX130/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.92

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-03-18 21:29, hash: 36deb8a48e
Worked: Never

Short description of error
The data in object info (e.g. Location) created by drag and drop does not update when moving the object in viewport, it is fixed after manually picking the object again. Here is video:
Drag and Drop Bug 1.mp4

Exact steps for others to reproduce the error
Based on the default startup

Add Geometry Nodes to the cube, add a transform node
Drag and drop the default light object in
connect the location of Object Info node to the transform node's Translation socket
Move the default light in viewport, the cube is not following

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce MX130/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.92 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-03-18 21:29, hash: `36deb8a48e` Worked: Never **Short description of error** The data in object info (e.g. Location) created by drag and drop does not update when moving the object in viewport, it is fixed after manually picking the object again. Here is video: [Drag and Drop Bug 1.mp4](https://archive.blender.org/developer/F9898820/Drag_and_Drop_Bug_1.mp4) **Exact steps for others to reproduce the error** Based on the default startup 1. Add Geometry Nodes to the cube, add a transform node 2. Drag and drop the default light object in 3. connect the location of Object Info node to the transform node's Translation socket 4. Move the default light in viewport, the cube is not following

Zijun Zhou commented

2021-03-19 02:31:08 +01:00

Added subscriber: @Eary

Zijun Zhou changed title from ~~Two Bugs of Geometry Nodes' Drag and Drop Object Collection~~ to Two Bugs of Geometry Nodes' Drag and Drop Object into Object Info

2021-03-19 02:41:49 +01:00

Charlie Jolly commented

2021-03-19 12:54:13 +01:00

Added subscriber: @CharlieJolly

Charlie Jolly commented

2021-03-19 12:54:13 +01:00

First bug looks like a dependency issue. Possibly the drag node operator is missing a dependency tag update.

Second bug is not implemented, thanks for pointing this out.

First bug looks like a dependency issue. Possibly the drag node operator is missing a dependency tag update. Second bug is not implemented, thanks for pointing this out.

Charlie Jolly commented

2021-03-19 13:02:01 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2021-03-19 13:40:47 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-03-19 13:40:47 +01:00

Thanks for the report! For the purpose of working on these issues and keeping track of fixes it's really much easier if they are in separate reports. Do you mind splitting up the second issue into a different report?

@CharlieJolly, do you mind taking a look at these issues?

EDIT: Oops, I see Charlie already has taken a look!

Thanks for the report! For the purpose of working on these issues and keeping track of fixes it's really much easier if they are in separate reports. Do you mind splitting up the second issue into a different report? @CharlieJolly, do you mind taking a look at these issues? EDIT: Oops, I see Charlie already has taken a look!

Charlie Jolly commented

2021-03-19 14:30:10 +01:00

@HooglyBoogly I fixed the update issue by calling ED_node_tag_update_nodetree see: P2039

The Paste Name operator is just not implemented. Doesn't work for shading nodes either. I added a condition to the poll so that it ignores drag and drop on the button.

I can commit this as a fix directly unless it's better to create a diff first.

@HooglyBoogly I fixed the update issue by calling `ED_node_tag_update_nodetree` see: [P2039](https://archive.blender.org/developer/P2039.txt) The `Paste Name` operator is just not implemented. Doesn't work for shading nodes either. I added a condition to the poll so that it ignores drag and drop on the button. I can commit this as a fix directly unless it's better to create a diff first.

Charlie Jolly self-assigned this 2021-03-19 14:30:21 +01:00

Hans Goudey commented

2021-03-19 15:52:38 +01:00

Yeah, just make a diff.

Charlie Jolly commented

2021-03-19 15:55:04 +01:00

Added here: D10769

Added here: [D10769](https://archive.blender.org/developer/D10769)

Hans Goudey changed title from ~~Two Bugs of Geometry Nodes' Drag and Drop Object into Object Info~~ to Missing updates after geometry nodes drag and drop

2021-03-24 13:55:58 +01:00

blender-admin commented

2021-03-24 14:57:27 +01:00

This issue was referenced by 337a122e44

This issue was referenced by 337a122e44a3f6b28b8118c9fc4f06e397885c13

blender-admin commented

2021-03-24 15:04:29 +01:00

This issue was referenced by ce359da5b3

This issue was referenced by ce359da5b3ac98c9f7cfd6593cc1769ec3b7247b

Charlie Jolly commented

2021-03-24 15:28:00 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Charlie Jolly closed this issue

2021-03-24 15:28:00 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Missing updates after geometry nodes drag and drop #86722