Theme: Active Modifier Outline color not saving with the preferences #86781

New Issue

TheRedWaxPolice · 2021-03-21T04:59:22+01:00

TheRedWaxPolice commented

2021-03-21 04:59:22 +01:00

System Information
Operating system: Win 10

Blender Version
Broken: blender-2.93.0-258b15da74ad-windows64
Worked: No idea

Short description of error
The "Active Modifier Outline" color is not saving with the preferences. It means that if you change that color and then save the preferences, the next time you launch blender the color will reset itself to it's default "blue" color

Exact steps for others to reproduce the error
Launch blender
Go to Edit > Preferences
In the Themes tab open the Properties section
Change the color of the "Active Modifier Outline"
Click on the button located on the bottom left of the Preferences window and choose "Save Preferences"
Close blender and then launch it again
If you go check the color you can see that it didn't saved with the preferences and it went back to the default "blue"

**System Information** Operating system: Win 10 **Blender Version** Broken: blender-2.93.0-258b15da74ad-windows64 Worked: No idea **Short description of error** The "Active Modifier Outline" color is not saving with the preferences. It means that if you change that color and then save the preferences, the next time you launch blender the color will reset itself to it's default "blue" color **Exact steps for others to reproduce the error** Launch blender Go to Edit > Preferences In the Themes tab open the Properties section Change the color of the "Active Modifier Outline" Click on the button located on the bottom left of the Preferences window and choose "Save Preferences" Close blender and then launch it again If you go check the color you can see that it didn't saved with the preferences and it went back to the default "blue"

TheRedWaxPolice commented

2021-03-21 04:59:22 +01:00

Added subscriber: @TheRedWaxPolice

Simon Sommer commented

2021-03-21 14:01:32 +01:00

Added subscriber: @CreatorSiSo

Simon Sommer commented

2021-03-21 14:01:32 +01:00

Can confirm it is possible to save it to a custom theme and it will be restored when selecting the custome theme after a restart but your default theme always gets reset.

Germano Cavalcante commented

2021-03-25 14:27:55 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-03-25 14:27:55 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Germano Cavalcante closed this issue

2021-03-25 14:27:55 +01:00

Germano Cavalcante commented

2021-03-25 14:27:55 +01:00

This is intentional, you cannot change a preset. You can create another one and remove the previous one.
(Then save the preferences).

This is intentional, you cannot change a preset. You can create another one and remove the previous one. (Then save the preferences).

Germano Cavalcante commented

2021-03-25 14:28:09 +01:00

Closed as duplicate of #61491

Germano Cavalcante closed this issue

2021-03-25 14:28:09 +01:00

TheRedWaxPolice commented

2021-03-25 16:23:20 +01:00

In #86781#1136246, @mano-wii wrote:
This is intentional, you cannot change a preset. You can create another one and remove the previous one.
(Then save the preferences).

Hi, @mano-wii I'm afraid this report was wrongly closed, because this is not what is happening here, and it's not about presets. This is just about saving the preferences.
This bug only happens with this newly added theme property "Active Modifier Outline"... everything else works just fine as always..

You can test yourself if you wish (even on previous versions), you just need to follow the steps above, but instead of changing the "Active Modifier Outline" color, try to change any other theme color, save the preferences and then restart blender. Then you'll see that the changes that you made is preserved and saved with the preferences.
This bug is specific to this recently added color property only.

> In #86781#1136246, @mano-wii wrote: > This is intentional, you cannot change a preset. You can create another one and remove the previous one. > (Then save the preferences). Hi, @mano-wii I'm afraid this report was wrongly closed, because this is not what is happening here, and it's not about presets. This is just about saving the preferences. This bug only happens with this newly added theme property "Active Modifier Outline"... everything else works just fine as always.. You can test yourself if you wish (even on previous versions), you just need to follow the steps above, but instead of changing the "Active Modifier Outline" color, try to change any other theme color, save the preferences and then restart blender. Then you'll see that the changes that you made is preserved and saved with the preferences. This bug is specific to this recently added color property only.

Germano Cavalcante commented

2021-03-25 20:18:28 +01:00

It is indirectly about presets because when trying to change a property and save, you are trying to change one of these presets:

See #61491 (Saving preferences do not save new colors into current/selected Theme) and #83572 (Blender does not save Preferences changes). They are similar reports.

It is indirectly about presets because when trying to change a property and save, you are trying to change one of these presets: ![image.png](https://archive.blender.org/developer/F9909735/image.png) See #61491 (Saving preferences do not save new colors into current/selected Theme) and #83572 (Blender does not save Preferences changes). They are similar reports.

Germano Cavalcante commented

2021-03-25 20:22:14 +01:00

Changed status from 'Duplicate' to: 'Needs Developer To Reproduce'

Germano Cavalcante reopened this issue

2021-03-25 20:22:14 +01:00

Germano Cavalcante commented

2021-03-25 20:22:14 +01:00

In fact, other properties are still present when you change and save the preset.
It deserves an investigation.

In fact, other properties are still present when you change and save the preset. It deserves an investigation.

TheRedWaxPolice commented

2021-03-25 21:46:02 +01:00

In #86781#1136452, @mano-wii wrote:
It is indirectly about presets because when trying to change a property and save, you are trying to change one of these presets:

Not really...
When you save the Preferences, all the settings (including the theme settings) are stored in the "userpref.blend" file. On Windows you can find this file on this path: "%AppData%\Blender Foundation\Blender\2.93\config"

That's the global user preferences file that blender reads on startup. But apparently, for some reason, that specific theme property is not being saved in this file.

This is different from saving a preset. Theme presets can only be saved in the Themes tab, by clicking on that (+) button.

> In #86781#1136452, @mano-wii wrote: > It is indirectly about presets because when trying to change a property and save, you are trying to change one of these presets: > ![image.png](https://archive.blender.org/developer/F9909735/image.png) Not really... When you save the Preferences, all the settings (including the theme settings) are stored in the "userpref.blend" file. On Windows you can find this file on this path: "%AppData%\Blender Foundation\Blender\2.93\config" That's the global user preferences file that blender reads on startup. But apparently, for some reason, that specific theme property is not being saved in this file. This is different from saving a preset. Theme presets can only be saved in the Themes tab, by clicking on that (+) button.

Harley Acheson commented

2021-03-25 22:08:04 +01:00

Added subscriber: @Harley

Harley Acheson commented

2021-03-25 22:08:04 +01:00

Sorry, but neither of you are right....

It is saving just fine, but is always reverting to this default value. This is because it is a very new theme setting so it needs to be dealt with in our versioning code. So at the moment it is setting that value to the defaults every time you open any file. Versioning_userdef.c, about line 275:

FROM_DEFAULT_V4_UCHAR(space_properties.active);

Very soon - the next time someone does a subversion bump - it will start being overrideable as expected, but this is normal behavior for something like this. It will certainly work as you expect at release.

Sorry, but neither of you are right.... It is saving just fine, but is always reverting to this default value. This is because it is a very new theme setting so it needs to be dealt with in our versioning code. So at the moment it is setting that value to the defaults every time you open any file. Versioning_userdef.c, about line 275: ``` FROM_DEFAULT_V4_UCHAR(space_properties.active); ``` Very soon - the next time someone does a subversion bump - it will start being overrideable as expected, but this is normal behavior for something like this. It will certainly work as you expect at release.

Hans Goudey commented

2021-03-25 22:33:24 +01:00

Added subscriber: @HooglyBoogly