Using "E" Key Modifier Hotkey for "gpencil.draw" only draws for a second #87002

New Issue

Miya San · 2021-03-28T19:09:47+02:00

Miya San commented

2021-03-28 19:09:47 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.72

Blender Version
Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-03-18 21:29, hash: 36deb8a48e
Also broken in 2.92 and 2.90

Short description of error
Setting the hotkey for "gpencil.draw" to "E Left Mouse," with "E" as a modifier results in the stroke/eraser to only draw for a second and then stop drawing. Using any other letter modifier like "R Left Mouse" or "P Left Mouse" etc. works as intended. Tried deleting all "E" hotkeys and "Left Mouse" hotkeys to see if there was hotkey interference, but the problem persists.

Exact steps for others to reproduce the error
New file "2D Animation"
Draw some strokes
Open Preferences, go to keymap Grease Pencil Stroke Paint (Draw brush)
Set Grease Pencil Draw key modifier to "E"
Set mode to "Eraser"
Hold "E", try erasing
Switch key modifier to any other letter key like "R"
Try erasing, should work as intended
gpencil.draw_e_modifer_bug.mp4

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.72 **Blender Version** Broken: version: 2.93.0 Alpha, branch: master, commit date: 2021-03-18 21:29, hash: `36deb8a48e` Also broken in 2.92 and 2.90 **Short description of error** Setting the hotkey for "gpencil.draw" to "E Left Mouse," with "E" as a modifier results in the stroke/eraser to only draw for a second and then stop drawing. Using any other letter modifier like "R Left Mouse" or "P Left Mouse" etc. works as intended. Tried deleting all "E" hotkeys and "Left Mouse" hotkeys to see if there was hotkey interference, but the problem persists. **Exact steps for others to reproduce the error** New file "2D Animation" Draw some strokes Open Preferences, go to keymap Grease Pencil Stroke Paint (Draw brush) Set Grease Pencil Draw key modifier to "E" Set mode to "Eraser" Hold "E", try erasing Switch key modifier to any other letter key like "R" Try erasing, should work as intended [gpencil.draw_e_modifer_bug.mp4](https://archive.blender.org/developer/F9912603/gpencil.draw_e_modifer_bug.mp4)

Miya San commented

2021-03-28 19:09:48 +02:00

Added subscriber: @miya

Falk David commented

2021-03-29 10:02:51 +02:00

Added subscribers: @antoniov, @filedescriptor

Falk David commented

2021-03-29 10:02:51 +02:00

This most likely happens because {key E} will actually cancel the drawing operator.

  /* Exit painting mode (and/or end current stroke).
   *
   */
  if (ELEM(event->type, EVT_RETKEY, EVT_PADENTER, EVT_ESCKEY, EVT_SPACEKEY, EVT_EKEY)) { //<--- EVT_EKEY causes this issue

    p->status = GP_STATUS_DONE;
    estate = OPERATOR_FINISHED;
  }

@antoniov Do you know why the {key E} key is in there?

This most likely happens because {key E} will actually cancel the drawing operator. ``` /* Exit painting mode (and/or end current stroke). * */ if (ELEM(event->type, EVT_RETKEY, EVT_PADENTER, EVT_ESCKEY, EVT_SPACEKEY, EVT_EKEY)) { //<--- EVT_EKEY causes this issue p->status = GP_STATUS_DONE; estate = OPERATOR_FINISHED; } ``` @antoniov Do you know why the {key E} key is in there?

Falk David commented

2021-03-29 10:25:41 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Falk David commented

2021-03-29 10:25:41 +02:00

Can confirm on the latest master.

Matias Mendiola commented

2021-03-29 13:22:32 +02:00

Added subscriber: @mendio

Matias Mendiola commented

2021-03-29 13:22:32 +02:00

@antoniov Do you know why the {key E} key is in there?

IIRC {key E} key was used in the first Grease Pencil version to cancel actions, It seems legacy from that version that we forgot to remove, but @antoniov sure know better

> > @antoniov Do you know why the {key E} key is in there? IIRC {key E} key was used in the first Grease Pencil version to cancel actions, It seems legacy from that version that we forgot to remove, but @antoniov sure know better

Falk David commented

2021-03-29 13:27:01 +02:00

@mendio Thanks for the info! I guess if this was from the legacy grease pencil code it could be safe to remove. Waiting for @antoniov to confirm and then I can submit a patch.

Falk David commented

2021-03-29 13:30:48 +02:00

Just tested removing the EVT_EKEY from the keys that exit the operator and that fixes the issue. So just to confirm that this is the problem.

Just tested removing the `EVT_EKEY` from the keys that exit the operator and that fixes the issue. So just to confirm that this is the problem.

blender-admin commented

2021-03-29 15:56:20 +02:00

This issue was referenced by 10e05bb413

This issue was referenced by 10e05bb413947c16f61e0c429b2a3883ab95c983

Falk David commented

2021-03-29 15:58:02 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Falk David closed this issue

2021-03-29 15:58:02 +02:00

Falk David self-assigned this 2021-03-29 15:58:02 +02:00

Falk David commented

2021-03-29 15:58:02 +02:00

Resolved with commit 10e05bb413

Resolved with commit 10e05bb413

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Using "E" Key Modifier Hotkey for "gpencil.draw" only draws for a second #87002