Unknown CPU type reported for Apple M1 #87728

New Issue

Christian Baars · 2021-04-22T21:18:58+02:00

Christian Baars commented

2021-04-22 21:18:58 +02:00

System Information
Operating system: macOS Big Sur 11.2.3
Graphics card: built-in

Blender Version
Broken: every

The CPU brand string is not recognized and an "Unknown CPU" is reported.

The usage of 'sysctlbyname' should be future proof.

For me the following solution works on Intel and Apple Silicon Macs. In intern/cycles/util/util_system.cpp change from line 167:

string system_cpu_brand_string()
{
#if !defined(WIN32) && !defined(__x86_64__) && !defined(__i386__) && !defined(__APPLE__)
  FILE *cpuinfo = fopen("/proc/cpuinfo", "r");
  if (cpuinfo != nullptr) {
    char cpuinfo_buf[513] = "";
    fread(cpuinfo_buf, sizeof(cpuinfo_buf) - 1, 1, cpuinfo);
    fclose(cpuinfo);

    char *modelname = strstr(cpuinfo_buf, "model name");
    if (modelname != nullptr) {
      modelname = strchr(modelname, ':');
      if (modelname != nullptr) {
        modelname += 2;
        char *modelname_end = strchr(modelname, '\n');
        if (modelname_end != nullptr) {
          *modelname_end = '\0';
          return modelname;
        }
      }
    }
  }
#elif defined(__APPLE__)
    char modelname[512];
    size_t bufferlen = 512;
    sysctlbyname("machdep.cpu.brand_string",&modelname,&bufferlen,NULL,0);
    return modelname;
#else
  char buf[49] = {0};
  int result[4] = {0};

  __cpuid(result, 0x80000000);

  if (result[0] != 0 && result[0] >= (int)0x80000004) {
    __cpuid((int *)(buf + 0), 0x80000002);
    __cpuid((int *)(buf + 16), 0x80000003);
    __cpuid((int *)(buf + 32), 0x80000004);

    string brand = buf;

    /* make it a bit more presentable */
    brand = string_remove_trademark(brand);

    return brand;
  }
#endif
  return "Unknown CPU";
}

I am sorry, if this is the wrong way to make a pull request.

Best regards,
Christian Baars

**System Information** Operating system: macOS Big Sur 11.2.3 Graphics card: built-in **Blender Version** Broken: every The CPU brand string is not recognized and an "Unknown CPU" is reported. The usage of 'sysctlbyname' should be future proof. For me the following solution works on Intel and Apple Silicon Macs. In intern/cycles/util/util_system.cpp change from line 167: ``` string system_cpu_brand_string() { #if !defined(WIN32) && !defined(__x86_64__) && !defined(__i386__) && !defined(__APPLE__) FILE *cpuinfo = fopen("/proc/cpuinfo", "r"); if (cpuinfo != nullptr) { char cpuinfo_buf[513] = ""; fread(cpuinfo_buf, sizeof(cpuinfo_buf) - 1, 1, cpuinfo); fclose(cpuinfo); char *modelname = strstr(cpuinfo_buf, "model name"); if (modelname != nullptr) { modelname = strchr(modelname, ':'); if (modelname != nullptr) { modelname += 2; char *modelname_end = strchr(modelname, '\n'); if (modelname_end != nullptr) { *modelname_end = '\0'; return modelname; } } } } #elif defined(__APPLE__) char modelname[512]; size_t bufferlen = 512; sysctlbyname("machdep.cpu.brand_string",&modelname,&bufferlen,NULL,0); return modelname; #else char buf[49] = {0}; int result[4] = {0}; __cpuid(result, 0x80000000); if (result[0] != 0 && result[0] >= (int)0x80000004) { __cpuid((int *)(buf + 0), 0x80000002); __cpuid((int *)(buf + 16), 0x80000003); __cpuid((int *)(buf + 32), 0x80000004); string brand = buf; /* make it a bit more presentable */ brand = string_remove_trademark(brand); return brand; } #endif return "Unknown CPU"; } ``` I am sorry, if this is the wrong way to make a pull request. Best regards, Christian Baars

Christian Baars commented

2021-04-22 21:18:58 +02:00

Added subscriber: @Staars

Alaska commented

2021-04-23 07:43:18 +02:00

Added subscriber: @Alaska

Alaska commented

2021-04-23 07:43:18 +02:00

The official method for submitting a patch can be found on this site:
https://wiki.blender.org/wiki/Process/Contributing_Code

I would personally go down the route of creating a diff file which is described on this site: https://wiki.blender.org/wiki/Tools/CodeReview#Upload_a_Diff
Then to submit it, just go to https:*developer.blender.org/ and select Submit code (shown in image below), upload the diff file, give it a title, add it to the blender repository, and add reviewers (You'll probably find the best people to review this patch in the task #78710, however it may be better to ask over on https:*blender.chat/channel/blender-coders). Following that, go through the review process there.

One thing I'd like to point out first is are you able to give the ARM version of Blender a try to see if it resolves this issue without the patch you've provided? It's available at https://www.blender.org/download/
I'm sorry, I don't have a M1 Mac and so can't test this.

The official method for submitting a patch can be found on this site: https://wiki.blender.org/wiki/Process/Contributing_Code I would personally go down the route of creating a diff file which is described on this site: https://wiki.blender.org/wiki/Tools/CodeReview#Upload_a_Diff Then to submit it, just go to https:*developer.blender.org/ and select `Submit code` (shown in image below), upload the diff file, give it a title, add it to the blender repository, and add reviewers (You'll probably find the best people to review this patch in the task #78710, however it may be better to ask over on https:*blender.chat/channel/blender-coders). Following that, go through the review process there. ![image.png](https://archive.blender.org/developer/F10033401/image.png) One thing I'd like to point out first is are you able to give the ARM version of Blender a try to see if it resolves this issue without the patch you've provided? It's available at https://www.blender.org/download/ I'm sorry, I don't have a `M1` Mac and so can't test this.

Christian Baars commented

2021-04-23 15:58:51 +02:00

Changed status from 'Needs Triage' to: 'Resolved'

Christian Baars closed this issue

2021-04-23 15:58:51 +02:00

Christian Baars self-assigned this 2021-04-23 15:58:51 +02:00

Christian Baars commented

2021-04-23 15:58:51 +02:00

Thank you, I will try this out.

As there is no ARM version for download (that I am aware of), I was referring to self compiled versions (>2.93).

For me this task is resolved.

Thank you, I will try this out. As there is no ARM version for download (that I am aware of), I was referring to self compiled versions (>2.93). For me this task is resolved.

Alaska commented

2021-04-23 23:50:28 +02:00

In #87728#1151111, @Staars wrote:
Thank you, I will try this out.

As there is no ARM version for download (that I am aware of), I was referring to self compiled versions (>2.93).

Sorry, I gave you the wrong link. The ARM version can be downloaded from here: https://builder.blender.org/download/

> In #87728#1151111, @Staars wrote: > Thank you, I will try this out. > > As there is no ARM version for download (that I am aware of), I was referring to self compiled versions (>2.93). Sorry, I gave you the wrong link. The ARM version can be downloaded from here: https://builder.blender.org/download/

Christian Baars commented

2021-04-26 20:47:18 +02:00

Thank You, this does the same, like the self compiled version.
I addressed this topic here: https://developer.blender.org/D11061

This should will be fixed, one way or another.

Thank You, this does the same, like the self compiled version. I addressed this topic here: https://developer.blender.org/D11061 This should will be fixed, one way or another.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Unknown CPU type reported for Apple M1 #87728