Blender Delete file | problem #88131

New Issue

Nicolaj Hazendonk · 2021-05-08T19:21:58+02:00

Nicolaj Hazendonk commented

2021-05-08 19:21:58 +02:00

System Information
Operating system: Windows 10 home 64x
Graphics card: GTX 1050 ti 8gb

Blender Version
Worked: 2.90

Short description of error
the hit X to delete data from inside the File Browser is dangerous because theres no bin. This is a very dangerous operation with no way to get data back.

look at the Windows folder!!! Very dangerous!!!

Exact steps for others to reproduce the error
always

**System Information** Operating system: Windows 10 home 64x Graphics card: GTX 1050 ti 8gb **Blender Version** Worked: 2.90 **Short description of error** the hit X to delete data from inside the File Browser is dangerous because theres no bin. This is a very dangerous operation with no way to get data back. look at the Windows folder!!! Very dangerous!!! **Exact steps for others to reproduce the error** always

Nicolaj Hazendonk commented

2021-05-08 19:21:58 +02:00

Added subscriber: @Das_Nicolaj

Himanshi Kalra commented

2021-05-08 20:53:31 +02:00

Added subscriber: @Calra

Himanshi Kalra commented

2021-05-08 20:53:31 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Himanshi Kalra commented

2021-05-08 20:53:31 +02:00

I deleted files by pressing X in the File Browser.
There are going to the Recycle Bin in Windows.

Can you double check?
I cannot reproduce this issue.

I deleted files by pressing `X` in the File Browser. There are going to the Recycle Bin in Windows. Can you double check? I cannot reproduce this issue.

Nicolaj Hazendonk commented

2021-05-08 21:09:04 +02:00

PC is freezing of this

and what about the Windows folder?

PC is freezing of this and what about the Windows folder?

Robert Guetzkow commented

2021-05-08 23:58:28 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2021-05-08 23:58:28 +02:00

@Das_Nicolaj Since commits 8825250f5a and 98dfb4dd1c all file delete operations from the file browser result in moving the files and directories into the recycling bin.

Please describe step by step what you are doing and what happens as a result of it. What do you mean by "look at the Windows folder"? Please also tell us what version of Blender are you testing this in?

In the default keymap the {key X} is mapped to call file.delete in the file browser (FILE_OT_delete implemented in file_ops.c). This function in turn calls file_delete_exec, which calls file_delete_single. To delete the files it only uses the non-destructive BLI_delete_soft that moves them to the recycling bin.

@Das_Nicolaj Since commits 8825250f5a and 98dfb4dd1c all file delete operations from the file browser result in moving the files and directories into the recycling bin. Please describe step by step what you are doing and what happens as a result of it. What do you mean by "look at the Windows folder"? Please also tell us what version of Blender are you testing this in? In the default keymap the {key X} is mapped to call `file.delete` in the file browser (`FILE_OT_delete` implemented in `file_ops.c`). This function in turn calls `file_delete_exec`, which calls `file_delete_single`. To delete the files it only uses the non-destructive `BLI_delete_soft` that moves them to the recycling bin.

Harley Acheson commented

2021-05-09 00:05:02 +02:00

Added subscriber: @Harley

Harley Acheson commented

2021-05-09 00:05:02 +02:00

On Windows, deleting a file in the File Browser sends it to the Recycle Bin where it can be recovered.

and what about the Windows folder?

Don't delete that. Don't do that from inside Blender, and don't do that from outside Blender.

Do not delete them from your house, do not delete them with your mouse. Do not delete them in a box, do not delete them with a fox. Do not delete them in your car, keep them keep them, where they are. Do not delete them here nor there, do not delete them anywhere.

On Windows, deleting a file in the File Browser sends it to the Recycle Bin where it can be recovered. > and what about the Windows folder? Don't delete that. Don't do that from inside Blender, and don't do that from outside Blender. Do not delete them from your house, do not delete them with your mouse. Do not delete them in a box, do not delete them with a fox. Do not delete them in your car, keep them keep them, where they are. Do not delete them here nor there, do not delete them anywhere.

Robert Guetzkow commented

2021-05-09 00:08:05 +02:00

@Das_Nicolaj If you did indeed mean that you tried to delete files from C:\Windows then this is a bad idea no matter whether you attempt to do this from within Blender or the Windows Explorer. Those files are part of the Windows operating system and should not be deleted or moved.

@Das_Nicolaj If you did indeed mean that you tried to delete files from `C:\Windows` then this is a bad idea no matter whether you attempt to do this from within Blender or the Windows Explorer. Those files are part of the Windows operating system and should not be deleted or moved.

Jesse Yurkovich commented

2021-05-09 02:08:13 +02:00

Added subscriber: @deadpin

Jesse Yurkovich commented

2021-05-09 02:08:13 +02:00

No repro here -- the file will go the recycle bin for me.

Additionally, if you navigate to the windows folder with blender and attempt to x a text file (for example) you are first prompted with a Windows dialog asking if you want to elevate to Administrator since that's what's required (your account needs to be part of the Administrators group for this to even happen).

Hitting yes will then prompt you again with another dialog because the app itself needs permission to make changes to such folders.

If you click though both of those confirmations the file will finally end up in the Recycle Bin.

That said, I do think it's unfortunate that the file browser takes over keys in general. I would really like to start typing and have the file browser just navigate to the file/folder whose letters I'm typing. This occurs in all other file browsers so it's entirely reasonable for a user to expect this behavior. But right now it takes over all the keys like T, N, X etc. for its own purposes. This is not a bug today but a larger design issue that would be discussed elsewhere.

No repro here -- the file will go the recycle bin for me. Additionally, if you navigate to the windows folder with blender and attempt to `x` a text file (for example) you are first prompted with a Windows dialog asking if you want to elevate to Administrator since that's what's required (your account needs to be part of the Administrators group for this to even happen). Hitting yes will then prompt you again with another dialog because the app itself needs permission to make changes to such folders. If you click though both of those confirmations the file will finally end up in the Recycle Bin. That said, I do think it's unfortunate that the file browser takes over keys in general. I would really like to start typing and have the file browser just navigate to the file/folder whose letters I'm typing. This occurs in all other file browsers so it's entirely reasonable for a user to expect this behavior. But right now it takes over all the keys like T, N, X etc. for its own purposes. This is not a bug today but a larger design issue that would be discussed elsewhere.

Himanshi Kalra commented

2021-05-14 14:24:56 +02:00

Changed status from 'Needs User Info' to: 'Archived'

Himanshi Kalra closed this issue

2021-05-14 14:24:56 +02:00

Himanshi Kalra commented

2021-05-14 14:24:56 +02:00

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed.

Thanks again for the report. If the problem persists please open a new report with the required information.

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed. Thanks again for the report. If the problem persists please open a new report with the required information.

Nicolaj Hazendonk commented

2021-05-23 13:02:44 +02:00

sorry if i give no reation

will the design of the X delete will removed if i can ask?

sorry if i give no reation will the design of the X delete will removed if i can ask?

Robert Guetzkow commented

2021-05-23 13:18:58 +02:00

@Das_Nicolaj We won't be implementing any changes if it's not apparent what the problem is. Please answer the following questions:

Step by step, what were the actions you've taken in Blender?
What files or directories were you trying to delete?
What did you mean by "look at the Windows folder"?
How have you checked that the file or directory is not moved to the recycling bin?

All files and directories deleted in the file browser should be moved to the recycling bin when using a Blender version after commit 98dfb4dd1c.

@Das_Nicolaj We won't be implementing any changes if it's not apparent what the problem is. Please answer the following questions: - Step by step, what were the actions you've taken in Blender? - What files or directories were you trying to delete? - What did you mean by "look at the Windows folder"? - How have you checked that the file or directory is not moved to the recycling bin? All files and directories deleted in the file browser should be moved to the recycling bin when using a Blender version after commit 98dfb4dd1c.

Nicolaj Hazendonk commented

2021-05-24 13:44:24 +02:00

I try to delete a folder with images from my work and it still there

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender Delete file | problem #88131