GPencil: Shortcuts in Draw Mode are hardcoded #88171

New Issue

Falk David · 2021-05-10T11:18:04+02:00

Falk David commented

2021-05-10 11:18:04 +02:00

Multiple keys in the gpencil_draw_modal function are hardcoded and (some) don't show up in the info bar. This makes it impossible for the user to know what certain keys do as well as impossible to change them in the keymap. All of those keys should be in the keymap with the default keys set as they are now.

Here is a list of these (hardcoded) shortcuts:

{key Enter}, {key Pad_Enter}, {key Esc}, {key Space}, {key Ctrl Z} (?): Confirm
{key Mousewheel_Up}, {key Pad_Plus}: Increase size of eraser
{key Mousewheel_Down}, {key Pad_Minus}: Decrease size of eraser
{key O}: Set center of guide
{key V}: Turn off speed guide
{key M}: Alternate or flip guide direction
{key L}: Turn on line guide; {key Ctrl L}: Turn on line guide with angle = 0; {key Alt L}: Turn on line guide with last angle
{key C}: Turn on circular guide
{key K}: Turn line guide clockwise
{key J}: Turn line guide anti-clockwise

Multiple keys in the `gpencil_draw_modal` function are hardcoded and (some) don't show up in the info bar. This makes it impossible for the user to know what certain keys do as well as impossible to change them in the keymap. All of those keys should be in the keymap with the default keys set as they are now. Here is a list of these (hardcoded) shortcuts: - {key Enter}, {key Pad_Enter}, {key Esc}, {key Space}, {key Ctrl Z} (?): Confirm - {key Mousewheel_Up}, {key Pad_Plus}: Increase size of eraser - {key Mousewheel_Down}, {key Pad_Minus}: Decrease size of eraser - {key O}: Set center of guide - {key V}: Turn off speed guide - {key M}: Alternate or flip guide direction - {key L}: Turn on line guide; {key Ctrl L}: Turn on line guide with angle = 0; {key Alt L}: Turn on line guide with last angle - {key C}: Turn on circular guide - {key K}: Turn line guide clockwise - {key J}: Turn line guide anti-clockwise

Falk David self-assigned this 2021-05-10 11:18:04 +02:00

Falk David commented

2021-05-10 11:18:04 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Falk David commented

2021-05-10 11:18:04 +02:00

Added subscribers: @filedescriptor, @antoniov, @pepe-school-land, @mendio

Antonio Vazquez commented

2021-05-10 16:31:36 +02:00

B key must be removed...we have the I menu for that.

`B` key must be removed...we have the `I` menu for that.

Antonio Vazquez commented

2021-05-10 16:33:26 +02:00

I'm going to remove Bkey new frame.

I'm going to remove `B`key new frame.

Falk David commented

2021-05-10 16:46:20 +02:00

@antoniov Thanks!

Antonio Vazquez commented

2021-05-11 21:05:18 +02:00

Maybe I miss something, but AFAIK the keymaps are used to invoke an operator with a group of parameters, but these keymaps are used inside the Modal loop of the operator, so the operator is already running and cannot be called again, so I don't see how define the keymaps, except something I don't know exist in the keymap API.

Antonio Vazquez commented

2021-05-11 21:06:18 +02:00

@mendio commented me that maybe we can reduce these functionality and remove some keymaps.

Matias Mendiola commented

2021-05-11 21:37:09 +02:00

Besides that they are hardcoded, IMO there are excessive shortcuts assigned to turn on Guides (L, CTRL+L, ALT+L and C) it should be enough to have just only one shortcut to toggle ON/OFF the use of the guides in general, there is no need to use precious key shortcuts to turn on every Guide type.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPencil: Shortcuts in Draw Mode are hardcoded #88171