Blender file browser replaces dot with underscore #88193

New Issue

Daniel Salazar · 2021-05-11T08:05:17+02:00

Daniel Salazar commented

2021-05-11 08:05:17 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.27

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-05-08 19:53, hash: 9569a522f2
Worked: Never

Short description of error
The renderfarm service I'm using decides to use a dot in the middle of naming the frames. It's stupid but it is what it is and I don't have control over it.

Try to set the render path like this

As soon as you press enter it decides to rename like this

Blender keeps changing the dot for an underscore but only on windows, on linux it leaves the dot alone!

Exact steps for others to reproduce the error

On a Windows machine:

Invoke file open dialog
Input filename test.
Filename will be changed to test_

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1080 with Max-Q Design/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.27 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-05-08 19:53, hash: `9569a522f2` Worked: Never **Short description of error** The renderfarm service I'm using decides to use a dot in the middle of naming the frames. It's stupid but it is what it is and I don't have control over it. ![image.png](https://archive.blender.org/developer/F10078283/image.png) Try to set the render path like this ![image.png](https://archive.blender.org/developer/F10078285/image.png) As soon as you press enter it decides to rename like this ![image.png](https://archive.blender.org/developer/F10078290/image.png) Blender keeps changing the dot for an underscore but only on windows, on linux it leaves the dot alone! **Exact steps for others to reproduce the error** On a **Windows** machine: - Invoke file open dialog - Input filename `test.` Filename will be changed to `test_`

Daniel Salazar commented

2021-05-11 08:05:17 +02:00

Added subscriber: @zanqdo

Richard Antalik commented

2021-05-11 18:21:25 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-05-11 18:21:25 +02:00

Changed status from 'Needs Triage' to: 'Resolved'

Richard Antalik closed this issue

2021-05-11 18:21:25 +02:00

Richard Antalik self-assigned this 2021-05-11 18:21:25 +02:00

Richard Antalik commented

2021-05-11 18:21:25 +02:00

This is by design. All filenames are handled so they don't include forbidden characters or equal to forbidden names.

Code says On Windows, it also ensures there is no '.' (dot char) at the end of the file, this can lead to issues...
I can't think myself of such issues, but this doesn't change the fact that this is intended behavior and not a bug.

Since this tracker is only for bugs I will close this report. Thanks for reporting anyway.

This is by design. All filenames are handled so they don't include forbidden characters or equal to forbidden names. Code says `On Windows, it also ensures there is no '.' (dot char) at the end of the file, this can lead to issues...` I can't think myself of such issues, but this doesn't change the fact that this is intended behavior and not a bug. Since this tracker is only for bugs I will close this report. Thanks for reporting anyway.

Daniel Salazar commented

2021-05-11 21:42:08 +02:00

Changed status from 'Resolved' to: 'Needs Developer To Reproduce'

Daniel Salazar reopened this issue

2021-05-11 21:42:08 +02:00

Daniel Salazar commented

2021-05-11 21:42:08 +02:00

It is a mistake. The image sequence file path is just part of the name. it will NOT end with a dot since the sequence number and extension will be added and this causes no problem.

The problem is with filenames ENDING with a dot so this is restricting a perfectly valid filename in windows creating problems for some renderfarms

https://stackoverflow.com/questions/3926324/dot-in-file-name

It is a mistake. The image sequence file path is just part of the name. it will NOT end with a dot since the sequence number and extension will be added and this causes no problem. The problem is with filenames ENDING with a dot so this is restricting a perfectly valid filename in windows creating problems for some renderfarms https://stackoverflow.com/questions/3926324/dot-in-file-name

Richard Antalik commented

2021-05-12 16:23:37 +02:00

Added subscriber: @HooglyBoogly

Richard Antalik commented

2021-05-12 16:23:37 +02:00

I haven't explained myself well enough. When you enter filename in file browser it will try to make sure that filename is correct. It does that by checking it with one function, that does number of checks. Trailing dot is only one of them. Problem is, that file browser don't know what this string will be used for, it will do the same for directories or even if it is only part of filename.

I don't think, that this could be resolved easily These checks would have to be broken up, and appropriate flags would have to be passed, that would imply that here trailing dot may be safe.

@HooglyBoogly Can you share your opinion?

I haven't explained myself well enough. When you enter filename in file browser it will try to make sure that filename is correct. It does that by checking it with one function, that does number of checks. Trailing dot is only one of them. Problem is, that file browser don't know what this string will be used for, it will do the same for directories or even if it is only part of filename. I don't think, that this could be resolved easily These checks would have to be broken up, and appropriate flags would have to be passed, that would imply that here trailing dot may be safe. @HooglyBoogly Can you share your opinion?

Daniel Salazar commented

2021-05-12 22:39:37 +02:00

Yeah it's kinda annoying and I'm coming here from a real world problem where this is making trouble so maybe there's a smarter solution @HooglyBoogly

Hans Goudey commented

2021-05-18 16:06:22 +02:00

Later on in that same function, the code even recognizes that this could be a problem.

This means it will also catch 'valid' names like 'aux.foo.bar', but should be enough for us! */

I think that's what's happening here anyway. Anyway, it seems like this is a valid bug.

Later on in that same function, the code even recognizes that this could be a problem. ``` This means it will also catch 'valid' names like 'aux.foo.bar', but should be enough for us! */ ``` I think that's what's happening here anyway. Anyway, it seems like this is a valid bug.

Richard Antalik commented

2021-05-25 02:59:35 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Richard Antalik commented

2021-05-25 02:59:35 +02:00

In #88193#1162319, @HooglyBoogly wrote:
Later on in that same function, the code even recognizes that this could be a problem.
This means it will also catch 'valid' names like 'aux.foo.bar', but should be enough for us! */

That comment applies only for forbidden names, not trailing dot.

I will confirm this if you think this shouldn't happen if file browser.

> In #88193#1162319, @HooglyBoogly wrote: > Later on in that same function, the code even recognizes that this could be a problem. > ``` > This means it will also catch 'valid' names like 'aux.foo.bar', but should be enough for us! */ > ``` That comment applies only for forbidden names, not trailing dot. I will confirm this if you think this shouldn't happen if file browser.

Richard Antalik removed their assignment 2021-05-25 03:05:36 +02:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender file browser replaces dot with underscore #88193