Visually broken long vertical near reroute point. Longer route → larger gap. #89282

Closed
opened 2021-06-19 06:44:53 +02:00 by Vyacheslav Kobozev · 18 comments

System Information
Operating system: Windows-8.1-6.3.9600-SP0 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 375.70

Blender Version
Broken: since 2.83.9 and later, including 3.0
Worked: 2.79b

Short description of error
How it looks:
{F10181058 size=full}

How it should:
{F10181064 size=full}

2021-06-19_07-33-32.mp4

2021-06-19_07-39-03.mp4

brr.blend

**System Information** Operating system: Windows-8.1-6.3.9600-SP0 64 Bits Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 375.70 **Blender Version** Broken: since 2.83.9 and later, including 3.0 Worked: 2.79b **Short description of error** How it looks: {[F10181058](https://archive.blender.org/developer/F10181058/20484734.png) size=full} How it should: {[F10181064](https://archive.blender.org/developer/F10181064/изображение.png) size=full} [2021-06-19_07-33-32.mp4](https://archive.blender.org/developer/F10181062/2021-06-19_07-33-32.mp4) [2021-06-19_07-39-03.mp4](https://archive.blender.org/developer/F10181061/2021-06-19_07-39-03.mp4) [brr.blend](https://archive.blender.org/developer/F10181068/brr.blend)

Added subscriber: @Vyach

Added subscriber: @Vyach
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Can confirm in that file, but cannot reproduce from scratch.
Also: as soon as I move it, the gap disappears.

Can confirm in that file, but cannot reproduce from scratch. Also: as soon as I move it, the gap disappears.

@lichtwerk I started with factory defaults and still can reproduce it.
try to duplicate reroute and move it straight down with {key Ctrl}

2021-06-22_21-33-17.mp4

@lichtwerk I started with factory defaults and still can reproduce it. try to duplicate reroute and move it straight down with {key Ctrl} [2021-06-22_21-33-17.mp4](https://archive.blender.org/developer/F10188250/2021-06-22_21-33-17.mp4)
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Yep, can get it now, too

Yep, can get it now, too
Member

@Vyach , still can not reproduce the problem (version: 2.93LTS)

Blender 2021-06-23 14-47-24.mp4.

@Vyach , still can not reproduce the problem (version: 2.93LTS) [Blender 2021-06-23 14-47-24.mp4](https://archive.blender.org/developer/F10190138/Blender_2021-06-23_14-47-24.mp4).

@PratikPB2123 you need to drag it vertically right after duplication, so reroutes should be aligned from start.

In your case they are not
изображение.png

@PratikPB2123 you need to drag it vertically right after duplication, so reroutes should be aligned from start. In your case they are not ![изображение.png](https://archive.blender.org/developer/F10190319/изображение.png)

Added subscriber: @SiboVG

Added subscriber: @SiboVG

Still able to reproduce this under 3.5.0 alpha (hash 81f425a36f). If two points have the same x- or y-coordinate, and are linked with a (curved) bezier curve, this issue appears. I can't reproduce the issue with noodle curving set to 0.

Interestingly, the issue appears to be in the final segment line of the bezier curve. You can see this in the video below, where the y-coordinate of the 2nd to last bezier point is the same as the point where the gap starts.

Screen Recording 2022-12-28 at 03.19.30.mov

Still able to reproduce this under 3.5.0 alpha (hash 81f425a36ff6). If two points have the same x- or y-coordinate, and are linked with a (curved) bezier curve, this issue appears. I can't reproduce the issue with noodle curving set to 0. Interestingly, the issue appears to be in the final segment line of the bezier curve. You can see this in the video below, where the y-coordinate of the 2nd to last bezier point is the same as the point where the gap starts. [Screen Recording 2022-12-28 at 03.19.30.mov](https://archive.blender.org/developer/F14096323/Screen_Recording_2022-12-28_at_03.19.30.mov)

The issue appears to be located in blender-git/blender/source/blender/gpu/shaders/gpu_shader_2D_nodelink_vert.glsl.

The issue appears to be located in `blender-git/blender/source/blender/gpu/shaders/gpu_shader_2D_nodelink_vert.glsl`.
Member

Added subscriber: @lone_noel

Added subscriber: @lone_noel
Member

When the endpoints of the links are horizontally or vertically aligned, the 'handle_offset' becomes 0 and two points of the bezier's control polygon overlap. I think this breaks the calculation of the bezier tangents in the shader.

While the issue is old I think I made it worse with 67308d73a4 since it's now is also visible on very long horizontal node links.

I can take a look over the weekend, unless you wanna try your hand at it @SiboVG. :)

When the endpoints of the links are horizontally or vertically aligned, the 'handle_offset' becomes 0 and two points of the bezier's control polygon overlap. I think this breaks the calculation of the bezier tangents in the shader. While the issue is old I think I made it worse with 67308d73a4 since it's now is also visible on very long horizontal node links. I can take a look over the weekend, unless you wanna try your hand at it @SiboVG. :)

Added subscriber: @ravikul-rao

Added subscriber: @ravikul-rao

i am new here ,like absoultely fresh and new , cani i get started on this as my first issue ? with you guys

i am new here ,like absoultely fresh and new , cani i get started on this as my first issue ? with you guys

Sure @lone_noel, you or @ravikul-rao can take this issue, I've been staring at it for too long now :).

Sure @lone_noel, you or @ravikul-rao can take this issue, I've been staring at it for too long now :).
Member

This is a good issue to start with, so give it a shot @ravikul-rao :)

If you haven't already, maybe check out the Developer Intro and the page about contributing code on the wiki.
If you get stuck on something feel free to ask over on blender.chat - you can also DM me there. Good luck!

This is a good issue to start with, so give it a shot @ravikul-rao :) If you haven't already, maybe check out the [Developer Intro](https:*wiki.blender.org/wiki/Developer_Intro/Overview) and the page about [contributing code](https:*wiki.blender.org/wiki/Process/Contributing_Code) on the wiki. If you get stuck on something feel free to ask over on [blender.chat](https://blender.chat/channel/blender-coders) - you can also DM me there. Good luck!
Philipp Oeser removed the
Interest
Nodes & Physics
label 2023-02-10 08:44:47 +01:00
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2023-05-12 20:36:01 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#89282
No description provided.