"Edit Mesh: partial updates" related crash in add-on #89289

Closed
opened 2021-06-19 16:31:57 +02:00 by MaybeLamia · 6 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 780 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.27

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-06-18 21:33, hash: f9aea19d98

Caused by c2fa36999f

Short description of error
Using an the operation connect spread in an addon is causing an EXCEPTION_ACCESS_VIOLATION.

blender.crash.txt

Stack trace:
blender.exe         :0x00007FF7A109EC60  blender::deg::deg_graph_flush_updates
blender.exe         :0x00007FF7A1084AA0  DEG_evaluate_on_refresh
blender.exe         :0x00007FF79C983790  scene_graph_update_tagged
blender.exe         :0x00007FF79CB61510  wm_event_do_notifiers
blender.exe         :0x00007FF79CB4B550  WM_main
blender.exe         :0x00007FF79C7E2ED0  main
blender.exe         :0x00007FF7A16421A8  __scrt_common_main_seh
KERNEL32.DLL        :0x00007FFEEB937020  BaseThreadInitThunk
ntdll.dll           :0x00007FFEECA62630  RtlUserThreadStart

Exact steps for others to reproduce the error

  • Download Forgotten Tools
  • use Connect spread on 2+ edges
  • go to operation popup menu increase the cuts.
**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 780 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.27 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-06-18 21:33, hash: `f9aea19d98` Caused by c2fa36999f **Short description of error** Using an the operation connect spread in an addon is causing an EXCEPTION_ACCESS_VIOLATION. [blender.crash.txt](https://archive.blender.org/developer/F10181562/blender.crash.txt) ``` Stack trace: blender.exe :0x00007FF7A109EC60 blender::deg::deg_graph_flush_updates blender.exe :0x00007FF7A1084AA0 DEG_evaluate_on_refresh blender.exe :0x00007FF79C983790 scene_graph_update_tagged blender.exe :0x00007FF79CB61510 wm_event_do_notifiers blender.exe :0x00007FF79CB4B550 WM_main blender.exe :0x00007FF79C7E2ED0 main blender.exe :0x00007FF7A16421A8 __scrt_common_main_seh KERNEL32.DLL :0x00007FFEEB937020 BaseThreadInitThunk ntdll.dll :0x00007FFEECA62630 RtlUserThreadStart ``` <video src="https://archive.blender.org/developer/F10181567/2021-06-20_00-26-23.mp4" controls></video> **Exact steps for others to reproduce the error** - Download [Forgotten Tools ](https://dl.dropbox.com/s/adovx8xpfm2xdds/forgotten_tools_0_5_0.zip) - use Connect spread on 2+ edges - go to operation popup menu increase the cuts.
Author

Added subscriber: @MaybeLamia

Added subscriber: @MaybeLamia

Added subscriber: @chemicalcrux

Added subscriber: @chemicalcrux

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Running this with a debug build fails an assertion:

BLI_assert failed: D:\blender-git\blender\source\blender\blenkernel\intern\editmesh.c:182, BKE_editmesh_looptri_calc_with_partial_ex(), at 'em->tottri == poly_to_tri_count(em->bm->totface, em->bm->totloop)'

If I get rid of the asserts, a heap overflow occurs.

SUMMARY: AddressSanitizer: heap-buffer-overflow D:\blender-git\blender\source\blender\bmesh\intern\bmesh_mesh_tessellate.c:145 in bmesh_calc_tessellation_for_face_impl
Shadow bytes around the buggy address:
  0x051d4f4d1f10: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x051d4f4d1f20: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x051d4f4d1f30: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa
  0x051d4f4d1f40: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
  0x051d4f4d1f50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x051d4f4d1f60: 00 00 00 00 00 00 00 00 00 00 00 00 00[fa]fa fa
  0x051d4f4d1f70: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
  0x051d4f4d1f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x051d4f4d1f90: 00 00 00 00 00 00 00 00 00 00 00 00 00 fa fa fa
  0x051d4f4d1fa0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x051d4f4d1fb0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
Running this with a debug build fails an assertion: ``` BLI_assert failed: D:\blender-git\blender\source\blender\blenkernel\intern\editmesh.c:182, BKE_editmesh_looptri_calc_with_partial_ex(), at 'em->tottri == poly_to_tri_count(em->bm->totface, em->bm->totloop)' ``` If I get rid of the asserts, a heap overflow occurs. ``` SUMMARY: AddressSanitizer: heap-buffer-overflow D:\blender-git\blender\source\blender\bmesh\intern\bmesh_mesh_tessellate.c:145 in bmesh_calc_tessellation_for_face_impl Shadow bytes around the buggy address: 0x051d4f4d1f10: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x051d4f4d1f20: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x051d4f4d1f30: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa 0x051d4f4d1f40: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00 0x051d4f4d1f50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x051d4f4d1f60: 00 00 00 00 00 00 00 00 00 00 00 00 00[fa]fa fa 0x051d4f4d1f70: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00 0x051d4f4d1f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x051d4f4d1f90: 00 00 00 00 00 00 00 00 00 00 00 00 00 fa fa fa 0x051d4f4d1fa0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x051d4f4d1fb0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd ```

This was introduced in c2fa36999f. The commit before it, 00073651d4, does not cause an assertion failure or a crash.

It is possible that this is just a problem with the add-on, of course -- it could be holding onto old, invalid data.

This was introduced in c2fa36999f. The commit before it, 00073651d4, does not cause an assertion failure or a crash. It is possible that this is just a problem with the add-on, of course -- it could be holding onto old, invalid data.
Robert Guetzkow changed title from EXCEPTION_ACCESS_VIOLATION from addon. to BMesh tesselate related crash in add-on 2021-06-19 20:08:58 +02:00
Robert Guetzkow changed title from BMesh tesselate related crash in add-on to Mesh related crash in add-on 2021-06-19 20:09:25 +02:00
Philipp Oeser removed the
Interest
Modeling
label 2023-02-09 15:28:23 +01:00
Philipp Oeser added the
Interest
Python API
label 2024-03-08 15:15:01 +01:00
Philipp Oeser changed title from Mesh related crash in add-on to "Edit Mesh: partial updates" related crash in add-on 2024-03-08 15:15:36 +01:00
Member

This is still crashing in current main.

Even though this involves an Addon, it is not overwhelmingly complex, we have a culprit commit that caused this already and it is easy to reproduce. So will dare setting this to High prio

@ideasman42 , @mano-wii : mind checking?

This is still crashing in current main. Even though this involves an Addon, it is not overwhelmingly complex, we have a culprit commit that caused this already and it is easy to reproduce. So will dare setting this to High prio @ideasman42 , @mano-wii : mind checking?
Philipp Oeser added
Priority
High
and removed
Priority
Normal
labels 2024-03-08 15:15:53 +01:00
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2024-03-08 20:43:51 +01:00
Hans Goudey added
Type
Bug
and removed
Type
Report
labels 2024-03-08 20:51:02 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#89289
No description provided.