Slowdown of Adjust Last Operation panel after changing remesh modifier settings #89428

New Issue

Garek · 2021-06-25T11:43:39+02:00

Garek commented

2021-06-25 11:43:39 +02:00

System Information
Operating system: Windows-7
Blender Version
Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: 02948a2cab
Worked: (newest version of Blender that worked as expected)

Short description of error
Changing Octree Depth or voxel size of remesh modifier results in drop of performance of any action in Adjust Last Operation panel, most noticable at Octree Depth 5 or more.

Exact steps for others to reproduce the error

Open .blend file
Change Octree Depth or voxel size. You may lower it, increase or even decrease and increase to where it was.
Do action that will show you Adjust Last Operation panel such as: move cube with G, rotate with R or add another object such as UV sphere.
Tweak operation via Adjust Last Operation panel to measure performance.
Do another action and tweak it - performance is much better.
I can't confirm it on 2.93 or higher since they dropped Windows 7 support.
remesher octree depth.avi
Octree Depth test file.blend

**System Information** Operating system: Windows-7 **Blender Version** Broken: version: 2.92.0, branch: master, commit date: 2021-02-24 16:25, hash: `02948a2cab` Worked: (newest version of Blender that worked as expected) **Short description of error** Changing Octree Depth or voxel size of remesh modifier results in drop of performance of any action in Adjust Last Operation panel, most noticable at Octree Depth 5 or more. **Exact steps for others to reproduce the error** 1. Open .blend file 2. Change Octree Depth or voxel size. You may lower it, increase or even decrease and increase to where it was. 3. Do action that will show you Adjust Last Operation panel such as: move cube with G, rotate with R or add another object such as UV sphere. 4. Tweak operation via Adjust Last Operation panel to measure performance. 5. Do another action and tweak it - performance is much better. I can't confirm it on 2.93 or higher since they dropped Windows 7 support. [remesher octree depth.avi](https://archive.blender.org/developer/F10201850/remesher_octree_depth.avi) [Octree Depth test file.blend](https://archive.blender.org/developer/F10201965/Octree_Depth_test_file.blend)

Garek commented

2021-06-25 11:43:39 +02:00

Added subscriber: @Garek

Philipp Oeser commented

2021-06-25 12:14:35 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-06-25 12:14:35 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2021-06-25 12:14:35 +02:00

I think this is essentially the same issue as #78171 (Adjust Last Operation: Other changes outside that panel are reverted back automatically)

Having the Adjust Last Operation panel open, then tweaking some other settings (e.g. in the Properties Editor) will revert the stuff done in between (causing the slowdown).
Can you confirm this is only an issue when you tweak remesh settings with Adjust Last Operation panel still open?

I think this is essentially the same issue as #78171 (Adjust Last Operation: Other changes outside that panel are reverted back automatically) Having the Adjust Last Operation panel open, then tweaking some other settings (e.g. in the Properties Editor) will revert the stuff done in between (causing the slowdown). Can you confirm this is only an issue when you tweak remesh settings with `Adjust Last Operation` panel still open?

Garek commented

2021-06-25 13:08:21 +02:00

In #89428#1182575, @lichtwerk wrote:
Having the Adjust Last Operation panel open, then tweaking some other settings (e.g. in the Properties Editor) will revert the stuff done in between (causing the slowdown).

I don't see how it would cause slowdown when you change setting to lower level or to lower level and back to original. Besides in this case there are cases with no revert (see below)

In #89428#1182575, @lichtwerk wrote:
Can you confirm this is only an issue when you tweak remesh settings with Adjust Last Operation panel still open?

If you saying about "if panel open prior to changing settings or not" then answer is: even prior to triggering panel if you don't click prior to operation.
See video below. In first case I should click on cube prior to moving cube, no change in performance. But if I use hotkey to add sphere (or if I selected cube prior to moving it) there is performance drop. In both cases there are no Adjust Last Operation panel active.
Click or not to click that is the question.avi
At first I thought you ask about whether it's only with remesh modifier so I checked that first. I tested with subdivided default cude with array modifier and it's same behavior.
But changing object properties (location, scale) and then adjusting via panel does not trigger any noticable slowdown. Perhaps this operation is too light but I don't know then which is excluding modifiers.

Also to clarify: it's not just that this panel open, you can change operation. So if you move cube (trigger appearance of panel), change modifier settings and try to adjust via panel, your settings will revert (bug you mentioned) and you'll get slowdown. But you can move cube, change modifier, then add sphere (or move again, I guess it counts as new operation) and then adjust, you'll get only slowdown without any revert.

I would assume this is very similar bug that sits in the same broken system but still should be listed separate. I think it's better some more knowledgeable dev can make correct judgement. But prior to that confirm whether latest version have that since I unfortunately can't do that.

> In #89428#1182575, @lichtwerk wrote: > Having the Adjust Last Operation panel open, then tweaking some other settings (e.g. in the Properties Editor) will revert the stuff done in between (causing the slowdown). I don't see how it would cause slowdown when you change setting to lower level or to lower level and back to original. Besides in this case there are cases with no revert (see below) > In #89428#1182575, @lichtwerk wrote: > Can you confirm this is only an issue when you tweak remesh settings with `Adjust Last Operation` panel still open? If you saying about "if panel open prior to changing settings or not" then answer is: even prior to triggering panel if you don't click prior to operation. See video below. In first case I should click on cube prior to moving cube, no change in performance. But if I use hotkey to add sphere (or if I selected cube prior to moving it) there is performance drop. In both cases there are no `Adjust Last Operation` panel active. [Click or not to click that is the question.avi](https://archive.blender.org/developer/F10202035/Click_or_not_to_click_that_is_the_question.avi) At first I thought you ask about whether it's only with remesh modifier so I checked that first. I tested with subdivided default cude with array modifier and it's same behavior. But changing object properties (location, scale) and then adjusting via panel does not trigger any noticable slowdown. Perhaps this operation is too light but I don't know then which is excluding modifiers. Also to clarify: it's not just that this panel open, you can change operation. So if you move cube (trigger appearance of panel), change modifier settings and try to adjust via panel, your settings will revert (bug you mentioned) and you'll get slowdown. But you can move cube, change modifier, then add sphere (or move again, I guess it counts as new operation) and then adjust, you'll get only slowdown *without any revert*. I would assume this is very similar bug that sits in the same broken system but still should be listed separate. I think it's better some more knowledgeable dev can make correct judgement. But prior to that confirm whether latest version have that since I unfortunately can't do that.

Philipp Oeser commented

2021-06-25 14:36:01 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-06-25 14:36:01 +02:00

In #89428#1182627, @Garek wrote:
I don't see how it would cause slowdown when you change setting to lower level or to lower level and back to original.

If the undo/revert takes places, this is re-evaluating the modifier (twice even I think), thus the slowdown.

But if I use hotkey to add sphere there is performance drop.

Can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this

(or if I selected cube prior to moving it) there is performance drop.

I am having trouble reproducing that, maybe you can even get better repro steps?

you can move cube, change modifier, then add sphere and then adjust, you'll get only slowdown without any revert.

Same as above, can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this

you can move cube, change modifier, then move again (I guess it counts as new operation) and then adjust, you'll get only slowdown without any revert.

Yes, can repro that as well now

I think it's better some more knowledgeable dev can make correct judgement. But prior to that confirm whether latest version have that since I unfortunately can't do that.

Sound offensive, why? I am just trying to prepare the report as good as possible for a dev to look at, Anyhow, can only speak for the stuff I can actually reproduce, but yes, this happens in 2.93 and master as well...

> In #89428#1182627, @Garek wrote: > I don't see how it would cause slowdown when you change setting to lower level or to lower level and back to original. If the undo/revert takes places, this is re-evaluating the modifier (twice even I think), thus the slowdown. > But if I use hotkey to add sphere there is performance drop. Can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this > (or if I selected cube prior to moving it) there is performance drop. I am having trouble reproducing that, maybe you can even get better repro steps? > you can move cube, change modifier, then add sphere and then adjust, you'll get only slowdown without any revert. Same as above, can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this > you can move cube, change modifier, then move again (I guess it counts as new operation) and then adjust, you'll get only slowdown without any revert. Yes, can repro that as well now >I think it's better some more knowledgeable dev can make correct judgement. But prior to that confirm whether latest version have that since I unfortunately can't do that. Sound offensive, why? I am just trying to prepare the report as good as possible for a dev to look at, Anyhow, can only speak for the stuff I can actually reproduce, but yes, this happens in 2.93 and master as well...

Garek commented

2021-06-25 16:00:53 +02:00

In #89428#1182666, @lichtwerk wrote:
Can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this
Same as above, can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this

I don't think it's quite the same. I mean, you're probably right to say it's about re-evaluating the modifier (I am by no means programmer so I can't say things for sure), it's just I think it might need different bugfix since in one case slowdown is persisted and in the other not. Just like pipe can break in two places - fundamentaly problem is same in that water is leaking and flooding neighbors below but in one case pipe was corruded by rust and in the other joints weren't set up right.

I am having trouble reproducing that, maybe you can even get better repro steps?

Select cube with remesh modifier on it (preferably with Octree Depth on 5-6)
Don't move it with G (or else you'll trigger Adjust Last Operation panel appearing)
Change Octree Depth
Move cube with G
Use Adjust Last Operation panel to see performance drop

Sound offensive, why? I am just trying to prepare the report as good as possible for a dev to look at

Sorry if it appeared that way, didn't mean to in any way. Undo stuff is tricky AFAIK from Bastien commit messages (when he did Scene Editing in Object Mode project) and I think conditions for this potential bug to appear is unique enough to not merge it with other report before some dev can take a closer look at it.

> In #89428#1182666, @lichtwerk wrote: > Can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this > Same as above, can repro that, confirmed #85756 (Adjust Last Operation panel is slow (some Undo/Redo happening?)) for this I don't think it's quite the same. I mean, you're probably right to say it's about re-evaluating the modifier (I am by no means programmer so I can't say things for sure), it's just I think it might need different bugfix since in one case slowdown is persisted and in the other not. Just like pipe can break in two places - fundamentaly problem is same in that water is leaking and flooding neighbors below but in one case pipe was corruded by rust and in the other joints weren't set up right. > I am having trouble reproducing that, maybe you can even get better repro steps? 1. Select cube with remesh modifier on it (preferably with Octree Depth on 5-6) 2. **Don't** move it with G (or else you'll trigger `Adjust Last Operation` panel appearing) 3. Change Octree Depth 4. Move cube with G 5. Use `Adjust Last Operation` panel to see performance drop > Sound offensive, why? I am just trying to prepare the report as good as possible for a dev to look at Sorry if it appeared that way, didn't mean to in any way. Undo stuff is tricky AFAIK from Bastien commit messages (when he did `Scene Editing in Object Mode` project) and I think conditions for this potential bug to appear is unique enough to not merge it with other report before some dev can take a closer look at it.

Bastien Montagne commented

2021-09-30 16:15:50 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2021-09-30 16:15:50 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Archived'

Bastien Montagne closed this issue

2021-09-30 16:15:50 +02:00

Bastien Montagne commented

2021-09-30 16:15:50 +02:00

Thanks for the report, but this is more like a general known limitation/improvement potential for undo system and depsgraph (re)evaluation. Definitely not a bug.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Slowdown of Adjust Last Operation panel after changing remesh modifier settings #89428