Freestyle parameter_editor.process crashes Blender if trying to render without any Line Style defined #89774

New Issue

Serhiy · 2021-07-10T13:17:32+02:00

Serhiy commented

2021-07-10 13:17:32 +02:00

Blender Version
2.93.1
(2.93.2 doesn't have any relevant changes in that file though so I don't expect it to be fixed there either)

Short description of error
Freestyle parameter_editor.process crashes Blender if trying to render without any Line Style defined.

Exact steps for others to reproduce the error

Open .blend file
Enable Properties ‣ Render ‣ Freestyle.

Try rendering an image.

# Blender 2.93.1, Commit date: 2021-06-22 05:57, Hash 1b8d33b18c2f
Python: Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/snap/blender/206/2.93/scripts/freestyle/modules/parameter_editor.py", line 1329, in process
    if linestyle.use_chaining:
AttributeError: 'NoneType' object has no attribute 'use_chaining'

Suggested workaround

A simple solution could be something along the lines of

if linestyle is None:
    return

but I'm not sure if just return is enough there to cleanly stop early. Adding some warning could also be beneficial.

lib_32px.blend
lib_32px.crash.txt

**Blender Version** 2.93.1 (2.93.2 doesn't have any relevant changes in that file though so I don't expect it to be fixed there either) **Short description of error** Freestyle parameter_editor.process crashes Blender if trying to render without any Line Style defined. **Exact steps for others to reproduce the error** - Open .blend file - Enable `Properties ‣ Render ‣ Freestyle`. # Try rendering an image. ``` # Blender 2.93.1, Commit date: 2021-06-22 05:57, Hash 1b8d33b18c2f Python: Traceback (most recent call last): File "<string>", line 1, in <module> File "/snap/blender/206/2.93/scripts/freestyle/modules/parameter_editor.py", line 1329, in process if linestyle.use_chaining: AttributeError: 'NoneType' object has no attribute 'use_chaining' ``` **Suggested workaround** A simple solution could be something along the lines of ``` if linestyle is None: return ``` but I'm not sure if just `return` is enough there to cleanly stop early. Adding some warning could also be beneficial. [lib_32px.blend](https://archive.blender.org/developer/F10236042/lib_32px.blend) [lib_32px.crash.txt](https://archive.blender.org/developer/F10236031/lib_32px.crash.txt)

Serhiy commented

2021-07-10 13:17:32 +02:00

Added subscriber: @int-ua

Pratik Borhade commented

2021-07-12 15:44:06 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-07-12 15:44:06 +02:00

Can not reproduce here on windows. (2.93.2 9e64fd461a)

Make sure Freestyle Line Style is not defined in Properties ‣ View Layer ‣ Freestyle Line Style

Does that mean to remove line set (from View layer properties tab)?

Can not reproduce here on windows. (2.93.2 `9e64fd461a`) >Make sure Freestyle Line Style is not defined in Properties ‣ View Layer ‣ Freestyle Line Style Does that mean to remove line set (from View layer properties tab)?

Serhiy commented

2021-07-12 17:17:54 +02:00

In #89774#1190265, @PratikPB2123 wrote:
Does that mean to remove line set (from View layer properties tab)?

Yes, delete it.

> In #89774#1190265, @PratikPB2123 wrote: > Does that mean to remove line set (from View layer properties tab)? Yes, delete it.

Pratik Borhade commented

2021-07-13 15:11:47 +02:00

Thanks!
I am not able to recreate though with the current master build.

System Information

Graphics card : AMD Radeon(TM) 535 ATI Technologies .```

Thanks! I am not able to recreate though with the current master build. --- **System Information** ```Operating system : Windows-10-10.0.18362-SP0 64 Bits Graphics card : AMD Radeon(TM) 535 ATI Technologies .```

Serhiy commented

2021-07-13 18:46:18 +02:00

Yes, I cannot reproduce it too. parameter_editor.py didn't change but there were some other changes because it is now impossible to delete just the line style.

Yes, I cannot reproduce it too. `parameter_editor.py` didn't change but there were some other changes because it is now impossible to delete just the line style.

Pratik Borhade commented

2021-07-15 06:51:30 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Pratik Borhade commented

2021-07-15 06:51:30 +02:00

Yes, I cannot reproduce it too.

Do you mean the issue is fixed? if not then please add a short video to describe the steps

Please confirm if followed steps are correct in the video (not sure why rendered window it is not captured in screen recording)
Blender 2021-07-15 10-15-54.mp4

>Yes, I cannot reproduce it too. Do you mean the issue is fixed? if not then please add a short video to describe the steps Please confirm if followed steps are correct in the video (not sure why rendered window it is not captured in screen recording) [Blender 2021-07-15 10-15-54.mp4](https://archive.blender.org/developer/F10224642/Blender_2021-07-15_10-15-54.mp4)

Serhiy commented

2021-07-15 08:47:16 +02:00

Yes, it is fixed in master and the steps are correct (because the OP steps are impossible on master), thank you.

Pratik Borhade commented

2021-07-15 08:49:28 +02:00

Yes, it is fixed in master and the steps are correct

Thanks for clarifying. Does this still happen with 2.93 recent build (https://builder.blender.org/download/daily)?

>Yes, it is fixed in master and the steps are correct Thanks for clarifying. Does this still happen with 2.93 recent build (https://builder.blender.org/download/daily)?

Pratik Borhade commented

2021-07-23 07:43:19 +02:00

Does this still happen with 2.93 recent build (https://builder.blender.org/download/daily)?

please check if 2.93 LTS also fixes the issue. Else it needs to be backported.

>Does this still happen with 2.93 recent build (https://builder.blender.org/download/daily)? please check if 2.93 LTS also fixes the issue. Else it needs to be backported.

Serhiy commented

2021-07-24 12:43:07 +02:00

It's not just the lack of Line Style. I've tried to reproduce it on the default cube file and I can't even on 2.93.1.

I use these files as templates and they have the problem:

https://github.com/int-ua/blender-pixelart/blob/master/lib_32px.blend
https://github.com/int-ua/blender-pixelart/blob/master/template_item_32px.blend

Just enable the Freestyle and try rendering. It crashes both on latest daily build and 2.93.1. I wasn't testing daily with these files previously under false assumption that only removing the line style is enough.

It's not just the lack of Line Style. I've tried to reproduce it on the default cube file and I can't even on 2.93.1. I use these files as templates and they have the problem: https://github.com/int-ua/blender-pixelart/blob/master/lib_32px.blend https://github.com/int-ua/blender-pixelart/blob/master/template_item_32px.blend Just enable the Freestyle and try rendering. It crashes both on latest daily build and 2.93.1. I wasn't testing daily with these files previously under false assumption that only removing the line style is enough.

Pratik Borhade commented

2021-07-24 17:27:44 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Pratik Borhade commented

2021-07-24 17:27:44 +02:00

Thanks for the file. I can reproduce the crash in 3.0.0 (118803893e) and 2.93.2 (9e64fd461a)
lib_32px.crash.txt

Thanks for the file. I can reproduce the crash in 3.0.0 (`118803893e`) and 2.93.2 (`9e64fd461a`) [lib_32px.crash.txt](https://archive.blender.org/developer/F10236031/lib_32px.crash.txt)

Philipp Oeser added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Freestyle parameter_editor.process crashes Blender if trying to render without any Line Style defined #89774

Try rendering an image.