geometry_attributes_poll issues #90026

New Issue

Vincent Blankfield · 2021-07-21T16:58:04+02:00

2021-07-21 16:58:04 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-21 13:14, hash: 22bef356ae
Worked: none

Short description of error

Adding/removing attributes in edit mode is allowed but doesn't work.
Removing attributes is allowed when there are no attributes.

Exact steps for others to reproduce the error

Open Object Data Properties -> Attributes for the default cube.
Notice the - button is active while there are no attributes.
Tab into edit mode.
Add some attributes to the list.
Tab back to the object mode.
Notice that previously added attributes disappear.

Not sure if adding/removing attributes should be supported in edit mode, but while it doesn't work it shouldn't be allowed.

This patch will disable adding/removing attributes in edit mode, and removing when there are no attributes:
attribute_poll_min.diff

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-07-21 13:14, hash: `22bef356ae` Worked: none **Short description of error** - Adding/removing attributes in edit mode is allowed but doesn't work. - Removing attributes is allowed when there are no attributes. **Exact steps for others to reproduce the error** 1. Open `Object Data Properties -> Attributes` for the default cube. 2. Notice the `-` button is active while there are no attributes. 3. `Tab` into edit mode. 4. Add some attributes to the list. 5. Tab back to the object mode. 6. Notice that previously added attributes disappear. --- Not sure if adding/removing attributes should be supported in edit mode, but while it doesn't work it shouldn't be allowed. This patch will disable adding/removing attributes in edit mode, and removing when there are no attributes: [attribute_poll_min.diff](https://archive.blender.org/developer/F10232025/attribute_poll_min.diff)

Vincent Blankfield commented

2021-07-21 16:58:04 +02:00

Added subscriber: @VincentBlankfield

Philipp Oeser commented

2021-07-21 17:16:49 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-07-21 17:16:49 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2021-07-21 17:16:49 +02:00

Philipp Oeser commented

2021-07-21 17:16:49 +02:00

Can confirm (and thx for the patch!).

Think this should be supported in editmode, will check.

Can confirm (and thx for the patch!). Think this should be supported in editmode, will check.

Philipp Oeser commented

2021-07-21 18:45:43 +02:00

Made all polls consistent now (in regards to checking if there is something to remove at all) in D11990: Make polls for removing mesh data layers consistent.
Will check editmode tomorrow.

Made all polls consistent now (in regards to checking if there is something to remove at all) in [D11990: Make polls for removing mesh data layers consistent](https://archive.blender.org/developer/D11990). Will check editmode tomorrow.

Hans Goudey commented

2021-07-22 04:58:16 +02:00

Added subscriber: @HooglyBoogly