Pinning data (mesh, curve, grease pencil, lattice, particle system) makes certain tabs/options disappear (vertex groups, shapekeys facemaps) #90039

New Issue

Sarah Laufer · 2021-07-22T10:09:58+02:00

Sarah Laufer commented

2021-07-22 10:09:58 +02:00

System Information
Operating system: Microsoft 10
Graphics card:GeForce GTX 10606GB

Blender Version
Broken: 2.93
Worked: don't know

in the properties editor, in object data properties, the pin toggle hides vertex groups and shapekeys

Exact steps for others to reproduce the error

select default cube
go to properties editor
press object data properties tab
press the pin button

**System Information** Operating system: Microsoft 10 Graphics card:GeForce GTX 10606GB **Blender Version** Broken: 2.93 Worked: don't know **in the properties editor, in object data properties, the pin toggle hides vertex groups and shapekeys** **Exact steps for others to reproduce the error** - select default cube - go to properties editor - press object data properties tab - press the pin button

Sarah Laufer commented

2021-07-22 10:09:58 +02:00

Added subscriber: @feldlaufer-4

blender-admin commented

2021-07-22 10:09:58 +02:00

#102578 was marked as duplicate of this issue

blender-admin commented

2021-07-22 10:09:58 +02:00

#102009 was marked as duplicate of this issue

blender-admin commented

2021-07-22 10:09:58 +02:00

#98105 was marked as duplicate of this issue

blender-admin commented

2021-07-22 10:09:58 +02:00

#92034 was marked as duplicate of this issue

blender-admin commented

2021-07-22 10:09:58 +02:00

#91799 was marked as duplicate of this issue

Philipp Oeser commented

2021-07-22 10:16:29 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2021-07-22 10:16:29 +02:00

Philipp Oeser commented

2021-07-22 10:16:29 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-07-22 10:16:29 +02:00

Confirmed, will check

Philipp Oeser commented

2021-07-22 11:13:12 +02:00

Same is true for Face Maps.

When pinned, these panels look for an object in context (not a mesh) -- but when a mesh is pinned there is no object in context
Reason being:

Vertex groups are still tied to object (rather than mesh) from the python API side (even after 3b6ee8cee7 there is no mesh.vertex_groups)
Face Maps are still tied to object (rather than mesh) from the python API side
Shapekey python API is also partially tied to object (rather than mesh), see ob.active_shape_key / ob.use_shape_key_edit_mode / ob.show_only_shape_key

Also: even almost all operators acting on the stuff still visible atm. (UV Maps, Vertex Colors, Attributes, ...) are disfunctional (they are also polling for a context object rather than mesh).
So in essence, the whole object data properties tab in the Properties Editor is disfunctional when a mesh is pinned.
There is an exception though: the operators acting on Custom Split Normals work well with pinned meshes as they query ED_mesh_context(C) (rather than ED_object_context(C) and then getting the mesh from there)

So I assume this leaves us with following TODOs:

- tweak/add the python API to make relevant Vertex group / Shapekey / Face Maps stuff available from mesh (rather than object)
- make according operators get context mesh directly (rather than getting object first and then its data)

Same is true for Face Maps. When pinned, these panels look for an **object** in context (not a **mesh**) -- but when a mesh is pinned there is no **object** in context Reason being: - Vertex groups are still tied to **object** (rather than **mesh**) from the python API side (even after 3b6ee8cee7 there is no `mesh.vertex_groups`) - Face Maps are still tied to **object** (rather than **mesh**) from the python API side - Shapekey python API is also partially tied to **object** (rather than **mesh**), see `ob.active_shape_key` / `ob.use_shape_key_edit_mode` / `ob.show_only_shape_key` Also: even almost all operators acting on the stuff still visible atm. (`UV Maps`, `Vertex Colors`, `Attributes`, ...) are disfunctional (they are also polling for a **context object** rather than **mesh**). So in essence, the whole object data properties tab in the Properties Editor is disfunctional when a mesh is pinned. There is an exception though: the operators acting on `Custom Split Normals` work well with pinned meshes as they query `ED_mesh_context(C)` (rather than `ED_object_context(C)` and then getting the mesh from there) So I assume this leaves us with following TODOs: - - [x] tweak/add the python API to make relevant `Vertex group` / `Shapekey` / `Face Maps` stuff available from **mesh** (rather than **object**) - - [x] make according operators get context mesh directly (rather than getting object first and then its data)

Philipp Oeser removed their assignment 2021-07-22 11:21:17 +02:00

Philipp Oeser commented

2021-07-22 11:21:17 +02:00

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-07-22 11:21:17 +02:00

Eh, totally forgot that this is not only about mesh, but instead vertex groups / shapekeys can be on lattices, curves, etc...
So not sure if it is really worth tweaking the API that much (it would sort of have to be duplicated to all of those types...)
Also ED_mesh_context(C) would not be enough, we'd need to have ED_curve_context(C), ED_lattice_context(C) etc as well

Hm, I think this needs more thinking on my side and/or some input from module devs.

Eh, totally forgot that this is not only about mesh, but instead vertex groups / shapekeys can be on lattices, curves, etc... So not sure if it is really worth tweaking the API that much (it would sort of have to be duplicated to all of those types...) Also `ED_mesh_context(C)` would not be enough, we'd need to have `ED_curve_context(C),` `ED_lattice_context(C)` etc as well Hm, I think this needs more thinking on my side and/or some input from module devs.

Hans Goudey commented

2021-07-22 15:40:30 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-07-22 15:40:30 +02:00

Vertex Groups
I think the solution is to add a new API for vertex groups on meshes (without the object). It can work like the attribute API, so it can just take an ID and use the relevant functions like BKE_id_defgroup_list_get.

We would need that for mesh, grease pencil, and lattices.

Others

Shape keys will still be object based for the foreseeable future, as far as I can tell.
Face maps, honestly I don't even know why they're in Blender.
For other attributes, it seems the poll functions can be fixed.

**Vertex Groups** I think the solution is to add a new API for vertex groups on meshes (without the object). It can work like the attribute API, so it can just take an ID and use the relevant functions like `BKE_id_defgroup_list_get`. We would need that for mesh, grease pencil, and lattices. **Others** - Shape keys will still be object based for the foreseeable future, as far as I can tell. - Face maps, honestly I don't even know why they're in Blender. - For other attributes, it seems the poll functions can be fixed.

Philipp Oeser commented

2021-07-22 15:44:15 +02:00

In #90039#1194787, @HooglyBoogly wrote:

For other attributes, it seems the poll functions can be fixed.

poll and exec both need tweaks

> In #90039#1194787, @HooglyBoogly wrote: > - For other attributes, it seems the poll functions can be fixed. `poll` and `exec` both need tweaks

Philipp Oeser commented

2021-07-23 13:04:03 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Philipp Oeser commented

2021-07-23 13:04:03 +02:00

Would assume this is a Known Issue for now.

Philipp Oeser changed title from ~~toggle pin ID makes vertex groups and shapekeys tabs disappear~~ to Pinning data (mesh, curve, grease pencil, lattice) makes certain tabs disappear (vertex groups, shapekeys facemaps)

2021-07-23 13:07:00 +02:00

Pratik Borhade commented

2021-09-30 10:57:05 +02:00

Added subscribers: @ssoo, @PratikPB2123

Pratik Borhade commented

2022-05-14 19:56:28 +02:00

Added subscriber: @kursadk

Antonio Vazquez commented

2022-10-24 16:03:48 +02:00

Added subscribers: @Georgefly, @antoniov

Philipp Oeser changed title from ~~Pinning data (mesh, curve, grease pencil, lattice) makes certain tabs disappear (vertex groups, shapekeys facemaps)~~ to Pinning data (mesh, curve, grease pencil, lattice, particle system) makes certain tabs/options disappear (vertex groups, shapekeys facemaps)

2022-11-17 14:20:54 +01:00

Philipp Oeser commented

2022-11-17 14:21:07 +01:00

Added subscriber: @pseudoua

Faruk Ahmet commented

2022-12-17 23:35:07 +01:00

Added subscriber: @Kuboa

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Pinning data (mesh, curve, grease pencil, lattice, particle system) makes certain tabs/options disappear (vertex groups, shapekeys facemaps) #90039