The removal of "Recursion" in asset browser removes functionality. #90451

New Issue

Alaska · 2021-08-05T10:09:26+02:00

Alaska commented

2021-08-05 10:09:26 +02:00

System Information
Operating system: NA
Graphics card: NA

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-05 06:54, hash: f5acfd9c04
Worked: Prior to d8bf332f86 & ceb049133c

Description of error:
I'm not sure how a report like this is supposed to be handled. It's not a bug. But is a regression.

Prior to commit d8bf332f86 and ceb049133c there was an option in the top of the Asset Browser to change the level of recursion when the asset browser searches for files. Here's one of the places you could find it prior to the commits:

At the top of the Asset Browser select View -> Recursion and you can now select the level of Recursion.

This setting has since been removed which comes at a loss of functionality as the Assest Browser can no longer be configured to find assets inside folders. Technically this is fine, but I personally find this annoying as I sorted my assets into folders inside my asset browser directory, and now I can not access my assets in the asset browser without modifying the layout of my directory.

Here's an example of a directory tree like mine:

Asset Browser Directory (Pointed at via Blender User Preferences)
├── Materials from Website X (Folder)
│   ├── Brick 001.blend
│   └── Ground 001.blend
└── Materials from Website Y (Folder)
    ├── Tiles 001.html
    └── Woodfloor 001.html

I have created a patch that returns the functionality, but I'm not sure whether this is the route to go, or to instead allow the asset browser to recursively look inside "infinite" folders by default.

diff --git a/release/scripts/startup/bl_ui/space_filebrowser.py b/release/scripts/startup/bl_ui/space_filebrowser.py
index 9f70d26c71b..3827d69b5bf 100644
--- a/release/scripts/startup/bl_ui/space_filebrowser.py
+++ b/release/scripts/startup/bl_ui/space_filebrowser.py
@@ -592,6 +592,7 @@ class ASSETBROWSER_PT_display(asset_utils.AssetBrowserPanel, Panel):
             col = layout.column(heading="Columns", align=True)
             col.prop(params, "show_details_size", text="Size")
             col.prop(params, "show_details_datetime", text="Date")
+        layout.prop(params, "recursion_level", text="Recursions")
 
 
 class AssetBrowserMenu:
@@ -627,6 +628,7 @@ class ASSETBROWSER_MT_view(AssetBrowserMenu, Menu):
         layout.separator()
 
         layout.prop_menu_enum(params, "display_size")
+        layout.prop_menu_enum(params, "recursion_level")
 
         layout.separator()

**System Information** Operating system: NA Graphics card: NA **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-05 06:54, hash: `f5acfd9c04` Worked: Prior to d8bf332f86 & ceb049133c **Description of error:** I'm not sure how a report like this is supposed to be handled. It's not a bug. But is a regression. Prior to commit `d8bf332f86` and `ceb049133c` there was an option in the top of the `Asset Browser` to change the level of recursion when the asset browser searches for files. Here's one of the places you could find it prior to the commits: > At the top of the `Asset Browser` select `View -> Recursion` and you can now select the level of Recursion. This setting has since been removed which comes at a loss of functionality as the Assest Browser can no longer be configured to find assets inside folders. Technically this is fine, but I personally find this annoying as I sorted my assets into folders inside my asset browser directory, and now I can not access my assets in the asset browser without modifying the layout of my directory. Here's an example of a directory tree like mine: ``` Asset Browser Directory (Pointed at via Blender User Preferences) ├── Materials from Website X (Folder) │ ├── Brick 001.blend │ └── Ground 001.blend └── Materials from Website Y (Folder) ├── Tiles 001.html └── Woodfloor 001.html ``` I have created a patch that returns the functionality, but I'm not sure whether this is the route to go, or to instead allow the asset browser to recursively look inside "infinite" folders by default. ``` diff --git a/release/scripts/startup/bl_ui/space_filebrowser.py b/release/scripts/startup/bl_ui/space_filebrowser.py index 9f70d26c71b..3827d69b5bf 100644 --- a/release/scripts/startup/bl_ui/space_filebrowser.py +++ b/release/scripts/startup/bl_ui/space_filebrowser.py @@ -592,6 +592,7 @@ class ASSETBROWSER_PT_display(asset_utils.AssetBrowserPanel, Panel): col = layout.column(heading="Columns", align=True) col.prop(params, "show_details_size", text="Size") col.prop(params, "show_details_datetime", text="Date") + layout.prop(params, "recursion_level", text="Recursions") class AssetBrowserMenu: @@ -627,6 +628,7 @@ class ASSETBROWSER_MT_view(AssetBrowserMenu, Menu): layout.separator() layout.prop_menu_enum(params, "display_size") + layout.prop_menu_enum(params, "recursion_level") layout.separator() ```

Alaska commented

2021-08-05 10:09:26 +02:00

Added subscriber: @Alaska

Alaska commented

2021-08-05 10:11:10 +02:00

Added subscribers: @JulianEisel, @Jeroen-Bakker

Alaska commented

2021-08-05 10:11:10 +02:00

CC @JulianEisel and @Jeroen-Bakker as you two seem to work on the asset browser the most. And this is kind of design proposal?

Philipp Oeser commented

2021-08-05 10:39:29 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-08-05 10:39:29 +02:00

Seems like the plan is on the TODO, see #89987 (Recurse Into Nested Folders of an Asset Library), will merge these reports (and mention we already had a recursion option there).

Philipp Oeser commented

2021-08-05 10:39:46 +02:00

Closed as duplicate of #89987

Philipp Oeser closed this issue

2021-08-05 10:39:46 +02:00

Alaska commented

2021-08-05 10:51:33 +02:00

Thanks @lichtwerk

Julian Eisel commented

2021-08-05 10:54:29 +02:00

The recursion option there was another leftover from the File Browser. Plan is to let asset libraries be fully recursive by default, without having to specify how many levels.
But that is what #89987 (Recurse Into Nested Folders of an Asset Library) is about, which I'll probably work on today.

The recursion option there was another leftover from the File Browser. Plan is to let asset libraries be fully recursive by default, without having to specify how many levels. But that is what #89987 (Recurse Into Nested Folders of an Asset Library) is about, which I'll probably work on today.

Alaska commented

2021-08-05 12:14:49 +02:00

In #90451#1202152, @JulianEisel wrote:
The recursion option there was another leftover from the File Browser. Plan is to let asset libraries be fully recursive by default, without having to specify how many levels.
But that is what #89987 (Recurse Into Nested Folders of an Asset Library) is about, which I'll probably work on today.

Thanks for clarifying

> In #90451#1202152, @JulianEisel wrote: > The recursion option there was another leftover from the File Browser. Plan is to let asset libraries be fully recursive by default, without having to specify how many levels. > But that is what #89987 (Recurse Into Nested Folders of an Asset Library) is about, which I'll probably work on today. Thanks for clarifying

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

The removal of "Recursion" in asset browser removes functionality. #90451