Undo takes several seconds just to move default cube within scene containing panorama if viewport shows materials #90593

New Issue

Robert Bragg · 2021-08-10T22:56:47+02:00

Robert Bragg commented

2021-08-10 22:56:47 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 2.93.2, branch: master, commit date: 2021-08-03 05:58, hash: 1eb06de260
Broken: version: 2.93.1, branch: master, commit date: 2021-06-22 05:57, hash: 1b8d33b18c
Worked: It sometimes works ok in 2.83.16, but not consistently

Short description of error
If a scene has any materials with large textures then it seems that any undo operation can be very slow (several seconds) if the viewport is currently displaying materials, but the same operation will undo instantly if the viewport is flat shaded or wireframe.

Even if the operation (such as grabbing and moving a default, untextured, cube) is unrelated to any materials involving large textures the undo is still very slow.

Exact steps for others to reproduce the error

Keep the default cube
Add a UV sphere and scale it 100x
Create a material shader with nodes for the sphere like:

(Environment Texture)[Color] => [Color](Emission Shader)[Emission] => [Surface](Material Output)

Associate a large environment map image with the texture node (e.g. 8k)
Make sure the Viewport Shading mode is set to 'Material Preview'
Select the default cube in object mode
Press 'g' to grab and move the cube
Press Ctrl-Z to undo

This undo is taking about 2 seconds to complete for me. In my original project I was seeing undo taking between 3-6 seconds.

(I can also attach a minimal .blend file that is based on default/factory settings that reproduces this)

Notably I found that if I follow the same instructions to reproduce this in 2.83 then I didn't initially see any lag with undo, but if I save the file, close blender and then re-open then I would see the same issue.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 2.93.2, branch: master, commit date: 2021-08-03 05:58, hash: `1eb06de260` Broken: version: 2.93.1, branch: master, commit date: 2021-06-22 05:57, hash: `1b8d33b18c` Worked: It _sometimes_ works ok in 2.83.16, but not consistently **Short description of error** If a scene has any materials with large textures then it seems that any undo operation can be very slow (several seconds) if the viewport is currently displaying materials, but the same operation will undo instantly if the viewport is flat shaded or wireframe. Even if the operation (such as grabbing and moving a default, untextured, cube) is unrelated to any materials involving large textures the undo is still very slow. **Exact steps for others to reproduce the error** - Keep the default cube - Add a UV sphere and scale it 100x - Create a material shader with nodes for the sphere like: (Environment Texture)[Color] => [Color](Emission Shader)[Emission] => [Surface](Material Output) - Associate a large environment map image with the texture node (e.g. 8k) - Make sure the Viewport Shading mode is set to 'Material Preview' - Select the default cube in object mode - Press 'g' to grab and move the cube - Press Ctrl-Z to undo This undo is taking about 2 seconds to complete for me. In my original project I was seeing undo taking between 3-6 seconds. (I can also attach a minimal .blend file that is based on default/factory settings that reproduces this) Notably I found that if I follow the same instructions to reproduce this in 2.83 then I didn't initially see any lag with undo, but if I save the file, close blender and then re-open _then_ I would see the same issue.

Robert Bragg commented

2021-08-10 22:56:47 +02:00

Added subscriber: @RobertBragg

blender-admin commented

2021-08-10 22:56:47 +02:00

#89127 was marked as duplicate of this issue

blender-admin commented

2021-08-10 22:56:47 +02:00

#86273 was marked as duplicate of this issue

Robert Bragg commented

2021-08-10 22:59:49 +02:00

slow-undo-depending-on-viewport-mode-packed.blend
Here's a minimal blend file, based on factory default settings that reproduces the issue for me, created with blender 2.93.2. It includes a highly compressed panorama jpg that's 10k by 5k

[slow-undo-depending-on-viewport-mode-packed.blend](https://archive.blender.org/developer/F10276873/slow-undo-depending-on-viewport-mode-packed.blend) Here's a minimal blend file, based on factory default settings that reproduces the issue for me, created with blender 2.93.2. It includes a highly compressed panorama jpg that's 10k by 5k

Philipp Oeser commented

2021-08-12 10:36:01 +02:00

Added subscribers: @mont29, @lichtwerk

Philipp Oeser commented

2021-08-12 10:36:01 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2021-08-12 10:36:01 +02:00

Can confirm the behavior.

But since blender Global Undo works by somewhat reading a whole blend file from memory, this might be expected/unavoidable.
@mont29: sorry to ask, but is this expected behavior?

Can confirm the behavior. But since blender Global Undo works by somewhat reading a whole blend file from memory, this might be expected/unavoidable. @mont29: sorry to ask, but is this expected behavior?

Bastien Montagne commented

2021-08-13 16:44:10 +02:00

Added subscribers: @fclem, @Jeroen-Bakker

Bastien Montagne commented

2021-08-13 16:44:10 +02:00

That would be more of a question for #eevee_viewport team I think... Sounds like some GPU work caching gets lost. @Jeroen-Bakker ? @fclem ?

Bastien Montagne commented

2021-08-13 16:50:42 +02:00

@lichtwerk Global undo only reads modified data (in ideal world at least) these days, so would expect it to be possible to keep unmodified data's GPU caches ;)

Philipp Oeser commented

2021-08-13 17:37:10 +02:00

In #90593#1206179, @mont29 wrote:
@lichtwerk Global undo only reads modified data (in ideal world at least) these days, so would expect it to be possible to keep unmodified data's GPU caches ;)

I am so not "up-to-date" on this, sorry spreading some non-truth here!

> In #90593#1206179, @mont29 wrote: > @lichtwerk Global undo only reads modified data (in ideal world at least) these days, so would expect it to be possible to keep unmodified data's GPU caches ;) I am so not "up-to-date" on this, sorry spreading some non-truth here!

Jeroen Bakker commented

2021-08-17 11:10:34 +02:00

Issue is related to undo file loading.
After the file is linked the caches are cleared.
This is done in image_blend_read_lib.

After discussing with @mon29 we propose to clear the attributes when writing that are also cleared during load. This would lead to reuse of the existing image.

Issue is related to undo file loading. After the file is linked the caches are cleared. This is done in `image_blend_read_lib`. After discussing with @mon29 we propose to clear the attributes when writing that are also cleared during load. This would lead to reuse of the existing image.

Philipp Oeser commented

2021-08-17 20:16:05 +02:00

Added subscriber: @rfc

rafek yousef commented

2021-08-17 21:23:27 +02:00

I tested it in 2.91 it works very good without lag even if you restart it several times

blender-admin commented

2021-08-19 17:04:19 +02:00

This issue was referenced by 0896457c59

This issue was referenced by 0896457c59d722e809188517c042b57d0ea399d3

Bastien Montagne commented

2021-08-19 18:01:34 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Bastien Montagne closed this issue

2021-08-19 18:01:34 +02:00

Bastien Montagne self-assigned this 2021-08-19 18:01:34 +02:00

Bastien Montagne commented

2021-08-19 18:30:11 +02:00

@Jeroen-Bakker 0896457c59 Fixed most of the problem, but the first undo step (immediately after fileload) still forces reloading of the image data-block, apparently because the preview sub-data changes. Not sure I'd consider that a real bug though, more like known internal limitation.

@Jeroen-Bakker 0896457c59 Fixed most of the problem, but the first undo step (immediately after fileload) still forces reloading of the image data-block, apparently because the `preview` sub-data changes. Not sure I'd consider that a real bug though, more like known internal limitation.

Richard Antalik commented

2021-08-31 01:28:20 +02:00

Added subscribers: @Andrei-Feheregyhazi, @Alaska, @Zandman, @iss

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Undo takes several seconds just to move default cube within scene containing panorama if viewport shows materials #90593