Grammatical error in in description of Adaptive sampling noise threshold description #90804

Closed
opened 2021-08-20 16:08:27 +02:00 by Alaska · 4 comments
Member

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-20 13:00, hash: 1b5f17b867
Worked: (newest version of Blender that worked as expected)

Short description of error:
There is a grammatical error in the description of Adaptive sampling noise threshold. It reads:

Noise level step to stop sampling at, lower values reduce noise the cost of render time. Zero for automatic setting based on number of AA samples

The part that is incorrect is
...reduce noise the cost of...

It should be

...reduce noise at the cost of...

I have provided a patch to fix this (Not sure who to set as reviewer. It doesn't really need review from anyone specific): D12277: Fix #90804: small grammatical error in noise threshold description

Exact steps for others to reproduce the error:

  1. Launch Blender and set the render engine to Cycles.
  2. Navigate to the Render Properties -> Sampling -> Adaptive Sampling then hover your mouse over the Noise Threshold value until a tool tip shows up. Read it and observe the grammatical error.
**Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-20 13:00, hash: `1b5f17b867` Worked: (newest version of Blender that worked as expected) **Short description of error:** There is a grammatical error in the description of `Adaptive sampling noise threshold`. It reads: `Noise level step to stop sampling at, lower values reduce noise the cost of render time. Zero for automatic setting based on number of AA samples` The part that is incorrect is `...reduce noise the cost of...` It should be `...reduce noise at the cost of...` I have provided a patch to fix this (Not sure who to set as reviewer. It doesn't really need review from anyone specific): [D12277: Fix #90804: small grammatical error in noise threshold description](https://archive.blender.org/developer/D12277) **Exact steps for others to reproduce the error:** 1. Launch Blender and set the render engine to Cycles. 2. Navigate to the `Render Properties -> Sampling -> Adaptive Sampling` then hover your mouse over the `Noise Threshold` value until a tool tip shows up. Read it and observe the grammatical error.
Author
Member

Added subscriber: @Alaska

Added subscriber: @Alaska
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

This issue was referenced by cd8d9383e7

This issue was referenced by cd8d9383e74a798e75ebced95cdd6d8de9f02369

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Brecht Van Lommel self-assigned this 2021-08-20 17:44:33 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#90804
No description provided.