Cycles X sampling settings update #90805

New Issue

Brecht Van Lommel · 2021-08-20T16:12:18+02:00

Brecht Van Lommel commented

2021-08-20 16:12:18 +02:00

This is a design task for updating the sampling settings, defaults and presets. The current ones predate adaptive sampling and denoising, but we should enable those by default and design the settings around them.

Proposed Changes

Settings:

Separate all sampling settings for viewport and final render, in particular adaptive sampling needs to be duplicated.
Move final render denoising settings from render layer to scene, for discoverability and consistency with the viewport settings.
Remove square samples, this was mainly for similarity with other renderer settings, but without branched path tracing and with adaptive sampling this makes less sense.

Defaults:

Enable adaptive sampling by default both for viewport and final render. For the viewport we could use a threshold like 0.1 and for final render e.g. 0.01.
Enabling denoising by default for final render. For viewport render, set the start sample to a relatively high value like 32 so it only kicks after a while.
Set samples to a high value by default and let adaptive sampling handle the exact number of samples. For example, 1k for viewport and 4k for final rendering, resulting in respectively 32 and 64 minimum adaptive samples with the current heuristic.

Presets

Have separate preset menu for the viewport and render sub-panels. Ideally these could share the same underlying presets, but not obvious yet how since the property names are different.

UI Layout

Render panel default:

                [x] Adaptive Sampling
Noise Treshold  [         0.01          ]

Max Samples     [         16384         ]
Min Samples     [           0           ]
Time Limit      [          0.0          ]

Denoising        [x] [ OpenImageDenoise ]
Passes           [  Albedo and Normal   ]
Prefilter Passes [      Accurate        ]

Render panel without adaptive sampling:

                [ ] Adaptive Sampling
Samples         [         1024          ]
Time Limit      [          0.0          ]

Denoising        [x] [ OpenImageDenoise ]
Passes           [  Albedo and Normal   ]
Prefilter        [      Accurate        ]

Viewport panel default:

                [x] Adaptive Sampling
Noise Treshold  [         0.1           ]

Max Samples     [         1024          ]
Min Samples     [           0           ]
Time Limit      [          0.0          ]

Denoising        [x] [    Automatic     ]
Passes           [        Albedo        ]
Prefilter        [         Fast         ]
Start Sample     [          32          ]

Presets

The current Viewport and Final presets can be updated to the new defaults. It's unclear if we should add more presets and what they should look like.

This is a design task for updating the sampling settings, defaults and presets. The current ones predate adaptive sampling and denoising, but we should enable those by default and design the settings around them. **Proposed Changes** Settings: * Separate all sampling settings for viewport and final render, in particular adaptive sampling needs to be duplicated. * Move final render denoising settings from render layer to scene, for discoverability and consistency with the viewport settings. * Remove square samples, this was mainly for similarity with other renderer settings, but without branched path tracing and with adaptive sampling this makes less sense. Defaults: * Enable adaptive sampling by default both for viewport and final render. For the viewport we could use a threshold like 0.1 and for final render e.g. 0.01. * Enabling denoising by default for final render. For viewport render, set the start sample to a relatively high value like 32 so it only kicks after a while. * Set samples to a high value by default and let adaptive sampling handle the exact number of samples. For example, 1k for viewport and 4k for final rendering, resulting in respectively 32 and 64 minimum adaptive samples with the current heuristic. Presets * Have separate preset menu for the viewport and render sub-panels. Ideally these could share the same underlying presets, but not obvious yet how since the property names are different. **UI Layout** Render panel default: ``` [x] Adaptive Sampling Noise Treshold [ 0.01 ] Max Samples [ 16384 ] Min Samples [ 0 ] Time Limit [ 0.0 ] Denoising [x] [ OpenImageDenoise ] Passes [ Albedo and Normal ] Prefilter Passes [ Accurate ] ``` Render panel without adaptive sampling: ``` [ ] Adaptive Sampling Samples [ 1024 ] Time Limit [ 0.0 ] Denoising [x] [ OpenImageDenoise ] Passes [ Albedo and Normal ] Prefilter [ Accurate ] ``` Viewport panel default: ``` [x] Adaptive Sampling Noise Treshold [ 0.1 ] Max Samples [ 1024 ] Min Samples [ 0 ] Time Limit [ 0.0 ] Denoising [x] [ Automatic ] Passes [ Albedo ] Prefilter [ Fast ] Start Sample [ 32 ] ``` **Presets** The current Viewport and Final presets can be updated to the new defaults. It's unclear if we should add more presets and what they should look like.

Brecht Van Lommel commented

2021-08-20 16:12:18 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'