Change "Link materials to the object or the object's data" on multiple objects #90907

New Issue

Staffan Wikström · 2021-08-25T08:40:59+02:00

Staffan Wikström commented

2021-08-25 08:40:59 +02:00

In 3.0.0 alpha there is a bug preventing me from changing "Link materials to the object or the object's data" on multiple objects by alt-clicking on the drop down.
This worked in 2.93.3.

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Quadro P3000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.92

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-24 18:38, hash: 5ef3afd87c
Worked: 2.93.3
Caused by 1a81d268a1

Short description of error
[Please fill out a short description of the error here]

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

In 3.0.0 alpha there is a bug preventing me from changing "Link materials to the object or the object's data" on multiple objects by alt-clicking on the drop down. This worked in 2.93.3. **System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: Quadro [P3000](https://archive.blender.org/developer/P3000.txt)/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 461.92 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-08-24 18:38, hash: `5ef3afd87c` Worked: 2.93.3 Caused by 1a81d268a1 **Short description of error** [Please fill out a short description of the error here] **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)]

Staffan Wikström commented

2021-08-25 08:40:59 +02:00

Added subscriber: @staffan.wikstrom

Philipp Oeser commented

2021-08-25 10:23:10 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-08-25 10:23:10 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2021-08-25 10:23:10 +02:00

Philipp Oeser commented

2021-08-25 10:23:10 +02:00

Can confirm, will check if this was intentional

Pratik Borhade commented

2021-08-25 10:38:09 +02:00

Added subscriber: @PratikPB2123

blender-admin commented

2021-08-25 13:09:44 +02:00

This issue was referenced by 6845aad1a2

This issue was referenced by 6845aad1a271db9861ba54e50c97146277eead4f

Philipp Oeser commented

2021-08-25 13:11:41 +02:00

same is true for Copy To Selected.

Caused by 1a81d268a1

I think there is an issue with the new usage of POINTER_FROM_INT.
See 02b80276b3 for another recent issue with this.
Not totally sure how RNA handled the PointerRNA.data before, but now these are not unique across objects anymore.

So the following checks always have lptr.data and ptr.data the same [which I think causes the problem]
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_handlers.c$1824
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_ops.c$1038

Tried to make this unique again with (but I think I just dont understand this pointer <> int conversion...)
P2344: T90907_snippet



diff --git a/source/blender/makesrna/intern/rna_object.c b/source/blender/makesrna/intern/rna_object.c
index 0f6b89722a4..bd636876d66 100644
--- a/source/blender/makesrna/intern/rna_object.c
+++ b/source/blender/makesrna/intern/rna_object.c
@@ -1326,8 +1326,8 @@ static int rna_Object_rotation_4d_editable(PointerRNA *ptr, int index)
 
 static int rna_MaterialSlot_index(PointerRNA *ptr)
 {
-  /* There is an offset of one, so that `ptr->data` is not null. */
-  return POINTER_AS_INT(ptr->data) - 1;
+  ID *id = (ID *)ptr->owner_id;
+  return POINTER_AS_INT(ptr->data) - POINTER_AS_INT(id);
 }
 
 static int rna_MaterialSlot_material_editable(PointerRNA *ptr, const char **UNUSED(r_info))
@@ -1490,10 +1490,11 @@ static void rna_Object_material_slots_next(CollectionPropertyIterator *iter)
 static PointerRNA rna_Object_material_slots_get(CollectionPropertyIterator *iter)
 {
   PointerRNA ptr;
-  RNA_pointer_create((ID *)iter->internal.count.ptr,
+  ID *id = (ID *)iter->internal.count.ptr;
+  RNA_pointer_create(id,
                      &RNA_MaterialSlot,
                      /* Add one, so that `ptr->data` is not null. */
-                     POINTER_FROM_INT(iter->internal.count.item + 1),
+                     POINTER_FROM_INT(iter->internal.count.item + POINTER_AS_INT(id)),
                      &ptr);
   return ptr;
 }

same is true for Copy To Selected. Caused by 1a81d268a1 I think there is an issue with the new usage of POINTER_FROM_INT. See 02b80276b3 for another recent issue with this. Not totally sure how RNA handled the PointerRNA.data before, but now these are not unique across objects anymore. So the following checks always have lptr.data and ptr.data the same [which I think causes the problem] https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_handlers.c$1824 https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/interface_ops.c$1038 Tried to make this unique again with (but I think I just dont understand this pointer <> int conversion...) [P2344: T90907_snippet](https://archive.blender.org/developer/P2344.txt) ``` diff --git a/source/blender/makesrna/intern/rna_object.c b/source/blender/makesrna/intern/rna_object.c index 0f6b89722a4..bd636876d66 100644 --- a/source/blender/makesrna/intern/rna_object.c +++ b/source/blender/makesrna/intern/rna_object.c @@ -1326,8 +1326,8 @@ static int rna_Object_rotation_4d_editable(PointerRNA *ptr, int index) static int rna_MaterialSlot_index(PointerRNA *ptr) { - /* There is an offset of one, so that `ptr->data` is not null. */ - return POINTER_AS_INT(ptr->data) - 1; + ID *id = (ID *)ptr->owner_id; + return POINTER_AS_INT(ptr->data) - POINTER_AS_INT(id); } static int rna_MaterialSlot_material_editable(PointerRNA *ptr, const char **UNUSED(r_info)) @@ -1490,10 +1490,11 @@ static void rna_Object_material_slots_next(CollectionPropertyIterator *iter) static PointerRNA rna_Object_material_slots_get(CollectionPropertyIterator *iter) { PointerRNA ptr; - RNA_pointer_create((ID *)iter->internal.count.ptr, + ID *id = (ID *)iter->internal.count.ptr; + RNA_pointer_create(id, &RNA_MaterialSlot, /* Add one, so that `ptr->data` is not null. */ - POINTER_FROM_INT(iter->internal.count.item + 1), + POINTER_FROM_INT(iter->internal.count.item + POINTER_AS_INT(id)), &ptr); return ptr; } ```

Philipp Oeser changed title from ~~change "Link materials to the object or the object's data" on multiple objects~~ to Change "Link materials to the object or the object's data" on multiple objects

2021-08-25 13:14:35 +02:00

Philipp Oeser removed their assignment 2021-08-25 13:14:35 +02:00

Jacques Lucke commented

2021-08-25 16:34:23 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2021-08-25 16:34:23 +02:00

Your idea is right, there are two problems:

POINTER_AS_INT casts to 32 bit int internally, which messes up the pointer. Better just cast to uintptr_t and void * manually here.
It's also necessary to update this place: b51bd859fd.

Your idea is right, there are two problems: * `POINTER_AS_INT` casts to 32 bit `int` internally, which messes up the pointer. Better just cast to `uintptr_t` and `void *` manually here. * It's also necessary to update this place: b51bd859fd.

Philipp Oeser self-assigned this 2021-08-25 16:38:21 +02:00

Philipp Oeser commented

2021-08-27 11:07:12 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2021-08-27 11:07:12 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Change "Link materials to the object or the object's data" on multiple objects #90907