blender/blender
150
485
Fork 717
Code Issues 6.8k Pull Requests 893 Projects 17 Wiki Activity

Material properties surface selection UI does not filter out hidden node groups #91022

New Issue
Open
opened 2021-08-29 11:19:52 +02:00 by Tom Smalley · 10 comments
Tom Smalley commented 2021-08-29 11:19:52 +02:00
Copy Link

System Information
Operating system: Windows 10.0.19042 Build 19042
Graphics card: AMD Radeon RX570

Blender Version
Broken: 2.93.0 Alpha (hash: 3494946560)

Short description of error
nodeitems_builtins contains a function used for listing node groups which filters out "hidden" groups - denoted by the name starting with a period.

2f7258d618/release/scripts/startup/nodeitems_builtins.py (L118)

This prevents those groups showing up in the node editor when adding a group node, and is very useful for custom node groups, especially in the context of auto generation by an addon via ShaderNodeCustomGroup. However, there exists another UI for selecting node groups which does not do the same filtering: in the material properties panel by clicking "Surface". Custom node groups which should be hidden clutter the box.

The guilty function appears to be uiTemplateNodeView.

Exact steps for others to reproduce the error

  1. Add a mesh and node based material for that mesh
  2. Edit the nodes and create a node group
  3. See that the node group shows up in the Add > Group menu
  4. Rename the node group .HiddenNodeGroup or similar
  5. See that the node group is hidden in the Add > Group menu [first image]
  6. See that the node group still shows up in the Properties > Material > Surface dropdown [second image]

blender-hidden-node-group-node-editor.png
blender-hidden-node-group-material-panel.png

**System Information** Operating system: Windows 10.0.19042 Build 19042 Graphics card: AMD Radeon RX570 **Blender Version** Broken: 2.93.0 Alpha (hash: 3494946560c2) **Short description of error** nodeitems_builtins contains a function used for listing node groups which filters out "hidden" groups - denoted by the name starting with a period. https://github.com/blender/blender/blob/2f7258d618a2a38fc982a9e0d0d7dd3cbc95ab3a/release/scripts/startup/nodeitems_builtins.py#L118 This prevents those groups showing up in the node editor when adding a group node, and is very useful for custom node groups, especially in the context of auto generation by an addon via ShaderNodeCustomGroup. However, there exists another UI for selecting node groups which does not do the same filtering: in the material properties panel by clicking "Surface". Custom node groups which *should* be hidden clutter the box. The guilty function appears to be uiTemplateNodeView. **Exact steps for others to reproduce the error** 1. Add a mesh and node based material for that mesh 2. Edit the nodes and create a node group 3. See that the node group shows up in the Add > Group menu 4. Rename the node group .HiddenNodeGroup or similar 5. See that the node group is hidden in the Add > Group menu [first image] 6. See that the node group still shows up in the Properties > Material > Surface dropdown [second image] ![blender-hidden-node-group-node-editor.png](https://archive.blender.org/developer/F10347122/blender-hidden-node-group-node-editor.png) ![blender-hidden-node-group-material-panel.png](https://archive.blender.org/developer/F10347125/blender-hidden-node-group-material-panel.png)
Tom Smalley commented 2021-08-29 11:19:52 +02:00
Author
Copy Link

Added subscriber: @tomsmalley

Added subscriber: @tomsmalley
Omar Emara commented 2022-03-23 07:21:09 +01:00
Member
Copy Link

Added subscriber: @OmarEmaraDev

Added subscriber: @OmarEmaraDev
Omar Emara commented 2022-03-23 07:21:09 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Omar Emara commented 2022-03-23 07:21:09 +01:00
Member
Copy Link

It seems the behavior you want is the intended behavior discussed in D4370. So I will mark this confirmed.

It seems the behavior you want is the intended behavior discussed in [D4370](https://archive.blender.org/developer/D4370). So I will mark this confirmed.
Dalai Felinto commented 2022-05-09 15:44:50 +02:00
Owner
Copy Link

Added subscriber: @dfelinto

Added subscriber: @dfelinto
Dalai Felinto commented 2022-05-09 15:44:50 +02:00
Owner
Copy Link

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'
Dalai Felinto commented 2022-05-09 15:44:50 +02:00
Owner
Copy Link

This is not a bug. The ability to hide built-in nodes are not exposed to end-users.

This is not a bug. The ability to hide built-in nodes are not exposed to end-users.
Tom Smalley commented 2022-05-09 20:36:10 +02:00
Author
Copy Link

@dfelinto I think you've misunderstood - this ticket is not about hiding built-in nodes. It's about hiding user definednode groups which have been given a name that makes them hidden everywhere else in the UI, but not this one dropdown box. This bug is a consistency issue.

@dfelinto I think you've misunderstood - this ticket is not about hiding built-in nodes. It's about hiding *user defined*node groups which have been given a name that makes them hidden everywhere else in the UI, but not this one dropdown box. This bug is a consistency issue.
Dalai Felinto commented 2022-05-10 15:32:49 +02:00
Owner
Copy Link

Changed status from 'Archived' to: 'Confirmed'

Changed status from 'Archived' to: 'Confirmed'
Dalai Felinto commented 2022-05-10 15:32:49 +02:00
Owner
Copy Link

Ok. I guess it makes sense to be consistent. Lowering its priority, but patches are welcome if someone wants to fix this.

Ok. I guess it makes sense to be consistent. Lowering its priority, but patches are welcome if someone wants to fix this.
Philipp Oeser removed the
Interest
Nodes & Physics
 label 2023-02-10 08:44:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#91022
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?