Move mesh vertex normals out of MVert #91186
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#91186
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently mesh vertex normals are stored as
short no- [x];
inMVert
. This is problematic for a few reasons:short
is required.MVert
slower.One key fact is that vertex normals are just derived data, they can always be recalculated with a fairly costly but simple accumulation from face normals.
I propose to remove
MVert.no
and store the cached result of the vertex normal calculation as a separateCD_NORMAL
custom data layer.Calculation should be lazy, available on const meshes, protected by a mutex. Here are some thoughts on specifics:
MVert.no
is used in 137 places, though some of those are larger changes. I expect some changes might be involved, but worth it.normal
property in RNA. At a small performance cost, this can just access normals indirectly with the RNA pointer's owner ID.After this change,
MVert
will look like this:The remaining items could easily be replaced with bitmaps or attributes stored elsewhere. Then
MVert
would have exactly the same layout asfloat3
!So, moving mesh normals out of
MVert
is also the biggest step toward storing mesh positions as a contiguous array as well, which has even more performance benefits.Added subscriber: @HooglyBoogly
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscribers: @JacquesLucke, @ideasman42
Added subscriber: @Gilberto.R
Added subscriber: @GeorgiaPacific
This issue was referenced by
cfa53e0fbe
Changed status from 'Confirmed' to: 'Resolved'