Outline color for selected objects #91310

New Issue

Jacques Lucke · 2021-09-10T11:33:22+02:00

Jacques Lucke commented

2021-09-10 11:33:22 +02:00

Instances in an object currently have a different outline color. This can be confusing now, because sometimes an object only consists of instances in its evaluated state. That makes it hard to see which object is active.

Jacques Lucke commented

2021-09-10 11:33:22 +02:00

Added subscriber: @JacquesLucke

Jarrett Johnson commented

2021-11-01 06:33:18 +01:00

Added subscriber: @Jarrett-Johnson

Jarrett Johnson commented

2021-11-01 06:33:18 +01:00

Hi Jacques, I was considering working on this too (unless you wanted to), but I was wondering if it'd cause confusion having the instances also share the same color as the original. How would people tell them apart?

Jacques Lucke commented

2021-11-01 11:58:35 +01:00

Guess that's more of a design task for now.
Personally, I'm not convinced that people have to tell instances apart in the viewport. For me they are just part of the final object. Whether the output is a mesh or a single instance that contains a mesh seems irrelevant in the viewport.

Guess that's more of a design task for now. Personally, I'm not convinced that people have to tell instances apart in the viewport. For me they are just part of the final object. Whether the output is a mesh or a single instance that contains a mesh seems irrelevant in the viewport.

Dalai Felinto commented

2021-11-02 17:17:27 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2021-11-02 17:17:27 +01:00

+1 for what Jacques said.

Hans Goudey commented

2021-11-04 18:22:08 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-11-04 18:22:08 +01:00

Here is a start to this solution. It doesn't make make geometry components quite as bright as the base component type though.

diff --git a/source/blender/draw/intern/draw_common.c b/source/blender/draw/intern/draw_common.c
index 62d715460bb..a4d98cf352d 100644
--- a/source/blender/draw/intern/draw_common.c
+++ b/source/blender/draw/intern/draw_common.c
@@ -101,10 +101,10 @@ void DRW_globals_update(void)
       gb->colorEditMeshMiddle,
       dot_v3v3(gb->colorEditMeshMiddle, (float[3]){0.3333f, 0.3333f, 0.3333f})); /* Desaturate */
 
-  interp_v4_v4v4(gb->colorDupliSelect, gb->colorBackground, gb->colorSelect, 0.5f);
+  copy_v4_v4(gb->colorDupliSelect, gb->colorSelect);
   /* Was 50% in 2.7x since the background was lighter making it easier to tell the color from
    * black, with a darker background we need a more faded color. */
-  interp_v4_v4v4(gb->colorDupli, gb->colorBackground, gb->colorWire, 0.3f);
+  copy_v4_v4(gb->colorDupli, gb->colorWire);
 
 #ifdef WITH_FREESTYLE
   UI_GetThemeColor4fv(TH_FREESTYLE_EDGE_MARK, gb->colorEdgeFreestyle);

Here is a start to this solution. It doesn't make make geometry components quite as bright as the base component type though. ``` diff --git a/source/blender/draw/intern/draw_common.c b/source/blender/draw/intern/draw_common.c index 62d715460bb..a4d98cf352d 100644 --- a/source/blender/draw/intern/draw_common.c +++ b/source/blender/draw/intern/draw_common.c @@ -101,10 +101,10 @@ void DRW_globals_update(void) gb->colorEditMeshMiddle, dot_v3v3(gb->colorEditMeshMiddle, (float[3]){0.3333f, 0.3333f, 0.3333f})); /* Desaturate */ - interp_v4_v4v4(gb->colorDupliSelect, gb->colorBackground, gb->colorSelect, 0.5f); + copy_v4_v4(gb->colorDupliSelect, gb->colorSelect); /* Was 50% in 2.7x since the background was lighter making it easier to tell the color from * black, with a darker background we need a more faded color. */ - interp_v4_v4v4(gb->colorDupli, gb->colorBackground, gb->colorWire, 0.3f); + copy_v4_v4(gb->colorDupli, gb->colorWire); #ifdef WITH_FREESTYLE UI_GetThemeColor4fv(TH_FREESTYLE_EDGE_MARK, gb->colorEdgeFreestyle); ```

Hans Goudey self-assigned this 2021-11-05 20:50:08 +01:00

blender-admin commented

2021-11-09 17:12:05 +01:00

This issue was referenced by aa13c4b386

This issue was referenced by aa13c4b386b1311162e74378ad864a51b2f1b7af

Vladislav Macíček commented

2021-11-15 17:47:40 +01:00

Added subscriber: @Aeraglyx