Add operators to convert generic attributes into task specific data (UVLayers, etc) #91379

New Issue

Simon Thommes · 2021-09-13T15:16:20+02:00

Simon Thommes commented

2021-09-13 15:16:20 +02:00

There should be an operator to convert a generic attribute to a task-specific one.

Explanation
With the functionality to manage generic attributes on a geometry there is a need to edit this data manually. This is currently not yet possible and will be a longer standing goal for a while.
Combined with the fact that there are separate namespaces for the different legacy attribute types causing name collisions very easily, there is a need to convert generic attributes into task-specific attributes that Blender understands within their context.

Example
A geonodes modifier is applied on a bush scattering leaves

the UVs and vertex colors are now generic attributes and not editable with the respective editors
there are name collisions with newly created UV/vertex color layers

There should be an operator to convert a generic attribute to a task-specific one. **Explanation** With the functionality to manage generic attributes on a geometry there is a need to edit this data manually. This is currently not yet possible and will be a longer standing goal for a while. Combined with the fact that there are separate namespaces for the different legacy attribute types causing name collisions very easily, there is a need to convert generic attributes into task-specific attributes that Blender understands within their context. **Example** A geonodes modifier is applied on a bush scattering leaves - > the UVs and vertex colors are now generic attributes and not editable with the respective editors - > there are name collisions with newly created UV/vertex color layers

Simon Thommes commented

2021-09-13 15:16:20 +02:00

Added subscriber: @SimonThommes

Hans Goudey changed title from ~~Expose operators to convert generic attributes into task specific data (UVLayers, etc.)~~ to Add operators to convert generic attributes into task specific data (UVLayers, etc)

2021-09-13 21:35:01 +02:00

Hans Goudey commented

2021-09-13 21:37:34 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-09-13 21:37:34 +02:00

I like this idea. It means we can solve the generic attribute problem properly, but there would be a workaround in the meantime.
It would be helpful if this task defined a list of conversions that would be helpful. I'll start out with a guess maybe?

2D Vector -> UV
Float -> vertex group

What are the other essential ones?

I like this idea. It means we can solve the generic attribute problem properly, but there would be a workaround in the meantime. It would be helpful if this task defined a list of conversions that would be helpful. I'll start out with a guess maybe? - 2D Vector -> UV - Float -> vertex group What are the other essential ones?

Simon Thommes commented

2021-09-14 18:02:31 +02:00

The only other one I'd consider essential would be:

Color -> Vertex Color Layer

Then nice to have would be:

3D Vector -> Shapekey

Nice could also be conversion on the edge domain:

seam
crease
bevel weight

Might be personal preference, but I don't consider face maps as important.

But in general I don't think we should necessarily enforce specific data types or domains for the conversions.

The only other one I'd consider essential would be: - Color -> Vertex Color Layer Then nice to have would be: - 3D Vector -> Shapekey Nice could also be conversion on the edge domain: - seam - crease - bevel weight Might be personal preference, but I don't consider face maps as important. But in general I don't think we should necessarily enforce specific data types or domains for the conversions.

Jan Kadeřábek commented

2021-10-05 13:24:19 +02:00

Added subscriber: @JanKaderabek

nick nieuwoudt commented

2021-10-23 13:42:24 +02:00

Added subscriber: @nick-nieuwoudt

nick nieuwoudt commented

2021-10-23 13:42:24 +02:00

This sounds like a good solution I think It would address a majority of at least the dealbreakers i have been hitting with geo nodes.

Ramil Roosileht commented

2021-11-15 19:03:15 +01:00

Added subscriber: @Limarest

Ramil Roosileht commented

2021-11-15 19:03:15 +01:00

Does this design task also takes into consideration making it possible to output UVs and vertex colors from geo nodes?
For example, when exporting geo nodes meshes?

Does this design task also takes into consideration making it possible to output UVs and vertex colors from geo nodes? For example, when exporting geo nodes meshes?

Paul Larson commented

2021-12-03 15:44:35 +01:00

Added subscriber: @GeorgiaPacific

Yuro commented

2021-12-08 15:47:37 +01:00

Added subscriber: @Yuro

Lyaka commented

2021-12-12 15:39:09 +01:00

Added subscriber: @qbicksan

David NR commented

2022-01-07 20:00:03 +01:00

Added subscriber: @davidnr

Jacques Lucke was assigned by Hans Goudey

2022-01-20 17:54:40 +01:00

Ramil Roosileht commented

2022-01-20 23:14:55 +01:00

Tried building with diff and the conversion doesn't seem to work right now, newly created attribute is pitch black. Also, for some reason attribute disappears when converted to a vertex group, which doesn't happen in other cases
Please check the video:
blender_4Tfsg9lUOL.mp4

The file:
VertexColorTransferTest.blend

Tried building with diff and the conversion doesn't seem to work right now, newly created attribute is pitch black. Also, for some reason attribute disappears when converted to a vertex group, which doesn't happen in other cases Please check the video: [blender_4Tfsg9lUOL.mp4](https://archive.blender.org/developer/F12813597/blender_4Tfsg9lUOL.mp4) The file: [VertexColorTransferTest.blend](https://archive.blender.org/developer/F12813602/VertexColorTransferTest.blend)

Hans Goudey commented

2022-01-20 23:29:31 +01:00

You'll probably have to apply the modifier in that case-- writing to a vertex color will still make it into a generic attribute, this patch doesn't change that.

Ramil Roosileht commented

2022-01-20 23:58:42 +01:00

It's not shown in the video, but I also tried converting to a vertex group and a UV map, which also didn't work. Maybe I am doing something wrong, idk

Jacques Lucke commented

2022-01-21 12:29:11 +01:00

The operator in the patch only works on "applied geometry". The modifier just overwrites the existing attribute. You can see that by applying the modifier again.

I did find that there are issues when sculpt vertex colors are enabled. That's because of how node_shader_gpu_vertex_color is implemented currently.

The operator in the patch only works on "applied geometry". The modifier just overwrites the existing attribute. You can see that by applying the modifier again. I did find that there are issues when sculpt vertex colors are enabled. That's because of how `node_shader_gpu_vertex_color` is implemented currently.

blender-admin commented

2022-01-21 12:47:35 +01:00

This issue was referenced by f6888b530a

This issue was referenced by f6888b530ac81abbe61755971449ad6b42b93c82

Ryota Shichijo commented

2022-03-05 06:20:47 +01:00

Added subscriber: @Mallta