AssetBrowser: Indexing Asset Library #91406
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#91406
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Goal
Technical Requirements
.cache
folder)JSON
).Library full path Version number of the index format.
Per Asset inside the asset file:* IDName (including object type prefix)
Catelog ID(s). Meta data.
*** icon hash? if it cannot be extracted from the data already present.
Out of scope
We consider storing icons as part of the index, but it has not that many benefits and needs a lot of space (70k per icon).
Areas in the code
AssetList::fetch
triggersfilelist_readjob_start
.file list type = FILE_LOADLIB
for reading asset libraries stored.FileListInternEntry
is the data structure that we should be able to rebuild.NOTE: When moving the indexing too close to the
filelist_readjob_list_lib
the indexing makes less sense performance wise. When moving it to close toAssetList
there is a chance of code duplication and that indexes are rebuilt too many times (not per asset file, but per change in the asset library would trigger regenerating any index). The performance gain would be that we don't need toseek
in the blend file...Decisions
FILE_LOADLIB
, but only files that don't have an index are read./Blender/Assets/<assetlib_hash>_<assetlib_readable_name/<folder>/<assetfile>.index.json
for example.BLODataBlockInfo
struct.Changes
editors/space_file/...
add index callback functions/struct. Perhaps even in the job?editors/assets/intern/asset_index.cc
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscribers: @Jeroen-Bakker, @JulianEisel
Current design of the Asset Browser is: While showing any library that is not the Current File one, there always has to be an explicit refresh of the Asset Browser to get changes in the library to show up. I'd keep the same design here, we read the asset library data once and that's what the user gets to work with, until a reload is triggered.
I'm not sure what this means. I wouldn't expect the Asset Browser to refresh assets when an asset file is changed (detecting that isn't trivial). Or are you just talking about updating the index when a change is found while reading the library? Plus an extra operator to entirely reload the asset library index?
No, in the current design assets can be in only one catalog.
This issue was referenced by
fc7beac8d6
This issue was referenced by
70fd6a313e
This issue was referenced by
dbeab82a89
Added subscriber: @RedMser
Added subscriber: @slowburn
Added subscriber: @MaciejMorgas
Core stuff is in master. The rest don't have a high prio. And can be taken over by community/module.
Changed status from 'Confirmed' to: 'Resolved'
I'm going to close these parent tasks since there are just two smaller tasks remaining which can stand on their own, the parent tasks don't add much value (but may be confusing).
Does this mean that indexing should be working for end user already? Because I'm not seeing any improvement compared to earlier builds.
Added subscriber: @Deanna