Swap Tool Settings and Headers in Editors #91536
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
13 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#91536
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Some editors in Blender offer "tool settings". When tool settings are present, they are displayed on a higher hierarchical level than then editor menu (the header).
Since the header contains controls to define the working context (for example by defining the Mode) and tools are often dependent of the mode, it is more natural to move the headers to the higher level.
This change should affect every editor in Blender, as follows: from Tool settings -> Header to
Header -> Tool settings.
It would be appropriate to introduce this change at the beginning of the 3.x series.
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @fsiddi
Added subscriber: @Rusculleda
I hope this doesn't imply loosing the headers background transparency like in the mockup
Added subscriber: @Harley
This would lose the transparency on the header area, but add it on the tool settings, so the end result should be the same with the bottom portion being transparent if desired.
I'm more worried about the layout of items and that user might not be happy with a simple swap here. The parts shown in the captures above look fine, but other parts might look odd. For example the middle (horizontally) part of the header has Transform, Pivot, Snapping, etc. That works okay now because it is in the top area, but move it down the the empty space above it will be jarring. Similarly the "Options" now shown at the right corner would be confusing if suddenly tucked between the shading buttons and the navigation widget.
So you might want, for example, to move the middle items to the header and then change the "options" so that what it does is instead of the things it effects.
Note that the samples above also show changes to the Tool Settings area with text replacing (?) the icon of the selected tool. Not that I mind, but are these changes related to this? It seems like that change is more likely addressing the exact issues I've mentioned earlier. If the current tool settings are simply moved down they would conflict with the tools themselves is showing that icon. And without the text there would be alignment issues to consider as well.
I think this requires deeper thought and design.
I suggest to avoid background header transparency and keeping things simple. It can still be a themable option. When it comes to the text, that was a suggestion from Pablo and it can be considered later.
I think this is a fairly simple change to assess by testing a patch, rather than making several mockups. The concept is simple and I would prefer practical validation of the idea.
For context, I asked Harley if he could help with a test implementation.
Added subscriber: @JulienKaspar
Added subscriber: @ideasman42
This patch swaps the header order P2411.
Added subscriber: @dfelinto
Added builds here: https://builder.blender.org/download/patch/D12595/
I tested and showcased this at the Blender Studio, with positive responses. A couple of questions:
Created P2422 with text label & transform settings in tool-header, the headers alpha theme setting is used.
Notes:
Added subscriber: @HooglyBoogly
Added subscriber: @pablovazquez
Thanks for the update. A couple of additional comments (also from @pablovazquez):
Execution Region Background
theme setting. By default it should match the header background (the theme update for 3.0 can take this into account, later).Added subscriber: @tintwotin
^In a case like this with plenty of horizontal space and nothing in the center of the editor header, why not add tool options there? And only use double header height if there is a need for it?
Imo, does the double headers seem like excessive use of space in most cases ex.:
(Default vse workspace)
With the patch:
Submitted D12631, so the patch can be built by our build-bots.
Done, this is what I had in the original patch - so assume you mean to add this back.
This should really be handled in the layout engine, any workaround for this is quite hackish.
Labels use a large fixed margin, so using a percentage scale will clip longer text (some names are clipping at 85%).
I've made this into a popover, which has better scale and allows access tools even when the toolbar is hidden.
Ideally we would have better control over label margins though.
That was an oversight, fixed.
In the current patch only the tool-header can be made transparent by changing the "Header" alpha in the theme settings (matching current behavior where only one becomes transparent), are you saying you would want both headers to be transparent, controllable separately?
Not sure what is meant by this, they are already separate.
The tool-header can already be made transparent separately from the toolbar.
Can you show what you would like the final result to be by default? (details about how they are controlled can be changed separately, if its even needed).
Also, I'd rather toolbar theme tweaks be handled separately from swapping headers (since it doesn't seem closely related) - unless there is some good reason for this - it seems an arbitrary change to make when the proposed change is to swap headers.
Added subscriber: @RedMser
Thanks for the iteration and the fixes. In order to move forward with this, I suggest the following:
I hope you agree with the suggestions. If so, it would be great to see this updated merged!
Updated D12631, committed fix for label spacing
c7d94a7827
.Changed status from 'Confirmed' to: 'Resolved'
Committed
4cf4bb2664
, closing.Added subscriber: @CobraA
IMO it doesn't make sense to put the options below the popovers which are often used and since I use open menus on mouse hover things can get annoying quickly.
{F10698923 size = full}
Added subscriber: @Gilberto.R
There has been a lot of discussion around this in blender chat, and after testing 3.0 I realized some things look very odd. This needs more thought.
Some of the issues are:
Added subscriber: @AlbertoVelazquez
As the person who designed the tool header concept I have to say that it has completely broken the idea and its usability has been severely damaged by poorly argued reasons.
Seeing the result of the change my opinion in summary would be that it should be completely reversed. But I will expose the problems that have been generated that are much more than what has been improved.
I leave some more cons, but I believe that this is enough reason to revert a change that its only positive point is to have a more correct mental hierarchy from the perspective of a developer.
The original proposed design did contemplate the editing mode in a different place to what we have in 2.93 (something that I already exposed when it was implemented) and that surely relocating all the elements again could get something better. But sincerely seeing the null improvement in the UX and how users are left blind to basic options I think it would be better to reverse this improvement instead of wasting time trying to find a better solution based on iterate and iterate to finally reach a concept inferior to the current one.
Since the thread is closed I will quote the main developers to take into account all the problems I have discussed.
@ideasman42 @dfelinto @fsiddi
This comment was removed by @Gilberto.R
Thank you for the feedback @dcvertice. Some of it has been addressed by Dalai's commit. I was not aware about the fact that you designed the tool header concept.
Before suggesting this change I reached out to several stakeholders in the UI and tools team, as well as artists, and got positive reactions on it. The fact that tool settings display in some editors presents issues is a topic worth investigating, although it's not directly related to this change.
Hi @fsiddi In my experience it is very easy for people not to see the problems of a UI/UX in the future and only focus on the positive and visual part. Moreover, it is the most normal problem that we users have had with the UI/UX changes in blender since a few years ago and that has led to many revert and unnecessary changes if this had been taken into account. But if we talk about things that affect modelers it is normal that nobody in the environment close to the developers take into account the workflow and the implications in the whole UI system of blender and its philosophy.
As I said, I don't know what is the final idea with this change, because I can't find any mockup or document clarifying what they want to achieve. But actually this change has greatly spoiled the workflow of a modeler and is not taking into account what the tool settings is for, why it exists, how it is used and what are the implications of the current changes.
If you could explain me what is the real goal of all these changes I could try to create a mockup to put these goals inside the tool settings header design.
Which members of the UI Team did you discuss this with?
Added subscriber: @NXSK
I'm not satisffied with 3.0's new header. When windows become narrow, the new header can not show all the buttons on the right.
2.93
3.0
If I need a small window in 3.0, there will be a lot trouble sliding the header again and again.