Named Attribute Nodes #91742

Closed
opened 2021-09-27 12:40:31 +02:00 by Jacques Lucke · 20 comments
Member

Named attribute nodes weren't initially included in the fields design because there wasn't consensus about how they would interact with the "share-ability" design of the new workflow.
However, user feedback and testing has made it clear that the current attribute input and output options can exist alongside named attribute nodes, and the the flexibility is necessary.
Three new named attributes nodes will be added:

  • Remove Attribute
  • Named Attribute input node
  • Store Named Attribute like the capture attribute node, but creates a named attribute.

The nodes will initially be added behind an experimental feature flag, so that the visualization options can be further developed separately.
For the visualization and UX, there are a few separate tasks:

  • #96271 (Attribute search for named attribute input node)
  • #96273 (Named attribute modifier panel visualization)
  • #96275 (Named attribute node group visualization)

Past discussions about this topic:

Named attribute nodes weren't initially included in the fields design because there wasn't consensus about how they would interact with the "share-ability" design of the new workflow. However, user feedback and testing has made it clear that the current attribute input and output options can exist alongside named attribute nodes, and the the flexibility is necessary. Three new named attributes nodes will be added: - `Remove Attribute` - `Named Attribute` input node - `Store Named Attribute` like the capture attribute node, but creates a named attribute. The nodes will initially be added behind an experimental feature flag, so that the visualization options can be further developed separately. For the visualization and UX, there are a few separate tasks: - #96271 (Attribute search for named attribute input node) - #96273 (Named attribute modifier panel visualization) - #96275 (Named attribute node group visualization) --- Past discussions about this topic: - Most recent design discussion: https://devtalk.blender.org/t/2022-1-17-2022-01-21-geometry-nodes-sub-module-meetings/22527 - Arguments for named attributes: https://hackmd.io/3FhX6Bg7TdmR5LPuUQdk3g - Earlier named attribute proposal: https://devtalk.blender.org/t/shareable-named-attribute-node-proposal/20386
Author
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke

Added subscriber: @SteffenD

Added subscriber: @SteffenD
Hans Goudey changed title from Store Named Attribute node with mapping to Named Attribute Nodes 2022-02-02 18:10:03 +01:00
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @GeorgiaPacific

Added subscriber: @GeorgiaPacific

This issue was referenced by d4e46c13cc

This issue was referenced by d4e46c13cc92e01489a031a6afe6bafb5af5ca18

Added subscriber: @nl

Added subscriber: @nl

Added subscriber: @satishgoda1

Added subscriber: @satishgoda1

Added subscriber: @27Anonymous

Added subscriber: @27Anonymous

Named attributes will take precedence over data with the same attribute in Group Output node. I'm not sure if this is intentional, but it is a bit confusing and I think it would be more intuitive for attributes with the same name in the group output, to overwrite named attributes.

I believe I have also encountered a bug with this, or at least something weird.

This is the ending part of my geometry nodes setup:

2022-04-01-000313_1280x998_scrot.png

The numbers to the viewer node and the group output do not match, despite being from the same reroute node. This seems to originate from when the name attribute is retrieved and operated on. Named attribute node by itself works fine:

2022-04-01-000521_1280x998_scrot.png

And my combine XYZ, with static values of 64, 85.333, 1, also works fine:

2022-04-01-000700_1280x998_scrot.png

But as soon as I divide the named attribute by the static vector, it disappears from the value node, while remaining in the uv_map data:

2022-04-01-000829_1280x998_scrot.png

As I attempt to debug further, I notice that if I remove the extra view node, all the values turn to 0 in the UV map as well:

2022-04-01-000829_1280x998_scrot.png

I feel like something isn't connected right in the code, but it could also be me making a simple mistake and missing something.

Assuming this is a bug, I'm not sure if this should be reported here, or as a separate issue.

The reason I started using the profiler in the first place is that, strangely, the UV coordinates for this auto-UV-generator seem to be much smaller than they should be once they are converted from attributes and viewed in the UV editor. The upper part of this node setup resizes the UVs to be 1/64th scale on X, 1/(4096/48) scale on Y, but upon actually viewing it in the UV editor, they are 1/4096th size instead. This is more likely to just be a math issue on my part though.

Named attributes will take precedence over data with the same attribute in Group Output node. I'm not sure if this is intentional, but it is a bit confusing and I think it would be more intuitive for attributes with the same name in the group output, to overwrite named attributes. I believe I have also encountered a bug with this, or at least something weird. This is the ending part of my geometry nodes setup: ![2022-04-01-000313_1280x998_scrot.png](https://archive.blender.org/developer/F12961192/2022-04-01-000313_1280x998_scrot.png) The numbers to the viewer node and the group output do not match, despite being from the same reroute node. This seems to originate from when the name attribute is retrieved and operated on. Named attribute node by itself works fine: ![2022-04-01-000521_1280x998_scrot.png](https://archive.blender.org/developer/F12961196/2022-04-01-000521_1280x998_scrot.png) And my combine XYZ, with static values of 64, 85.333, 1, also works fine: ![2022-04-01-000700_1280x998_scrot.png](https://archive.blender.org/developer/F12961204/2022-04-01-000700_1280x998_scrot.png) But as soon as I divide the named attribute by the static vector, it disappears from the value node, while remaining in the uv_map data: ![2022-04-01-000829_1280x998_scrot.png](https://archive.blender.org/developer/F12961210/2022-04-01-000829_1280x998_scrot.png) As I attempt to debug further, I notice that if I remove the extra view node, all the values turn to 0 in the UV map as well: ![2022-04-01-000829_1280x998_scrot.png](https://archive.blender.org/developer/F12961212/2022-04-01-000829_1280x998_scrot.png) I feel like something isn't connected right in the code, but it could also be me making a simple mistake and missing something. Assuming this is a bug, I'm not sure if this should be reported here, or as a separate issue. The reason I started using the profiler in the first place is that, strangely, the UV coordinates for this auto-UV-generator seem to be much smaller than they should be once they are converted from attributes and viewed in the UV editor. The upper part of this node setup resizes the UVs to be 1/64th scale on X, 1/(4096/48) scale on Y, but upon actually viewing it in the UV editor, they are 1/4096th size instead. This is more likely to just be a math issue on my part though.

I'm leaning more towards user error now as it seems to work more consistently if I extract the data with another named attribute node:

2022-04-01-005938_1280x998_scrot.png

The performance without it is very strange though and should probably be a bit more consistent.

I'm leaning more towards user error now as it seems to work more consistently if I extract the data with another named attribute node: ![2022-04-01-005938_1280x998_scrot.png](https://archive.blender.org/developer/F12961272/2022-04-01-005938_1280x998_scrot.png) The performance without it is very strange though and should probably be a bit more consistent.

Making the nodes as follows makes the scale correctly be 1/64 instead of 1/4096:

2022-04-01-010327_1280x998_scrot.png

Making the nodes as follows makes the scale correctly be 1/64 instead of 1/4096: ![2022-04-01-010327_1280x998_scrot.png](https://archive.blender.org/developer/F12961280/2022-04-01-010327_1280x998_scrot.png)
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

If you think you've found a bug (it's hard to tell based on the screenshots), please report it separately like a regular report. Thanks!

If you think you've found a bug (it's hard to tell based on the screenshots), please report it separately like a regular report. Thanks!

This issue was referenced by 3e7ee3f3bc

This issue was referenced by 3e7ee3f3bcd61a1fb1395683ba7ecc430c9932db

Added subscriber: @Oliver-9

Added subscriber: @Oliver-9

Removed subscriber: @Oliver-9

Removed subscriber: @Oliver-9

Added subscriber: @Tams_3d

Added subscriber: @Tams_3d

Can the Remove Named Attribute Have the input socket like join geometry, so that many attributes can be removed at once, and we can feed the input as named attribute. This Was their at the Blender 2.93 Geometry Nodes

modeling_geometry-nodes_attribute_attribute-remove_node.png

Can the **Remove Named Attribute** Have the input socket like join geometry, so that many attributes can be removed at once, and we can feed the input as named attribute. This Was their at the Blender 2.93 Geometry Nodes ![modeling_geometry-nodes_attribute_attribute-remove_node.png](https://archive.blender.org/developer/F13082097/modeling_geometry-nodes_attribute_attribute-remove_node.png)
Member

We didn't implement it that way because it ended up being confusing that the socket accepted more than one input but you could only write one name in the string field. If we could find some way around that issue, I think it could be fine.

We didn't implement it that way because it ended up being confusing that the socket accepted more than one input but you could only write one name in the string field. If we could find some way around that issue, I think it could be fine.
Author
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Jacques Lucke self-assigned this 2022-10-20 15:20:02 +02:00
Thomas Dinges added this to the 3.3 LTS milestone 2023-02-08 15:37:47 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
10 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#91742
No description provided.