Crash on deleting driver #91912

New Issue

Tom Schönlau · 2021-10-03T13:59:53+02:00

Tom Schönlau commented

2021-10-03 13:59:53 +02:00

System Information
Operating system: Linux neo 5.10.68-1-MANJARO #1 SMP PREEMPT Wed Sep 22 12:29:47 UTC 2021 x86_64 GNU/Linux
Graphics card: nvidia GTX 970

Blender Version
Broken: (

3.0.0-alpha+master.a3027fb09416-linux.x86_64

)
Worked: (?)

I duplicated a Text strip via . I don't know where that driver on Location X came from. The original didn't have one. I then wanted to delete that driver. After deleting it and moving the current frame blender crashed.

Exact steps for others to reproduce the error

Load attached file
Delete driver of 'Location X'
Press Cursor keys Left/Right a few times till crash.
crash.blend

**System Information** Operating system: Linux neo 5.10.68-1-MANJARO #1 SMP PREEMPT Wed Sep 22 12:29:47 UTC 2021 x86_64 GNU/Linux Graphics card: nvidia GTX 970 **Blender Version** Broken: ( ``` 3.0.0-alpha+master.a3027fb09416-linux.x86_64 ``` ) Worked: (?) I duplicated a Text strip via <shift><D>. I don't know where that driver on Location X came from. The original didn't have one. I then wanted to delete that driver. After deleting it and moving the current frame blender crashed. **Exact steps for others to reproduce the error** - Load attached file - Delete driver of 'Location X' - Press Cursor keys Left/Right a few times till crash. [crash.blend](https://archive.blender.org/developer/F10747275/crash.blend)

Tom Schönlau commented

2021-10-03 13:59:53 +02:00

Added subscriber: @Lexx

Germano Cavalcante commented

2021-10-04 18:36:15 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-10-04 18:36:15 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2021-10-04 18:36:15 +02:00

Thanks for the report, I can confirm with either the latest stable or current development versions of Blender.
Perhaps the stack trace is not accurate due to a Release Bug, but the crash apparently happens in BKE_animsys_eval_driver due to FCurve being NULL.

Thanks for the report, I can confirm with either the latest stable or current development versions of Blender. Perhaps the stack trace is not accurate due to a Release Bug, but the crash apparently happens in `BKE_animsys_eval_driver` due to `FCurve` being `NULL`.

Sybren A. Stüvel self-assigned this 2021-11-26 11:09:28 +01:00

Sybren A. Stüvel commented

2021-11-26 11:12:06 +01:00

Interestingly, I can't even open this file with a debug build of Blender:

BLI_assert failed: source/blender/sequencer/intern/effects.c:3804, SEQ_effect_text_font_load(), at 'BLI_thread_is_main()'

It would seem there are two drivers with identical paths:

>>> [(d.data_path, d.array_index) for d in C.scene.animation_data.drivers]

[('sequence_editor.sequences_all["Text_klein.011"].location', 0), ('sequence_editor.sequences_all["Text_klein.011"].location', 0)]

Furthermore, using {key Shift+D} to duplicate the strip doesn't duplicate the drivers, but moves them to the new duplicate.

Interestingly, I can't even open this file with a debug build of Blender: ``` BLI_assert failed: source/blender/sequencer/intern/effects.c:3804, SEQ_effect_text_font_load(), at 'BLI_thread_is_main()' ``` It would seem there are two drivers with identical paths: ``` >>> [(d.data_path, d.array_index) for d in C.scene.animation_data.drivers] [('sequence_editor.sequences_all["Text_klein.011"].location', 0), ('sequence_editor.sequences_all["Text_klein.011"].location', 0)] ``` Furthermore, using {key Shift+D} to duplicate the strip doesn't duplicate the drivers, but moves them to the new duplicate.

Sybren A. Stüvel commented

2021-11-26 11:14:12 +01:00

Added subscriber: @iss

Sybren A. Stüvel removed their assignment 2021-11-26 15:37:14 +01:00

Sybren A. Stüvel commented

2021-11-26 15:37:14 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2021-11-26 15:37:15 +01:00

Some technical info for when @iss has time to look into this:

This fixes the crash, but not the root cause:

diff --git a/source/blender/blenkernel/intern/anim_sys.c b/source/blender/blenkernel/intern/anim_sys.c
index cbdcf43c039..45541a7636b 100644
--- a/source/blender/blenkernel/intern/anim_sys.c
+++ b/source/blender/blenkernel/intern/anim_sys.c
@@ -3540,6 +3540,12 @@ void BKE_animsys_eval_driver(Depsgraph *depsgraph, ID *id, int driver_index, FCu
     fcu = BLI_findlink(&adt->drivers, driver_index);
   }
 
+  if (!fcu) {
+    /* This can happen in certain cases, unsure what is the root cause. At least
+     * this prevents Blender from crashing. See T91912. */
+    return;
+  }
+
   DEG_debug_print_eval_subdata_index(
       depsgraph, __func__, id->name, id, "fcu", fcu->rna_path, fcu, fcu->array_index);

This fixes the issue where duplication of a strip moves its drivers to the duplicate:

diff --git a/source/blender/editors/space_sequencer/sequencer_edit.c b/source/blender/editors/space_sequencer/sequencer_edit.c
index 899c2f6b4f4..347a5cdfca9 100644
--- a/source/blender/editors/space_sequencer/sequencer_edit.c
+++ b/source/blender/editors/space_sequencer/sequencer_edit.c
@@ -1655,7 +1655,8 @@ static int sequencer_add_duplicate_exec(bContext *C, wmOperator *UNUSED(op))
   Sequence *active_seq = SEQ_select_active_get(scene);
   ListBase duplicated = {NULL, NULL};
 
-  SEQ_sequence_base_dupli_recursive(scene, scene, &duplicated, ed->seqbasep, 0, 0);
+  SEQ_sequence_base_dupli_recursive(
+      scene, scene, &duplicated, ed->seqbasep, SEQ_DUPE_UNIQUE_NAME, 0);
   ED_sequencer_deselect_all(scene);
 
   if (duplicated.first) {

The actual root cause of the crash has something to do with the sequencer prefetching process. It may need to be restarted after a change to the drivers, as that triggers a rebuild of the main depsgraph (but not yet of the separate depsgraph used for prefetching).

Some technical info for when @iss has time to look into this: This fixes the crash, but not the root cause: ``` diff --git a/source/blender/blenkernel/intern/anim_sys.c b/source/blender/blenkernel/intern/anim_sys.c index cbdcf43c039..45541a7636b 100644 --- a/source/blender/blenkernel/intern/anim_sys.c +++ b/source/blender/blenkernel/intern/anim_sys.c @@ -3540,6 +3540,12 @@ void BKE_animsys_eval_driver(Depsgraph *depsgraph, ID *id, int driver_index, FCu fcu = BLI_findlink(&adt->drivers, driver_index); } + if (!fcu) { + /* This can happen in certain cases, unsure what is the root cause. At least + * this prevents Blender from crashing. See T91912. */ + return; + } + DEG_debug_print_eval_subdata_index( depsgraph, __func__, id->name, id, "fcu", fcu->rna_path, fcu, fcu->array_index); ``` This fixes the issue where duplication of a strip moves its drivers to the duplicate: ``` diff --git a/source/blender/editors/space_sequencer/sequencer_edit.c b/source/blender/editors/space_sequencer/sequencer_edit.c index 899c2f6b4f4..347a5cdfca9 100644 --- a/source/blender/editors/space_sequencer/sequencer_edit.c +++ b/source/blender/editors/space_sequencer/sequencer_edit.c @@ -1655,7 +1655,8 @@ static int sequencer_add_duplicate_exec(bContext *C, wmOperator *UNUSED(op)) Sequence *active_seq = SEQ_select_active_get(scene); ListBase duplicated = {NULL, NULL}; - SEQ_sequence_base_dupli_recursive(scene, scene, &duplicated, ed->seqbasep, 0, 0); + SEQ_sequence_base_dupli_recursive( + scene, scene, &duplicated, ed->seqbasep, SEQ_DUPE_UNIQUE_NAME, 0); ED_sequencer_deselect_all(scene); if (duplicated.first) { ``` The actual root cause of the crash has something to do with the sequencer prefetching process. It may need to be restarted after a change to the drivers, as that triggers a rebuild of the main depsgraph (but not yet of the separate depsgraph used for prefetching).

Richard Antalik commented

2021-11-27 02:30:15 +01:00

The root issue is not exclusive to prefetching. Consider this VSE-free example:
T91912_no_VSE.blend

Render animation
While rendering, delete driver from scene volume in Scene Properties
This causes same crash as prefetch does.

So far I can see that render pipeline depsgraph does not update relations when change to original ID is done

When driver is deleted during rendering I get following logs:
P2620: (An Untitled Masterwork)

DEG_relations_tag_update: Tagging relations for update.
[SCScene :: ViewLayer]: DEG_graph_tag_relations_update: Tagging relations for update.
[RENDER PIPELINE]: DEG_graph_tag_relations_update: Tagging relations for update.
[RENDER]: DEG_graph_tag_relations_update: Tagging relations for update.
graph_id_tag_update: id=SCScene flags=COPY_ON_WRITE source=RELATIONS
[SCScene :: ViewLayer]: Removed 24 relations to no-op nodes
Depsgraph built in 0.003472 seconds.
[SCScene :: ViewLayer]: Operation is entry point for update: SEQUENCES_EVAL()
[SCScene :: ViewLayer]: Operation is entry point for update: AUDIO_VOLUME()
[SCScene :: ViewLayer]: Operation is entry point for update: SOUND_EVAL()
[SCScene :: ViewLayer]: Operation is entry point for update: PARAMETERS_EXIT()
[SCScene :: ViewLayer]: Operation is entry point for update: SCENE_EVAL()
[SCScene :: ViewLayer]: Operation is entry point for update: PARAMETERS_ENTRY()
[SCScene :: ViewLayer]: Operation is entry point for update: COPY_ON_WRITE()
[SCScene :: ViewLayer]: Operation is entry point for update: VIEW_LAYER_EVAL()
[SCScene :: ViewLayer]: Operation is entry point for update: AUDIO_ENTRY()
[SCScene :: ViewLayer]: Operation is entry point for update: PARAMETERS_EVAL()
[SCScene :: ViewLayer]: Accumulated recalc bits for SCScene: 8192
[SCScene :: ViewLayer]: Accumulated recalc bits for OBCube: 0
[SCScene :: ViewLayer]: Accumulated recalc bits for OBLight: 0
[SCScene :: ViewLayer]: Accumulated recalc bits for OBCamera: 0
[SCScene :: ViewLayer]: deg_evaluate_copy_on_write on SCScene (000001B183AD5D38)
[SCScene :: ViewLayer]: SEQ_eval_sequences on SCScene (000001B183AD5D38)
[SCScene :: ViewLayer]: layer_eval_view_layer on ViewLayer (000001B1FEA3C568)
[SCScene :: ViewLayer]: BKE_object_eval_eval_base_flags on OBCube (000001B188E8DE78)
[SCScene :: ViewLayer]: BKE_object_eval_eval_base_flags on OBLight (000001B188E898B8)
[SCScene :: ViewLayer]: BKE_object_eval_eval_base_flags on OBCamera (000001B188E8CD08)
Depsgraph updated in 0.009662 seconds.
Depsgraph evaluation FPS: 0.044815
Saved: 'C:\tmp\0012.png'
 Time: 00:00.53 (Saving: 00:00.38)

[RENDER PIPELINE]: Operation is entry point for update: AUDIO_VOLUME()
[RENDER PIPELINE]: Operation is entry point for update: PARAMETERS_EVAL()
[RENDER PIPELINE]: Operation is entry point for update: PARAMETERS_EXIT()
[RENDER PIPELINE]: Operation is entry point for update: DRIVER(audio_volume)
[RENDER PIPELINE]: Operation is entry point for update: COPY_ON_WRITE()
[RENDER PIPELINE]: Operation is entry point for update: PARAMETERS_ENTRY()
[RENDER PIPELINE]: Operation is entry point for update: SEQUENCES_EVAL()
[RENDER PIPELINE]: Operation is entry point for update: SOUND_EVAL()
[RENDER PIPELINE]: Operation is entry point for update: AUDIO_ENTRY()
[RENDER PIPELINE]: Operation is entry point for update: SCENE_EVAL()
[RENDER PIPELINE]: Accumulated recalc bits for SCScene: 139264
[RENDER PIPELINE]: deg_evaluate_copy_on_write on SCScene (000001B1839E2AA8)
[RENDER PIPELINE]: BKE_animsys_eval_driver on SCScene (000001B1839E2AA8) fcu (null)- [x] (0000000000000000)
[RENDER PIPELINE]: SEQ_eval_sequences on SCScene (000001B1839E2AA8)
Depsgraph updated in 0.005622 seconds.
Depsgraph evaluation FPS: 0.108317
graph_id_tag_update: id=SCScene flags=COPY_ON_WRITE source=RELATIONS
[RENDER]: Removed 24 relations to no-op nodes
Depsgraph built in 0.003126 seconds.
[RENDER]: Operation is entry point for update: PARAMETERS_EVAL()
[RENDER]: Operation is entry point for update: SOUND_EVAL()
[RENDER]: Operation is entry point for update: PARAMETERS_ENTRY()
[RENDER]: Operation is entry point for update: AUDIO_ENTRY()
[RENDER]: Operation is entry point for update: SEQUENCES_EVAL()
[RENDER]: Operation is entry point for update: AUDIO_VOLUME()
[RENDER]: Operation is entry point for update: COPY_ON_WRITE()
[RENDER]: Operation is entry point for update: PARAMETERS_EXIT()
[RENDER]: Operation is entry point for update: VIEW_LAYER_EVAL()
[RENDER]: Operation is entry point for update: SCENE_EVAL()
[RENDER]: Accumulated recalc bits for SCScene: 8192
[RENDER]: Accumulated recalc bits for OBCube: 0
[RENDER]: Accumulated recalc bits for OBLight: 0
[RENDER]: Accumulated recalc bits for OBCamera: 0
[RENDER]: deg_evaluate_copy_on_write on SCScene (000001B18BD254C8)
[RENDER]: SEQ_eval_sequences on SCScene (000001B18BD254C8)
[RENDER]: layer_eval_view_layer on ViewLayer (000001B1FEA3AC48)
[RENDER]: BKE_object_eval_eval_base_flags on OBCube (000001B188FDEE08)
[RENDER]: BKE_object_eval_eval_base_flags on OBLight (000001B188FDB3E8)
[RENDER]: BKE_object_eval_eval_base_flags on OBCamera (000001B188FDBF88)
Depsgraph updated in 0.008620 seconds.
Depsgraph evaluation FPS: 0.110033

It is evident, that SCScene :: ViewLayer was correctly updated, but RENDER PIPELINE was not, and BKE_animsys_eval_driver will cause crash.

Both render pipeline and prefetch would crash if I try to call DEG_graph_relations_update which I assume would resolve this issue, but not sure if this is limitation of this type of dependency graph.

As far as driver appearing "out of nowhere" - This may be issue with strip duplication code, but this should be reported as separate issue. SEQ_DUPE_UNIQUE_NAME is not used in current code, because it does copy animation data by design. This means that strips are duplicated with same name to detached ListBase, then merge them one by one ensuring correct names, selection state and mapping animation data for duplicated strips.

@Lexx can you create new report with example file demonstrating how driver appears while you don't expect that to happen?

The root issue is not exclusive to prefetching. Consider this VSE-free example: [T91912_no_VSE.blend](https://archive.blender.org/developer/F12346650/T91912_no_VSE.blend) - Render animation - While rendering, delete driver from scene volume in Scene Properties This causes same crash as prefetch does. So far I can see that render pipeline depsgraph does not update relations when change to original ID is done When driver is deleted during rendering I get following logs: [P2620: (An Untitled Masterwork)](https://archive.blender.org/developer/P2620.txt) ``` DEG_relations_tag_update: Tagging relations for update. [SCScene :: ViewLayer]: DEG_graph_tag_relations_update: Tagging relations for update. [RENDER PIPELINE]: DEG_graph_tag_relations_update: Tagging relations for update. [RENDER]: DEG_graph_tag_relations_update: Tagging relations for update. graph_id_tag_update: id=SCScene flags=COPY_ON_WRITE source=RELATIONS [SCScene :: ViewLayer]: Removed 24 relations to no-op nodes Depsgraph built in 0.003472 seconds. [SCScene :: ViewLayer]: Operation is entry point for update: SEQUENCES_EVAL() [SCScene :: ViewLayer]: Operation is entry point for update: AUDIO_VOLUME() [SCScene :: ViewLayer]: Operation is entry point for update: SOUND_EVAL() [SCScene :: ViewLayer]: Operation is entry point for update: PARAMETERS_EXIT() [SCScene :: ViewLayer]: Operation is entry point for update: SCENE_EVAL() [SCScene :: ViewLayer]: Operation is entry point for update: PARAMETERS_ENTRY() [SCScene :: ViewLayer]: Operation is entry point for update: COPY_ON_WRITE() [SCScene :: ViewLayer]: Operation is entry point for update: VIEW_LAYER_EVAL() [SCScene :: ViewLayer]: Operation is entry point for update: AUDIO_ENTRY() [SCScene :: ViewLayer]: Operation is entry point for update: PARAMETERS_EVAL() [SCScene :: ViewLayer]: Accumulated recalc bits for SCScene: 8192 [SCScene :: ViewLayer]: Accumulated recalc bits for OBCube: 0 [SCScene :: ViewLayer]: Accumulated recalc bits for OBLight: 0 [SCScene :: ViewLayer]: Accumulated recalc bits for OBCamera: 0 [SCScene :: ViewLayer]: deg_evaluate_copy_on_write on SCScene (000001B183AD5D38) [SCScene :: ViewLayer]: SEQ_eval_sequences on SCScene (000001B183AD5D38) [SCScene :: ViewLayer]: layer_eval_view_layer on ViewLayer (000001B1FEA3C568) [SCScene :: ViewLayer]: BKE_object_eval_eval_base_flags on OBCube (000001B188E8DE78) [SCScene :: ViewLayer]: BKE_object_eval_eval_base_flags on OBLight (000001B188E898B8) [SCScene :: ViewLayer]: BKE_object_eval_eval_base_flags on OBCamera (000001B188E8CD08) Depsgraph updated in 0.009662 seconds. Depsgraph evaluation FPS: 0.044815 Saved: 'C:\tmp\0012.png' Time: 00:00.53 (Saving: 00:00.38) [RENDER PIPELINE]: Operation is entry point for update: AUDIO_VOLUME() [RENDER PIPELINE]: Operation is entry point for update: PARAMETERS_EVAL() [RENDER PIPELINE]: Operation is entry point for update: PARAMETERS_EXIT() [RENDER PIPELINE]: Operation is entry point for update: DRIVER(audio_volume) [RENDER PIPELINE]: Operation is entry point for update: COPY_ON_WRITE() [RENDER PIPELINE]: Operation is entry point for update: PARAMETERS_ENTRY() [RENDER PIPELINE]: Operation is entry point for update: SEQUENCES_EVAL() [RENDER PIPELINE]: Operation is entry point for update: SOUND_EVAL() [RENDER PIPELINE]: Operation is entry point for update: AUDIO_ENTRY() [RENDER PIPELINE]: Operation is entry point for update: SCENE_EVAL() [RENDER PIPELINE]: Accumulated recalc bits for SCScene: 139264 [RENDER PIPELINE]: deg_evaluate_copy_on_write on SCScene (000001B1839E2AA8) [RENDER PIPELINE]: BKE_animsys_eval_driver on SCScene (000001B1839E2AA8) fcu (null)- [x] (0000000000000000) [RENDER PIPELINE]: SEQ_eval_sequences on SCScene (000001B1839E2AA8) Depsgraph updated in 0.005622 seconds. Depsgraph evaluation FPS: 0.108317 graph_id_tag_update: id=SCScene flags=COPY_ON_WRITE source=RELATIONS [RENDER]: Removed 24 relations to no-op nodes Depsgraph built in 0.003126 seconds. [RENDER]: Operation is entry point for update: PARAMETERS_EVAL() [RENDER]: Operation is entry point for update: SOUND_EVAL() [RENDER]: Operation is entry point for update: PARAMETERS_ENTRY() [RENDER]: Operation is entry point for update: AUDIO_ENTRY() [RENDER]: Operation is entry point for update: SEQUENCES_EVAL() [RENDER]: Operation is entry point for update: AUDIO_VOLUME() [RENDER]: Operation is entry point for update: COPY_ON_WRITE() [RENDER]: Operation is entry point for update: PARAMETERS_EXIT() [RENDER]: Operation is entry point for update: VIEW_LAYER_EVAL() [RENDER]: Operation is entry point for update: SCENE_EVAL() [RENDER]: Accumulated recalc bits for SCScene: 8192 [RENDER]: Accumulated recalc bits for OBCube: 0 [RENDER]: Accumulated recalc bits for OBLight: 0 [RENDER]: Accumulated recalc bits for OBCamera: 0 [RENDER]: deg_evaluate_copy_on_write on SCScene (000001B18BD254C8) [RENDER]: SEQ_eval_sequences on SCScene (000001B18BD254C8) [RENDER]: layer_eval_view_layer on ViewLayer (000001B1FEA3AC48) [RENDER]: BKE_object_eval_eval_base_flags on OBCube (000001B188FDEE08) [RENDER]: BKE_object_eval_eval_base_flags on OBLight (000001B188FDB3E8) [RENDER]: BKE_object_eval_eval_base_flags on OBCamera (000001B188FDBF88) Depsgraph updated in 0.008620 seconds. Depsgraph evaluation FPS: 0.110033 ``` It is evident, that `SCScene :: ViewLayer` was correctly updated, but `RENDER PIPELINE` was not, and `BKE_animsys_eval_driver` will cause crash. Both render pipeline and prefetch would crash if I try to call `DEG_graph_relations_update` which I assume would resolve this issue, but not sure if this is limitation of this type of dependency graph. As far as driver appearing "out of nowhere" - This may be issue with strip duplication code, but this should be reported as separate issue. `SEQ_DUPE_UNIQUE_NAME` is not used in current code, because it does copy animation data by design. This means that strips are duplicated with same name to detached `ListBase`, then merge them one by one ensuring correct names, selection state and mapping animation data for duplicated strips. @Lexx can you create new report with example file demonstrating how driver appears while you don't expect that to happen?

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash on deleting driver #91912