Crash when undo the operator which contains load img action #92016

New Issue

yonghao lv · 2021-10-07T19:22:23+02:00

yonghao lv commented

2021-10-07 19:22:23 +02:00

System Information
Operating system: Windows-10-10.0.22471-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-10-06 22:38, hash: 439c9b0b84
Worked: blender 2.93.2 (haven't test 2.93.5 or other version)

Short description of error
Crash when undo the operate which contains load img action (bl_option "UNDO" not working)
2021-10-08 01-24-26.mp4

Exact steps for others to reproduce the error
use addon import img as plane to load an image, undo with ctrl z, crash
load an image in the texture property, undo crash
load an image as references(empty), undo crash

**System Information** Operating system: Windows-10-10.0.22471-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-10-06 22:38, hash: `439c9b0b84` Worked: blender 2.93.2 (haven't test 2.93.5 or other version) **Short description of error** Crash when undo the operate which contains load img action (bl_option "UNDO" not working) [2021-10-08 01-24-26.mp4](https://archive.blender.org/developer/F10848343/2021-10-08_01-24-26.mp4) **Exact steps for others to reproduce the error** use addon import img as plane to load an image, undo with ctrl z, crash load an image in the texture property, undo crash load an image as references(empty), undo crash

yonghao lv commented

2021-10-07 19:22:23 +02:00

Added subscriber: @1029910278

Germano Cavalcante commented

2021-10-08 17:00:56 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2021-10-08 17:00:56 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2021-10-08 17:00:56 +02:00

Thanks for the report, I can confirm the crash.
This is something recently introduced between 29e48f2df5 (13-Aug) and d046a1f2fa (26-Sep).
I'll bisect tomorrow (when I have the PC available).

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   ???                           	0x000000003c2aacc0 0 + 1009429696
1   org.blenderfoundation.blender 	0x00000001006c7900 BKE_image_free_buffers_ex + 160
2   org.blenderfoundation.blender 	0x00000001006c7970 image_free_data + 28
3   org.blenderfoundation.blender 	0x00000001006e6798 BKE_id_free_ex + 252
4   org.blenderfoundation.blender 	0x00000001006effd4 BKE_main_free + 356
5   org.blenderfoundation.blender 	0x00000001005f1414 BKE_blender_globals_clear + 28
6   org.blenderfoundation.blender 	0x00000001005f2658 BKE_blendfile_read_setup_ex + 824
7   org.blenderfoundation.blender 	0x00000001005f1fac BKE_memfile_undo_decode + 196
8   org.blenderfoundation.blender 	0x000000010131994c memfile_undosys_step_decode + 144
9   org.blenderfoundation.blender 	0x00000001007f277c undosys_step_decode + 328
10  org.blenderfoundation.blender 	0x00000001007f25a4 BKE_undosys_step_load_data_ex + 684
11  org.blenderfoundation.blender 	0x00000001013180b0 ed_undo_step_direction + 252
12  org.blenderfoundation.blender 	0x0000000101318534 ed_undo_exec + 44
13  org.blenderfoundation.blender 	0x00000001009ff5c4 wm_operator_invoke + 400
14  org.blenderfoundation.blender 	0x0000000100a00b90 wm_handler_operator_call + 540
15  org.blenderfoundation.blender 	0x0000000100a00138 wm_handlers_do_intern + 1592
16  org.blenderfoundation.blender 	0x00000001009fc0f8 wm_handlers_do + 44
17  org.blenderfoundation.blender 	0x00000001009fbd2c wm_event_do_handlers + 2936
18  org.blenderfoundation.blender 	0x00000001009f45bc WM_main + 36
19  org.blenderfoundation.blender 	0x00000001005ba174 main + 924
20  libdyld.dylib                 	0x0000000194cbd430 start + 4

Thanks for the report, I can confirm the crash. This is something recently introduced between `29e48f2df5` (13-Aug) and `d046a1f2fa` (26-Sep). I'll bisect tomorrow (when I have the PC available). ``` Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 ??? 0x000000003c2aacc0 0 + 1009429696 1 org.blenderfoundation.blender 0x00000001006c7900 BKE_image_free_buffers_ex + 160 2 org.blenderfoundation.blender 0x00000001006c7970 image_free_data + 28 3 org.blenderfoundation.blender 0x00000001006e6798 BKE_id_free_ex + 252 4 org.blenderfoundation.blender 0x00000001006effd4 BKE_main_free + 356 5 org.blenderfoundation.blender 0x00000001005f1414 BKE_blender_globals_clear + 28 6 org.blenderfoundation.blender 0x00000001005f2658 BKE_blendfile_read_setup_ex + 824 7 org.blenderfoundation.blender 0x00000001005f1fac BKE_memfile_undo_decode + 196 8 org.blenderfoundation.blender 0x000000010131994c memfile_undosys_step_decode + 144 9 org.blenderfoundation.blender 0x00000001007f277c undosys_step_decode + 328 10 org.blenderfoundation.blender 0x00000001007f25a4 BKE_undosys_step_load_data_ex + 684 11 org.blenderfoundation.blender 0x00000001013180b0 ed_undo_step_direction + 252 12 org.blenderfoundation.blender 0x0000000101318534 ed_undo_exec + 44 13 org.blenderfoundation.blender 0x00000001009ff5c4 wm_operator_invoke + 400 14 org.blenderfoundation.blender 0x0000000100a00b90 wm_handler_operator_call + 540 15 org.blenderfoundation.blender 0x0000000100a00138 wm_handlers_do_intern + 1592 16 org.blenderfoundation.blender 0x00000001009fc0f8 wm_handlers_do + 44 17 org.blenderfoundation.blender 0x00000001009fbd2c wm_event_do_handlers + 2936 18 org.blenderfoundation.blender 0x00000001009f45bc WM_main + 36 19 org.blenderfoundation.blender 0x00000001005ba174 main + 924 20 libdyld.dylib 0x0000000194cbd430 start + 4 ```

Bastien Montagne commented

2021-10-08 18:02:23 +02:00

Added subscribers: @Jeroen-Bakker, @mont29

Bastien Montagne commented

2021-10-08 18:02:23 +02:00

Crash introduced by 2b2d427bba. CC @Jeroen-Bakker

Crash introduced by 2b2d427bba. CC @Jeroen-Bakker

Evan Wilson commented

2021-10-09 21:32:43 +02:00

Added subscribers: @you.le, @EAW

Evan Wilson commented

2021-10-09 21:32:43 +02:00

This is already being tracked in #91294 (Draw: Crash on undo after adding new texture), so I’ll merge this report into that one. Given @you.le’s UPBGE patch here, it appears the culprit is a missing [slot] on line 215 of image.c

This is already being tracked in #91294 (Draw: Crash on undo after adding new texture), so I’ll merge this report into that one. Given @you.le’s [UPBGE patch here](https://github.com/UPBGE/upbge/commit/2b3b35c66149b312d296cf4bb372d36329dbed86), it appears the culprit is a missing `[slot]` on line 215 of image.c

Evan Wilson commented

2021-10-09 21:33:31 +02:00

Closed as duplicate of #91294

Evan Wilson closed this issue

2021-10-09 21:33:31 +02:00

Thomas Dinges added this to the 3.0 milestone 2023-02-08 15:58:50 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when undo the operator which contains load img action #92016