No undo when moving viewport with camera locked to view #92099

New Issue

stib · 2021-10-11T01:41:24+02:00

stib commented

2021-10-11 01:41:24 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: Quadro P5000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: a791bdabd0
Worked: (newest version of Blender that worked as expected)

Short description of error
When the camera is locked to the viewport, moving the viewport with the MMB moves the camera, as expected. However there is no undo if the user accidentally moves the viewport (which happens all the time).

Exact steps for others to reproduce the error
in the N side-menu check view>Lock>Camera to View
hit 0 to enter camera view in a 3D viewport
rotate the view with the MMB
Undo
Expected: camera goes back to default position
Observed: camera stays in niew position

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: Quadro P5000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12 **Blender Version** Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: `a791bdabd0` Worked: (newest version of Blender that worked as expected) **Short description of error** When the camera is locked to the viewport, moving the viewport with the MMB moves the camera, as expected. However there is no undo if the user accidentally moves the viewport (which happens all the time). **Exact steps for others to reproduce the error** in the N side-menu check view>Lock>Camera to View hit 0 to enter camera view in a 3D viewport rotate the view with the MMB Undo Expected: camera goes back to default position Observed: camera stays in niew position

stib commented

2021-10-11 01:41:24 +02:00

Added subscriber: @stibbot

blender-admin commented

2021-10-11 01:41:24 +02:00

#71435 was marked as duplicate of this issue

kursad k commented

2021-10-11 03:34:49 +02:00

Added subscriber: @kursadk

kursad k commented

2021-10-11 03:34:49 +02:00

I can confirm this as well, sometimes the camerta undo is possible and sometimes it is not possible.

Philipp Oeser commented

2021-10-29 16:56:53 +02:00

Added subscribers: @JulianEisel, @mont29, @lichtwerk

Philipp Oeser commented

2021-10-29 16:56:53 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-10-29 16:56:53 +02:00

Quick talk to @JulianEisel and @mont29 and (even though an edge case), can be confirmed, yes.

pan beep commented

2021-12-30 11:10:00 +01:00

Added subscriber: @MrBeep

pan beep commented

2021-12-30 11:10:00 +01:00

Same in 3.0 released on december 03 2021. Undo does not work when camera was moved with mouse or works as described in original post.

Pratik Borhade commented

2022-06-03 20:11:48 +02:00

Added subscriber: @PratikPB2123

Max Edge commented

2022-06-04 18:10:10 +02:00

Added subscriber: @Max-49

Pratik Borhade self-assigned this 2022-07-02 08:11:31 +02:00

Julien Kaspar commented

2022-07-02 14:36:39 +02:00

Added subscriber: @JulienKaspar

Philipp Oeser commented

2022-07-04 11:51:42 +02:00

Added subscribers: @popqjp, @dr.sybren, @BassamKurdali, @momoSnack, @mano-wii

Philipp Oeser commented

2022-07-04 11:52:14 +02:00

In #71435#1284453, @lichtwerk wrote:
Lets put it that way: Should there be an undo push? Yes or No?
I can see both behaviors be somewhat problematic.
If we add an undo push here, we'll get many undo steps by view rotation (possibly also leading to unwanted behavior when working with operators).
Or is the user expected to not use Camera to View in that case?

Might be related to @BassamKurdali mentioning that autokey is not working in that scenario in https://devtalk.blender.org/t/2021-12-23-animation-rigging-module-meeting/22042

> In #71435#1284453, @lichtwerk wrote: > Lets put it that way: *Should there be an undo push? Yes or No?* > I can see both behaviors be somewhat problematic. > If we add an undo push here, we'll get many undo steps by view rotation (possibly also leading to unwanted behavior when working with operators). > Or is the user expected to not use `Camera to View` in that case? > > Might be related to @BassamKurdali mentioning that autokey is not working in that scenario in https://devtalk.blender.org/t/2021-12-23-animation-rigging-module-meeting/22042

Sybren A. Stüvel commented

2022-07-12 12:33:51 +02:00

In #71435#1284453, @lichtwerk wrote:
Lets put it that way: Should there be an undo push? Yes or No?
I can see both behaviors be somewhat problematic.
If we add an undo push here, we'll get many undo steps by view rotation (possibly also leading to unwanted behavior when working with operators).

Good point. @mont29 is it possible to do an "undo push" only on the first camera motion, and then an "undo overwrite" (if there is such a thing) on subsequent movements?

> In #71435#1284453, @lichtwerk wrote: > Lets put it that way: *Should there be an undo push? Yes or No?* > I can see both behaviors be somewhat problematic. > If we add an undo push here, we'll get many undo steps by view rotation (possibly also leading to unwanted behavior when working with operators). Good point. @mont29 is it possible to do an "undo push" only on the first camera motion, and then an "undo overwrite" (if there is such a thing) on subsequent movements?

Pratik Borhade commented

2022-07-12 13:43:03 +02:00

@dr.sybren , maybe you're looking for ED_undo_grouped_push?

@dr.sybren , maybe you're looking for `ED_undo_grouped_push`?

Bastien Montagne commented

2022-07-14 12:54:46 +02:00

Added subscriber: @ideasman42

Bastien Montagne commented

2022-07-14 12:54:46 +02:00

Yes, I think there should be undo push in case a camera is locked to the view, when transforming the view.

If we add an undo push here, we'll get many undo steps by view rotation (possibly also leading to unwanted behavior when working with operators).

Not sure I understand this, this is a modal operator right? So there should be only one undo step in the end, once the modal operation is validated. Of course if the user does ten different view rotation, there will be ten undo steps, but that's no different in the end that transforming the camera ten times in a row...

What may be difficult here is to only do the undo push when the camera is locked to the view, and not otherwise. Might need some changes to how we do undo step, and maybe a new callback in operator type (to say if there should be undo step or not)? @ideasman42 would probably know better here though.

Yes, I think there should be undo push in case a camera is locked to the view, when transforming the view. > If we add an undo push here, we'll get many undo steps by view rotation (possibly also leading to unwanted behavior when working with operators). Not sure I understand this, this is a modal operator right? So there should be only one undo step in the end, once the modal operation is validated. Of course if the user does ten different view rotation, there will be ten undo steps, but that's no different in the end that transforming the camera ten times in a row... What may be difficult here is to only do the undo push when the camera is locked to the view, and not otherwise. Might need some changes to how we do undo step, and maybe a new callback in operator type (to say if there should be undo step or not)? @ideasman42 would probably know better here though.

Pratik Borhade commented

2022-07-14 12:59:16 +02:00

@mont29 hi, did you see the patch {D15345}?

@mont29 hi, did you see the patch {[D15345](https://archive.blender.org/developer/D15345)}?

Bastien Montagne commented

2022-07-14 14:13:20 +02:00

@PratikPB2123 no indeed.... would not have gone that way personally, but if Campbell is fine with it... Not sure why I got pinged on this task then though, guess @dr.sybren did not see the patch either. ;)