Spreadsheet does not change when the theme changes #92492

New Issue

Sergey · 2021-10-26T11:23:49+02:00

Sergey commented

2021-10-26 11:23:49 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12

Blender Version
Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-10-23 20:02, hash: 8c21667f3c
Worked: (newest version of Blender that worked as expected)

Short description of error
The theme change is incorrectly applied to the Spreadsheet. In some themes, it does not change (for example in XSI which I prefer, or in Print Friendly). In others, it changes partially and is poorly readable (Blender Light)

Exact steps for others to reproduce the error

Add Spreadsheet to the layout
Change theme to XSI

Or to Print Friendly

Or to Blender Light

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.12 **Blender Version** Broken: version: 3.0.0 Alpha, branch: master, commit date: 2021-10-23 20:02, hash: `8c21667f3c` Worked: (newest version of Blender that worked as expected) **Short description of error** The theme change is incorrectly applied to the Spreadsheet. In some themes, it does not change (for example in XSI which I prefer, or in Print Friendly). In others, it changes partially and is poorly readable (Blender Light) **Exact steps for others to reproduce the error** Add Spreadsheet to the layout Change theme to XSI ![Spreadsheet.png](https://archive.blender.org/developer/F11518547/Spreadsheet.png) Or to Print Friendly ![Spreadsheet2.png](https://archive.blender.org/developer/F11518557/Spreadsheet2.png) Or to Blender Light ![Blender Light.png](https://archive.blender.org/developer/F11518566/Blender_Light.png)

Sergey commented

2021-10-26 11:23:49 +02:00

Added subscriber: @borschberry

Philipp Oeser commented

2021-10-26 12:47:48 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2021-10-26 12:47:48 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2021-10-26 12:47:48 +02:00

Can confirm, these need updating.

Peter Sergay commented

2021-10-27 17:17:29 +02:00

Added subscriber: @Walnert

Peter Sergay commented

2021-10-27 17:17:29 +02:00

Would this be solved by going in and editing the XML files of the themes that aren't working, or by editing the way the Spreadsheet is rendered?

Hans Goudey commented

2021-10-29 03:03:43 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-10-29 03:03:43 +02:00

@Walnert I think those themes just haven't been updated to support the spreadsheet. I honestly don't know if we handle that as a bug or not, so I'll leave this task as is for now.

But it should be a relatively simple thing to fix anyway.

@Walnert I think those themes just haven't been updated to support the spreadsheet. I honestly don't know if we handle that as a bug or not, so I'll leave this task as is for now. But it should be a relatively simple thing to fix anyway.

Peter Sergay self-assigned this 2021-10-29 17:01:53 +02:00

Peter Sergay commented

2021-10-29 17:01:53 +02:00

I'll go and update them!

Peter Sergay commented

2021-10-29 17:52:59 +02:00

I updated Blender Light, Print Friendly, White, and XSI. Here's a .zip folder with the updated themes. I'm going to try to submit a revision to make these the official themes going forward, but until then, you can download them from this zip.
interface_theme.zip

I updated Blender Light, Print Friendly, White, and XSI. Here's a .zip folder with the updated themes. I'm going to try to submit a revision to make these the official themes going forward, but until then, you can download them from this zip. [interface_theme.zip](https://archive.blender.org/developer/F11600571/interface_theme.zip)

Jacques Lucke commented

2021-11-19 11:08:38 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2021-11-19 11:08:38 +01:00

@Walnert can you submit the changes as a patch? That would make it much easier to review and commit them.

Peter Sergay commented

2021-11-19 19:22:22 +01:00

@JacquesLucke I am submitting the changes as a two separate patches, one for the Blender Light theme and one for all the other themes. The Blender Light update was committed, and I'm trying to work through some commit errors on the addon theme updates D13089: Updated Addon Themes for Spreadsheet Workspace

@JacquesLucke I am submitting the changes as a two separate patches, one for the Blender Light theme and one for all the other themes. The Blender Light update was committed, and I'm trying to work through some commit errors on the addon theme updates [D13089: Updated Addon Themes for Spreadsheet Workspace](https://archive.blender.org/developer/D13089)

blender-admin commented

2021-11-24 18:36:09 +01:00

This issue was referenced by blender/blender-addons@d077a9bde0

This issue was referenced by blender/blender-addons@d077a9bde03d0a73d62cacf8a1372f1d5bb7062f

Hans Goudey commented

2021-11-24 18:38:03 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2021-11-24 18:38:03 +01:00

Sign in to join this conversation.