Multiscatter GGX is bugged #92520

Closed
opened 2021-10-27 05:38:55 +02:00 by Alexander Fry · 8 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.13

Blender Version
Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: a791bdabd0
Worked: (newest version of Blender that worked as expected)

Short description of error
On a glossy Multiscatter GGX material, highlight on reflection seem to look dark and kinda like a donut at around 0.02 roughness.
It also seems to change depending on focal length and only happens when using the environment to light the scene

rough 0.03 rough 0.02
r03.png r02.png

Exact steps for others to reproduce the error

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.13 **Blender Version** Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: `a791bdabd0` Worked: (newest version of Blender that worked as expected) **Short description of error** On a glossy Multiscatter GGX material, highlight on reflection seem to look dark and kinda like a donut at around 0.02 roughness. It also seems to change depending on focal length and only happens when using the environment to light the scene > | rough 0.03 | rough 0.02 | > |---|---| > | ![r03.png](https://archive.blender.org/developer/F11538239/r03.png) | ![r02.png](https://archive.blender.org/developer/F11538242/r02.png) | **Exact steps for others to reproduce the error** - Add an HDRI to the scene - On an object (preferably flat) set a Glossy BRDF material with Multiscatter GGX The HDRi used in the image is this one: https://polyhaven.com/a/autoshop_01 [multiscatter_bug.blend](https://archive.blender.org/developer/F11551589/multiscatter_bug.blend)
Author

Added subscriber: @DHX

Added subscriber: @DHX

Added subscriber: @deadpin

Added subscriber: @deadpin

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

I can confirm the issue as far back as 2.79 (with a similar, adjusted, roughness of 0.0004 since that was before we squared roughness inputs) so it's probably been there since Multiscatter GGX was introduced. That said, I'm not sure if it's the fault of the academic paper used for reference or the implementation hitting a numerical degenerate case. This happens for the general range of 0.018 through 0.03.

Will let the devs decide.

A decent HDRi to use is this one: https://polyhaven.com/a/autoshop_01

rough 0.03 rough 0.02
r03.png r02.png
I can confirm the issue as far back as 2.79 (with a similar, adjusted, roughness of 0.0004 since that was before we squared roughness inputs) so it's probably been there since Multiscatter GGX was introduced. That said, I'm not sure if it's the fault of the academic paper used for reference or the implementation hitting a numerical degenerate case. This happens for the general range of 0.018 through 0.03. Will let the devs decide. A decent HDRi to use is this one: https://polyhaven.com/a/autoshop_01 | rough 0.03 | rough 0.02 | |---|---| | ![r03.png](https://archive.blender.org/developer/F11538239/r03.png) | ![r02.png](https://archive.blender.org/developer/F11538242/r02.png) |

Added subscriber: @khana

Added subscriber: @khana

I have the same issue :
https://developer.blender.org/T82500
https://developer.blender.org/T88595

The whole rough range from 0 to 0.125 is wrong.

I have the same issue : https://developer.blender.org/T82500 https://developer.blender.org/T88595 The whole rough range from 0 to 0.125 is wrong.
Philipp Oeser removed the
Interest
Render & Cycles
label 2023-02-09 14:02:56 +01:00

@LukasStockner Can you please check and reply accordingly? Might be fixed after all the shading changes for Principled v2.

@LukasStockner Can you please check and reply accordingly? Might be fixed after all the shading changes for Principled v2.
Member

Yes, this can be closed since the Multiscattering GGX code was removed in 4.0 (the option is still named the same, but the implementation is completely different now).

Yes, this can be closed since the Multiscattering GGX code was removed in 4.0 (the option is still named the same, but the implementation is completely different now).
Blender Bot added
Status
Archived
and removed
Status
Needs Info from Developers
labels 2024-03-02 01:17:00 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#92520
No description provided.