Keyframes Freak Out While Tweaking NLA Strip #92549

New Issue

Jonathan Lampel · 2021-10-28T01:01:26+02:00

Jonathan Lampel commented

2021-10-28 01:01:26 +02:00

System Information
Operating system: Windows-10-10.0.18363-SP0 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-10-27 16:56, hash: 39c11c03d0
This is also broken in the 3.0 Alpha!
Worked: (newest version of Blender that worked as expected)
Commit that introduced this issue: 7f1fe10595

Short description of error
The keyframes in an NLA strip start to freak out in Tweak mode, even when just changing the UI such as zooming in or out, but it also sometimes occurs while adding new keyframes, selecting keyframes, renaming the action, etc. Essentially whenever the animation updates.

Exact steps for others to reproduce the error
keyframe_bug.blend

Open the attached file, which is just a default cube with two NLA strips.
Enter tweak mode on the second strip
Move your mouse around the Action Editor, zoom in and out, select keyframes, or place a new keyframe

**System Information** Operating system: Windows-10-10.0.18363-SP0 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-10-27 16:56, hash: `39c11c03d0` This is also broken in the 3.0 Alpha! Worked: (newest version of Blender that worked as expected) Commit that introduced this issue: 7f1fe10595 **Short description of error** The keyframes in an NLA strip start to freak out in Tweak mode, even when just changing the UI such as zooming in or out, but it also sometimes occurs while adding new keyframes, selecting keyframes, renaming the action, etc. Essentially whenever the animation updates. **Exact steps for others to reproduce the error** [keyframe_bug.blend](https://archive.blender.org/developer/F11555755/keyframe_bug.blend) 1. Open the attached file, which is just a default cube with two NLA strips. 2. Enter tweak mode on the second strip 3. Move your mouse around the Action Editor, zoom in and out, select keyframes, or place a new keyframe ![a5rGacokA9.gif](https://archive.blender.org/developer/F11555748/a5rGacokA9.gif)

Jonathan Lampel commented

2021-10-28 01:01:26 +02:00

Added subscriber: @JonathanLampel-4

Richard Antalik commented

2021-10-28 12:10:12 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-10-28 12:10:12 +02:00

Can confirm the issue, but not quite sure if this is runtime bug or your file is corrupted. In case of runtime bug, it's introduced between b42354672e and 26141664f0.

Will check if I can reproduce from scratch

Can confirm the issue, but not quite sure if this is runtime bug or your file is corrupted. In case of runtime bug, it's introduced between b42354672e and 26141664f0. Will check if I can reproduce from scratch

Richard Antalik commented

2021-10-28 12:25:06 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2021-10-28 12:25:06 +02:00

I wasn't able to reproduce this from scratch. @JonathanLampel-4 can you provide steps how to cause this state?

Will confirm anyway, but not sure if this is possible to fix in already broken files.

I wasn't able to reproduce this from scratch. @JonathanLampel-4 can you provide steps how to cause this state? Will confirm anyway, but not sure if this is possible to fix in already broken files.

Jonathan Lampel commented

2021-10-28 18:27:14 +02:00

Sure! This was actually happening in a much larger file and I reproduced it with the default scene to keep things simple. I think it may have to do with having more than one NLA strip. Here's what to do:

Give the default cube location, rotation, and scale keyframes on three different frames, just to have some animation data
Switch to the Animation workspace and add an NLA editor
Change the Dope Sheet to the Action Editor
Push the current action down and create a new one
Give the cube some more keyframes in the second action
Push the second action down
Tweak the first action a little bit by moving keys around or adding new ones
Tweak the second action, zoom in and out in the Action Editor, and add new keyframes

Sure! This was actually happening in a much larger file and I reproduced it with the default scene to keep things simple. I think it may have to do with having more than one NLA strip. Here's what to do: - Give the default cube location, rotation, and scale keyframes on three different frames, just to have some animation data - Switch to the Animation workspace and add an NLA editor - Change the Dope Sheet to the Action Editor - Push the current action down and create a new one - Give the cube some more keyframes in the second action - Push the second action down - Tweak the first action a little bit by moving keys around or adding new ones - Tweak the second action, zoom in and out in the Action Editor, and add new keyframes

Richard Antalik commented

2021-10-29 07:25:26 +02:00

Can't reproduce this issue from scratch with provided steps. This could be caused perhaps by addon or maybe even UI layout, can you check if you can reproduce when you load factory settings?

Jonathan Lampel commented

2021-10-29 23:54:12 +02:00

I think I have another clue! While trying this again to capture it on video using factory defaults I noticed that it really only happens when there are more more than one NLA strips and the strip is moved around before entering tweak mode. keyframe_freakout.mp4

I think I have another clue! While trying this again to capture it on video using factory defaults I noticed that it really only happens when there are more more than one NLA strips and the strip is moved around before entering tweak mode. [keyframe_freakout.mp4](https://archive.blender.org/developer/F11606521/keyframe_freakout.mp4)

Sybren A. Stüvel self-assigned this 2021-11-01 12:56:18 +01:00

Sybren A. Stüvel commented

2021-11-01 12:57:53 +01:00

In future reports, please don't attach large videos. A textual description can be read in seconds, instead of waiting for minutes to watch a video. Also not all developers will have headphones on while working, so might miss any voice-over you maybe recorded. Of course in some cases it can be interesting to have a demo video, but then it's best if it's short & to the point.

In any case, I can reproduce the issue with the example file as well, will see if I can figure out where it comes from.

In future reports, please don't attach large videos. A textual description can be read in seconds, instead of waiting for minutes to watch a video. Also not all developers will have headphones on while working, so might miss any voice-over you maybe recorded. Of course in some cases it can be interesting to have a demo video, but then it's best if it's short & to the point. In any case, I can reproduce the issue with the example file as well, will see if I can figure out where it comes from.

Sybren A. Stüvel removed their assignment 2021-11-01 13:53:20 +01:00

Jeroen Bakker was assigned by Sybren A. Stüvel

2021-11-01 13:53:20 +01:00

Sybren A. Stüvel commented

2021-11-01 13:53:20 +01:00

Added subscribers: @Jeroen-Bakker, @dr.sybren

Sybren A. Stüvel commented

2021-11-01 13:53:20 +01:00

Moving to @Jeroen-Bakker, as he worked on optimizations in this area, which might have caused this.

Jeroen Bakker commented

2021-11-01 14:21:22 +01:00

{7f1fe10595}~1 doesn't have this issue, 7f1fe10595 has this issue. So it is threading related.

{7f1fe10595}~1 doesn't have this issue, 7f1fe10595 has this issue. So it is threading related.

Jeroen Bakker commented

2021-11-01 15:13:20 +01:00

bb3de31f84 fixes the issue by reverting the keylist drawing threading. There seems to be some data that is shared between threads, making incorrect decisions along the way. An assert failed at keyframes_keylist.cc#793 that shows the data corruption.

bb3de31f84 fixes the issue by reverting the keylist drawing threading. There seems to be some data that is shared between threads, making incorrect decisions along the way. An assert failed at `keyframes_keylist.cc#793` that shows the data corruption.

Jeroen Bakker commented

2021-11-01 15:15:02 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2021-11-01 15:15:02 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Keyframes Freak Out While Tweaking NLA Strip #92549