Blender 3.0 beta Cannot open folder shortcuts under Windows #92577

New Issue

Bise Chen · 2021-10-28T16:58:32+02:00

Bise Chen commented

2021-10-28 16:58:32 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits

Blender Version
Broken: version: 3.0.0 Beta 901fa96b7f
Worked: 901fa96b7f~

Short description of error
On Windows cannot open folders shortcuts (by either double or single clicking on them).

Exact steps for others to reproduce the error

Click a folder shortcut (e..g, on Desktop pointing to My Documents).
Use File --> Open.
Navigate to the folder containing the shortcut and try to go inside it (e.g., in the Desktop folder try to enter the My Documents shortcut).

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits **Blender Version** Broken: version: 3.0.0 Beta 901fa96b7f Worked: 901fa96b7f~ **Short description of error** On Windows cannot open folders shortcuts (by either double or single clicking on them). **Exact steps for others to reproduce the error** 1. Click a folder shortcut (e..g, on Desktop pointing to My Documents). 2. Use File --> Open. 3. Navigate to the folder containing the shortcut and try to go inside it (e.g., in the Desktop folder try to enter the My Documents shortcut).

Bise Chen commented

2021-10-28 16:58:32 +02:00

Added subscriber: @bise.chen

blender-admin commented

2021-10-28 16:58:32 +02:00

#93262 was marked as duplicate of this issue

blender-admin commented

2021-10-28 16:58:32 +02:00

#92829 was marked as duplicate of this issue

Bise Chen changed title from ~~Cannot open folder shortcuts under Windows~~ to Blender 3.0 beta Cannot open folder shortcuts under Windows

2021-10-28 17:01:20 +02:00

Harley Acheson commented

2021-10-28 18:02:22 +02:00

Added subscriber: @Harley

Harley Acheson commented

2021-10-28 18:02:22 +02:00

Strangely, shortcuts to folders are opening correctly if you highlight the item then click the "Open" button, but do not work if you simply double-click on the item.

Harley Acheson commented

2021-10-28 20:11:04 +02:00

Added subscriber: @JulianEisel

Harley Acheson commented

2021-10-28 20:11:04 +02:00

This might be one for @Severin.

file_execute handles this kind of redirection (Mac Alias and Windows shortcut) just fine. When you select such an item, click the "Open" button this is called directly and works great.

But when you double-click (or single click with the new option enable), we call mouse_execute and it never makes it to file_execute as file_ensure_hovered_is_active returns false.

When double-clicking I see file_select being called three times, with the first two successful (returning FILE_SELECT_DIR) and the last failing (returning FILE_SELECT_NOTHING). It returns nothing because file_selection_get has return "-2" for sel.last.

This is only double-click and weird that we get three calls to file_select in this case. With 847d355cab - I see I some removals of code that waits to deselect things, so perhaps the item is being deselected?

In 05879f2c36 - I see file_select_deselect_all being called after a comment about "single select, deselect all selected first" but I don't see an explicit check for single select there.

This might be one for @Severin. `file_execute` handles this kind of redirection (Mac Alias and Windows shortcut) just fine. When you select such an item, click the "Open" button this is called directly and works great. But when you double-click (or single click with the new option enable), we call `mouse_execute` and it never makes it to `file_execute` as `file_ensure_hovered_is_active` returns false. When double-clicking I see `file_select` being called three times, with the first two successful (returning FILE_SELECT_DIR) and the last failing (returning FILE_SELECT_NOTHING). It returns nothing because `file_selection_get` has return "-2" for sel.last. This is only double-click and weird that we get three calls to `file_select` in this case. With 847d355cab - I see I some removals of code that waits to deselect things, so perhaps the item is being deselected? In 05879f2c36 - I see file_select_deselect_all being called after a comment about "single select, deselect all selected first" but I don't see an explicit check for single select there.

Bise Chen commented

2021-10-29 03:47:09 +02:00

In #92577#1243362, @Harley wrote:
Strangely, shortcuts to folders are opening correctly if you highlight the item then click the "Open" button, but do not work if you simply double-click on the item.

Thank you for your supplementary explanation.
This may be a minor issue, but it should be corrected.

> In #92577#1243362, @Harley wrote: > Strangely, shortcuts to folders are opening correctly if you highlight the item then click the "Open" button, but do not work if you simply double-click on the item. Thank you for your supplementary explanation. This may be a minor issue, but it should be corrected.

Richard Antalik commented

2021-10-29 10:58:40 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Harley Acheson commented

2021-11-01 05:14:53 +01:00

Added subscriber: @ankitm

Harley Acheson commented

2021-11-01 05:14:53 +01:00

Hey @ankitm can you check this on Mac when you get a chance, as I think this would affect Mac aliases to folders too. If so we can change this description.

Ankit Meel commented

2021-11-02 06:30:01 +01:00

On 75f5edcaf3 mac alias to folders and files work as expected on double click

On 75f5edcaf3 mac alias to folders and files work as expected on double click

Harley Acheson commented

2021-11-02 17:45:46 +01:00

@ankitm - mac alias to folders and files work as expected on double click

Hey, sorry to be pedantic but you definitely tested aliases to folders?

Here on Windows, shortcuts to blends work fine still too. It is only double-clicking on shortcuts to folders that just refresh the current location. Just having a hard time seeing how one could break and not the other.

> @ankitm - mac alias to folders and files work as expected on double click Hey, sorry to be pedantic but you definitely tested aliases to **folders**? Here on Windows, shortcuts to blends work fine still too. It is only double-clicking on shortcuts to folders that just refresh the current location. Just having a hard time seeing how one could break and not the other.

Ankit Meel commented

2021-11-02 17:51:23 +01:00

F11679817

[F11679817](https://archive.blender.org/developer/F11679817/Screen_Recording_2021-11-02_at_22.20.01.mov)

Harley Acheson commented

2021-11-02 18:23:59 +01:00

@ankitm - Thanks for that! Hopefully will help narrow this down.

Harley Acheson commented

2021-11-02 19:58:17 +01:00

Added subscriber: @pablovazquez

Harley Acheson commented

2021-11-02 19:58:17 +01:00

Ray bisected this and the problem starts here:

901fa96b7f

I'm not familiar enough with keymaps and python to help here.

@pablovazquez - Your commit here broke the ability for Windows users to open by double-click (or single click if that option is turned on) shortcuts to folders. This seems like there are multiple operators running and the item is deselected by one of them.

Ray bisected this and the problem starts here: 901fa96b7f I'm not familiar enough with keymaps and python to help here. @pablovazquez - Your commit here broke the ability for Windows users to open by double-click (or single click if that option is turned on) shortcuts to folders. This seems like there are multiple operators running and the item is deselected by one of them.

Richard Antalik commented

2021-11-05 12:05:14 +01:00

Added subscriber: @zgorg

Raimund Klink commented

2021-11-05 12:07:24 +01:00

Added subscriber: @Raimund58

Ray molenkamp commented

2021-11-16 23:24:06 +01:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2021-11-16 23:24:06 +01:00

This is starting to concern me a little bit, we're nearing bcon4 in little over a week and this is still unfixed, 901fa96b7f broke windows in a pretty bad way, either fix the bug or revert the commit, but we cannot ship new functionality that that breaks existing functionality.

Bumping the prio

This is starting to concern me a little bit, we're nearing bcon4 in little over a week and this is still unfixed, 901fa96b7f broke windows in a pretty bad way, either fix the bug or revert the commit, but we *cannot* ship new functionality that that breaks existing functionality. Bumping the prio

Jesse Yurkovich commented

2021-11-21 22:49:46 +01:00

Added subscriber: @Lillya

Bise Chen commented

2021-11-22 03:19:23 +01:00

Under the windows system, there is a built-in function to open a folder or file with a single press of a button. You only need to set it in the viewing options, but almost no one uses this single-press function.

I don’t understand the purpose of adding 901fa96b7f in Blender 3.0

Under the windows system, there is a built-in function to open a folder or file with a single press of a button. You only need to set it in the viewing options, but almost no one uses this single-press function. I don’t understand the purpose of adding 901fa96b7f in Blender 3.0

Julian Eisel self-assigned this 2021-11-26 20:12:26 +01:00

Julian Eisel commented

2021-11-26 20:12:26 +01:00

I have a fix for this ready but don't have the time to upload and explain it now. Will do it later today or tomorrow.

Bise Chen commented

2021-11-27 14:53:54 +01:00

In #92577#1260673, @JulianEisel wrote:
I have a fix for this ready but don't have the time to upload and explain it now. Will do it later today or tomorrow.

Hello Julian Eisel

This feature also has the same problem in 3.1 Alpha, I think it should be fixed together.

> In #92577#1260673, @JulianEisel wrote: > I have a fix for this ready but don't have the time to upload and explain it now. Will do it later today or tomorrow. Hello Julian Eisel This feature also has the same problem in 3.1 Alpha, I think it should be fixed together.

blender-admin commented

2021-11-30 11:24:36 +01:00

This issue was referenced by 2e53f8b4b1

This issue was referenced by 2e53f8b4b13186ef9ca04e1979c548ea1acdc763

Julian Eisel commented

2021-11-30 11:30:02 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2021-11-30 11:30:02 +01:00

Thomas Dinges added this to the 3.0 milestone 2023-02-08 15:58:48 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Blender 3.0 beta Cannot open folder shortcuts under Windows #92577