Asset browser doesn't update previews #92593

New Issue

Aleksandr · 2021-10-29T02:16:46+02:00

Aleksandr commented

2021-10-29 02:16:46 +02:00

System Information
Operating system: Linux-5.11.0-38-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.74

Blender Version
Broken: version: 3.0.0 Beta, branch: master, commit date: 2021-10-27 22:07, hash: b838eaf2b9
Worked: (newest version of Blender that worked as expected)

Short description of error
Asset browser doesn't update previews of modified objects. Even when I remark item as asset again - asset browser use previously cached image not a new.

Exact steps for others to reproduce the error
Create cube - mark as asset and save file - modify dramatically mesh - save again - refresh asset browser - click Clear Asset on your mesh in outliner - click Mark Asset. Take a look that preview of object incorrect in Asset Browser.

Screencast-2021-10-29_03.07.03.mp4

**System Information** Operating system: Linux-5.11.0-38-generic-x86_64-with-glibc2.31 64 Bits Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.74 **Blender Version** Broken: version: 3.0.0 Beta, branch: master, commit date: 2021-10-27 22:07, hash: `b838eaf2b9` Worked: (newest version of Blender that worked as expected) **Short description of error** Asset browser doesn't update previews of modified objects. Even when I remark item as asset again - asset browser use previously cached image not a new. **Exact steps for others to reproduce the error** Create cube - mark as asset and save file - modify dramatically mesh - save again - refresh asset browser - click Clear Asset on your mesh in outliner - click Mark Asset. Take a look that preview of object incorrect in Asset Browser. [Screencast-2021-10-29_03.07.03.mp4](https://archive.blender.org/developer/F11584225/Screencast-2021-10-29_03.07.03.mp4)

Aleksandr commented

2021-10-29 02:16:46 +02:00

Added subscriber: @viadvena

Pratik Borhade commented

2021-10-29 07:59:03 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-10-29 07:59:03 +02:00

Hi, thanks for the report. Can you update the preview from Sidebar? ({nav sidebar > Preview > Generate Preview})

(Not sure if this is a bug but I think Refresh should update the preview.)

Hi, thanks for the report. Can you update the preview from Sidebar? ({nav sidebar > Preview > Generate Preview}) ![image.png](https://archive.blender.org/developer/F11590239/image.png) (Not sure if this is a bug but I think `Refresh` should update the preview.)

Jesse Yurkovich commented

2021-10-29 08:08:23 +02:00

Added subscriber: @deadpin

Jesse Yurkovich commented

2021-10-29 08:08:23 +02:00

There's a few things here:

The "Refresh" operator only does what the tooltip says "Refresh the file list". It will not re-generate the previews for all the assets.
Yes, using the "Generate Preview" operator is the proper way to refresh a particular asset's preview after each modification etc.
However, the video shows that if you clear the asset, and then re-mark as an asset, the preview is not correct. I think this is a bug. Clearing an asset should remove all prior asset data associated with it.

There's a few things here: - The "Refresh" operator only does what the tooltip says "Refresh the file list". It will not re-generate the previews for all the assets. - Yes, using the "Generate Preview" operator is the proper way to refresh a particular asset's preview after each modification etc. - However, the video shows that if you clear the asset, and then re-mark as an asset, the preview is not correct. I think this is a bug. Clearing an asset should remove all prior asset data associated with it.

Richard Antalik commented

2021-10-29 09:15:06 +02:00

Added subscriber: @iss

Richard Antalik commented

2021-10-29 09:15:06 +02:00

This has been discussed in #90205, Though here it is bit different case in that you are clearing an asset and then making new one. Will check what should happen

Richard Antalik commented

2021-10-29 10:01:20 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2021-10-29 10:01:20 +02:00

Currently preview is not cleared when asset is cleared, but I don't see whether this is intentional. This should be possible and easy to do, so will confirm, but I am not fully aware of storage access restrictions.

Aleksandr commented

2021-10-29 17:16:51 +02:00

In #92593#1243778, @PratikPB2123 wrote:
Hi, thanks for the report. Can you update the preview from Sidebar? ({nav sidebar > Preview > Generate Preview})

(Not sure if this is a bug but I think Refresh should update the preview.)

Hi. Yes, it works from there. But it's definitely should be automatic after repeated "mark as assets" how @deadpin has noticed .

> In #92593#1243778, @PratikPB2123 wrote: > Hi, thanks for the report. Can you update the preview from Sidebar? ({nav sidebar > Preview > Generate Preview}) > > ![image.png](https://archive.blender.org/developer/F11590239/image.png) > > (Not sure if this is a bug but I think `Refresh` should update the preview.) Hi. Yes, it works from there. But it's definitely should be automatic after repeated "mark as assets" how @deadpin has noticed .

Julian Eisel commented

2021-11-01 12:54:07 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2021-11-01 12:54:07 +01:00

In #92593#1243780, @deadpin wrote:
There's a few things here:

The "Refresh" operator only does what the tooltip says "Refresh the file list". It will not re-generate the previews for all the assets.

That is correct. Refreshing previews is expensive and would take a while when executed on an entire asset library. So users have to manually do it on individual assets.
The tooltip for the refresh operator wasn't too clear about what it's doing, so I committed {dcdbaf89bd11}.

Yes, using the "Generate Preview" operator is the proper way to refresh a particular asset's preview after each modification etc.

Right.

However, the video shows that if you clear the asset, and then re-mark as an asset, the preview is not correct. I think this is a bug. Clearing an asset should remove all prior asset data associated with it.

It's not really intuitive, but technically the preview is not part of the asset meta-data, it is stored as part of the data-block (e.g. the object) itself. This way even objects that are not assets can have a preview image. But still, when calling Mark as Asset, the preview should be re-rendered IMO. Currently, this isn't done because the object's preview isn't marked as changed (which is done via the depsgraph for materials and some other data-blocks), so the preview rendering skips the re-rendering. After a quick check with Sybren, we decided it's better to always force a re-render on Mark as Asset.

> In #92593#1243780, @deadpin wrote: > There's a few things here: > - The "Refresh" operator only does what the tooltip says "Refresh the file list". It will not re-generate the previews for all the assets. That is correct. Refreshing previews is expensive and would take a while when executed on an entire asset library. So users have to manually do it on individual assets. The tooltip for the refresh operator wasn't too clear about what it's doing, so I committed {dcdbaf89bd11}. > - Yes, using the "Generate Preview" operator is the proper way to refresh a particular asset's preview after each modification etc. Right. > - However, the video shows that if you clear the asset, and then re-mark as an asset, the preview is not correct. I think this is a bug. Clearing an asset should remove all prior asset data associated with it. It's not really intuitive, but technically the preview is not part of the asset meta-data, it is stored as part of the data-block (e.g. the object) itself. This way even objects that are not assets can have a preview image. But still, when calling *Mark as Asset*, the preview should be re-rendered IMO. Currently, this isn't done because the object's preview isn't marked as changed (which is done via the depsgraph for materials and some other data-blocks), so the preview rendering skips the re-rendering. After a quick check with Sybren, we decided it's better to always force a re-render on *Mark as Asset*.

blender-admin commented

2021-11-01 12:58:33 +01:00

This issue was referenced by d5e343be27

This issue was referenced by d5e343be2752afa34fcbcca235e2eddf46836ad5

Julian Eisel commented

2021-11-01 13:02:35 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2021-11-01 13:02:35 +01:00

Julian Eisel self-assigned this 2021-11-01 13:02:35 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Asset browser doesn't update previews #92593