Spreadsheet evaluation state and solidify modifier change viewport results #92649

New Issue

Gerstmann Bradley · 2021-10-30T16:18:50+02:00

Gerstmann Bradley commented

2021-10-30 16:18:50 +02:00

System Information
Operating system: Windows-10-10.0.17134-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11

Blender Version
Broken: version: 3.0.0 Beta, branch: master, commit date: 2021-10-29 18:17, hash: fcf1ba18f0
Worked: (newest version of Blender that worked as expected)

Short description of error
In addition to the issue stated within the video,
I want to add several other points:

Issue persists if you close blender and re-open it.
both Eevee and Cycle is having the same issue.
When Solidify modifier is enabled, you can render both states in viewport rendering. But if You render the animation (F12), only colorful state will be rendered.
When Solidify Modifier is disabled, you can only render the green state, which turns colorful later.
The green State is a desired result from this setup in my opinion.
BUG REPORT_.mp4

Original file:
BUG REPORT2.blend

Simplified file:
#92649 Simplified.blend

Simpler reproduce steps:

Play animation
Toggle viewer node on and off

**System Information** Operating system: Windows-10-10.0.17134-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11 **Blender Version** Broken: version: 3.0.0 Beta, branch: master, commit date: 2021-10-29 18:17, hash: `fcf1ba18f0` Worked: (newest version of Blender that worked as expected) **Short description of error** In addition to the issue stated within the video, I want to add several other points: 1. Issue persists if you close blender and re-open it. 2. both Eevee and Cycle is having the same issue. 3. When Solidify modifier is enabled, you can render both states in viewport rendering. But if You render the animation (F12), only colorful state will be rendered. 4. When Solidify Modifier is disabled, you can only render the green state, which turns colorful later. 5. The green State is a desired result from this setup in my opinion. [BUG REPORT_.mp4](https://archive.blender.org/developer/F11621871/BUG_REPORT_.mp4) Original file: [BUG REPORT2.blend](https://archive.blender.org/developer/F11621915/BUG_REPORT2.blend) Simplified file: [#92649 Simplified.blend](https://archive.blender.org/developer/F11663780/T92649_Simplified.blend) Simpler reproduce steps: - Play animation - Toggle viewer node on and off

Gerstmann Bradley commented

2021-10-30 16:18:50 +02:00

Added subscriber: @Bradley_G

Hans Goudey commented

2021-11-01 19:34:14 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-11-01 19:34:14 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2021-11-01 19:34:14 +01:00

Thanks for the report. I can confirm this.

I simplified the file, so I'll update the report.

Thanks for the report. I can confirm this. I simplified the file, so I'll update the report.

Hans Goudey changed title from ~~Different Viewport Results and Solidify Modifier is changing the attribute~~ to Spreadsheet evaluation state and solidify modifier change viewport results

2021-11-01 19:36:37 +01:00

Martijn Versteegh commented

2021-11-02 14:26:24 +01:00

Added subscriber: @Baardaap

Martijn Versteegh commented

2021-11-02 14:26:24 +01:00

What I found so far (somewhat handwavy, because I get so many warnings from a thread debugger all over the place) is that

in the file draw_cache_extract_mesh.cc:
in the function static void mesh_extract_render_data_node_exec(void *__restrict task_data):

The function mesh_render_data_update_normals(mr, data_flag) is called, while the GN tree is still evaluating.
This needs locking I think, but I have no clue where and how. I don't really see any locking at all in that function, so I assume there is some global render lock which should prevent this?

(I'll try to look into it in more detail later, but for today this is what I have time for.)

What I found so far (somewhat handwavy, because I get *so* *many* *warnings* from a thread debugger all over the place) is that in the file draw_cache_extract_mesh.cc: in the function static void mesh_extract_render_data_node_exec(void *__restrict task_data): The function mesh_render_data_update_normals(mr, data_flag) is called, while the GN tree is still evaluating. This needs locking I think, but I have no clue where and how. I don't really see any locking at all in that function, so I assume there is some global render lock which should prevent this? (I'll try to look into it in more detail later, but for today this is what I have time for.)

Hans Goudey commented

2021-11-02 14:46:24 +01:00

Thanks for your testing.

I'm not that familiar with this area, but I don't think adding a lock to that specific function is a proper solution.
Generally I don't think drawing a mesh should be happening at the same time it's evaluated, so it seems like the problem is a bit more general than just that function.

Thanks for your testing. I'm not that familiar with this area, but I don't think adding a lock to that specific function is a proper solution. Generally I don't think drawing a mesh should be happening at the same time it's evaluated, so it seems like the problem is a bit more general than just that function.

Martijn Versteegh commented

2021-11-02 16:34:48 +01:00

woops. my comment was meant for #92606 Though it might be related my thread debugging was done with that testcase.

Jacques Lucke self-assigned this 2021-11-03 11:54:48 +01:00

blender-admin commented

2021-11-04 14:41:22 +01:00

This issue was referenced by ff4959eeaa

This issue was referenced by ff4959eeaa5368d79f15d482da6576a1ccba5dca

Jacques Lucke commented

2021-11-04 14:42:20 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2021-11-04 14:42:20 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Spreadsheet evaluation state and solidify modifier change viewport results #92649